Age | Commit message (Collapse) | Author |
|
Change-Id: I4d09040f6f75899eb1412f84c5978d1a2570c9c5
|
|
a1824beabf am: 379937a03f
am: 584f90b5e1
Change-Id: I67b17f3c802e4e3139abf245e5dffce58a2c9000
|
|
am: 379937a03f
Change-Id: Ief301c551a48b44e8518f7b51cbe2e16ff5c23b9
|
|
am: a1824beabf
Change-Id: I1b289726c3eb9ee21a36d2047e1b019de6d96bb7
|
|
Upstream deprecated all *_TEST_CASE_* macros in favor of new *_TEST_SUITE_* macros. But there are still thousands of references to the old ones in Android. As suggested here:
https://github.com/google/googletest/commit/db9b85e27522628ef173149a692031b7f2154b55
I defined GTEST_INTERNAL_DEPRECATED to empty to suppress warnings.
Test: build
Change-Id: Ifffd9f98ab40adde65031d45acf9c47cc252b069
|
|
PiperOrigin-RevId: 236716851
|
|
Fix emission of -Wzero-as-null-pointer-constant when comparing integers.
The following code fails to compile:
#pragma clang diagnostic error "-Wzero-as-null-pointer-constant"
void foo() {
EXPECT_EQ(0, 0);
}
This happens because gtest checks the first argument to EXPECT_EQ and
ASSERT_EQ is a null pointer constant. The magic it does to do this causes the
warning to be emitted.
This patch removes that check. It replaces the explicit check with a Compare
overload that can only be selected when 0 or nullptr is passed on the LHS
with a pointer on the right.
This patch does not suppress -Wzero-as-null-pointer-constant when users
are actually using it as NULL.
PiperOrigin-RevId: 236654634
|
|
Build gmock cleanly with clang -Wextra-semi and -Wextra-semi-stmt
Extends 56ef07a20308 to take -Wc++98-compat-extra-semi
(https://reviews.llvm.org/D43162) and -Wextra-semi-stmt
(https://reviews.llvm.org/D52695) into account.
For https://crbug.com/926235.
PiperOrigin-RevId: 236643095
|
|
Let embedders customize GTEST_INTERNAL_DEPRECATED().
GTEST_INTERNAL_DEPRECATED is currently used to nudge googletest users to migrate off old TEST_CASE macros to the new TEST_SUITE macros. This move is non-trivial for Chromium (see https://crbug.com/925652), and might be difficult for other big projects with many dependencies.
This CL facilitates moving off of deprecated APIs by making it possible for an embedder to define GTEST_INTERNAL_DEPRECATED() in gtest/internal/custom/gtest-port.h. Example usage:
1) #define GTEST_INTERNAL_DEPRECATED() to nothing, to disable deprecation warnings while migrating off googletest's deprecated APIs. This can be preferable to having to disable all deprecation warnings (-Wno-error=deprecated or -Wno-deprecated-declarations).
2) #define GTEST_INTERNAL_DEPRECATED() for an unsupported compiler.
PiperOrigin-RevId: 236171043
|
|
Build gmock cleanly with clang -Wextra-semi
For https://crbug.com/926235.
From https://github.com/google/googletest/pull/2139.
Fixes https://github.com/google/googletest/issues/2138.
PiperOrigin-RevId: 235832527
|
|
|
|
Change-Id: I149d1169bc672fa16abbaaddc76f574e33828963
|
|
Replace more pump'd code with variadic templates.
PiperOrigin-RevId: 235584585
|
|
Fix grammatical error in primer.md
|
|
|
|
am: 3f9af3b5e4
Change-Id: I0ced979eaa1b88d2ee8dd86e2e91b87911fc3f1b
|
|
Bug: 126125118
Change-Id: I1af93598273f40882fb512b37aa3bc3e9f3f8ee8
|
|
ngie-eign:gtest-test-death-test-dont-hardcode-test-name
PiperOrigin-RevId: 235248114
|
|
PiperOrigin-RevId: 235220570
|
|
`CxxExceptionDeathTest.PrintsMessageForStdException`
Due to some caveats in the FreeBSD build system and the fact that the
source file is used to compile 2 different death tests with different
flags, I needed (as a shortterm workaround) to copy the test to 2
differently named files.
While this works for compiling the test, as I discovered, this doesn't
work with running `CxxExceptionDeathTest.PrintsMessageForStdException`,
as the testcase hardcodes `googletest-death-test_ex_test.cc`. Use `__FILE__`
when looking for failures, as opposed to looking for the hardcoded name
as it can vary depending on how the test was built.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
PiperOrigin-RevId: 235012245
|
|
Bug: 120848293
Change-Id: I8f3e65c59d32019870354f9e17626c85670efa8c
|
|
PiperOrigin-RevId: 234845565
|
|
PiperOrigin-RevId: 234844287
|
|
PiperOrigin-RevId: 234840107
|
|
Internal Change
PiperOrigin-RevId: 234823465
|
|
Update gtest-death-test to use new Fuchsia API
Fuchsia has renamed this API and removed the need for several parameters. We now use the newer, simpler API.
PiperOrigin-RevId: 234617715
|
|
Avoid array index out of range
|
|
Issue: #2140
|
|
clang++ compilation when `-Wsign-conversion` is currently broken and the
issues within the code are varied and widespread. For the time being
ignore `-Wsign-conversion` issues, even though some of them are valid
and bleed over into issues that would be found with
`-Wtautological-compare`, et al.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
Comment out unused method parameters in their relevant definitions.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
`DescribeTo(..)` and `MatchAndExplain(..)` in `gmock-matchers_test` both
override virtual methods. Remove the `virtual` keyword and apply `override` to
them instead.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
`DescribeTo(..)` and `MatchAndExplain(..)` in `gmock-matchers_test` both
override virtual methods. Remove the `virtual` keyword and apply `override` to
them instead.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
PiperOrigin-RevId: 233825166
|
|
PiperOrigin-RevId: 233789488
|
|
PiperOrigin-RevId: 233773676
|
|
PiperOrigin-RevId: 233762751
|
|
PiperOrigin-RevId: 233762520
|
|
PiperOrigin-RevId: 233748252
|
|
As noted in the patch description:
* Add DragonFly and GNU/kFreeBSD support.
* Implement GetThreadCount() for BSDs.
1. https://svnweb.freebsd.org/ports/head/devel/googletest/files/patch-bsd-defines?revision=488934
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
It was not compiling any of the code with warnings prior to this.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
Provide dummy accessors for private values that are set in initializers,
but not actually used.
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
|
|
Internal Change
PiperOrigin-RevId: 233614147
|
|
PiperOrigin-RevId: 233108234
|
|
PiperOrigin-RevId: 233096223
|
|
Internal changes.
PiperOrigin-RevId: 232953166
|
|
Fix matcher comparisons for std::reference_wrapper.
The googletest docs indicate that std::reference_wrapper should be used to for
objects that should not be copied by the matcher (in fact, the ByRef() function
is basically the same as a call to std::cref).
However, for many types (such as std::string), the overloaded operator== will
not resolve correctly. Specifically, this is problematic if operator== depends
on template argument deduction, where the same type is named on LHS and RHS.
Because template argument deduction happens before any implict conversions for
purposes of overload resolution, attempting to compare T with
std::reference_wrapper<T> simply looks like a comparison of unlike types.
For exapmle, std::reference_wrapper<std::string> is implicitly convertible to
'const std::string&', which would be able to choose an overload specialization
of operator==. However, the implicit conversion can only happen after template
argument deduction for operator==, so a specialization that would other be an
applicable overload is never considered.
Note also that this change only affects matchers. There are good reasons that
matchers may need to transparently hold a std::reference_wrapper. Other
comparisons (like EXPECT_EQ, et. al.) don't need to capture a reference: they
don't need to defer evaluation (as in googlemock), and they don't need to avoid
copies (as the call chain of matchers does).
PiperOrigin-RevId: 232499175
|
|
Internal change
PiperOrigin-RevId: 232362580
|
|
Signed-off-by: Knut Omang <knut.omang@oracle.com>
|