aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-16Snap for 5381581 from c871e1df34e148591dcb7a45684cfaa561d09771 to qt-releaseandroid-vts-10.0_r9android-vts-10.0_r8android-vts-10.0_r7android-vts-10.0_r6android-vts-10.0_r5android-vts-10.0_r4android-vts-10.0_r3android-vts-10.0_r2android-vts-10.0_r16android-vts-10.0_r15android-vts-10.0_r14android-vts-10.0_r13android-vts-10.0_r12android-vts-10.0_r11android-vts-10.0_r10android-vts-10.0_r1android-security-10.0.0_r75android-security-10.0.0_r74android-security-10.0.0_r73android-security-10.0.0_r72android-security-10.0.0_r71android-security-10.0.0_r70android-security-10.0.0_r69android-security-10.0.0_r68android-security-10.0.0_r67android-security-10.0.0_r66android-security-10.0.0_r65android-security-10.0.0_r64android-security-10.0.0_r63android-security-10.0.0_r62android-security-10.0.0_r61android-security-10.0.0_r60android-security-10.0.0_r59android-security-10.0.0_r58android-security-10.0.0_r57android-security-10.0.0_r56android-security-10.0.0_r55android-security-10.0.0_r54android-security-10.0.0_r53android-security-10.0.0_r52android-security-10.0.0_r51android-security-10.0.0_r50android-security-10.0.0_r49android-security-10.0.0_r48android-mainline-10.0.0_r3android-mainline-10.0.0_r2android-mainline-10.0.0_r1android-cts-10.0_r9android-cts-10.0_r8android-cts-10.0_r7android-cts-10.0_r6android-cts-10.0_r5android-cts-10.0_r4android-cts-10.0_r3android-cts-10.0_r2android-cts-10.0_r16android-cts-10.0_r15android-cts-10.0_r14android-cts-10.0_r13android-cts-10.0_r12android-cts-10.0_r11android-cts-10.0_r10android-cts-10.0_r1android-10.0.0_r6android-10.0.0_r5android-10.0.0_r47android-10.0.0_r46android-10.0.0_r4android-10.0.0_r3android-10.0.0_r2android-10.0.0_r17android-10.0.0_r11android-10.0.0_r10android-10.0.0_r1android10-tests-releaseandroid10-security-releaseandroid10-s3-releaseandroid10-s2-releaseandroid10-s1-releaseandroid10-releaseandroid10-mainline-releaseandroid10-mainline-a-releaseandroid10-gsiandroid-build-team Robot
Change-Id: I4d09040f6f75899eb1412f84c5978d1a2570c9c5
2019-03-13Upgrade googletest to 8b6d3f9c4a774bef3081195d422993323b6bb2e0 am: ↵android-mainline-10.0.0_r9android-mainline-10.0.0_r7android-mainline-10.0.0_r5android-mainline-10.0.0_r4android-mainline-10.0.0_r10android-10.0.0_r9android-10.0.0_r8android-10.0.0_r7android-10.0.0_r45android-10.0.0_r44android-10.0.0_r43android-10.0.0_r42android-10.0.0_r41android-10.0.0_r40android-10.0.0_r39android-10.0.0_r38android-10.0.0_r37android-10.0.0_r36android-10.0.0_r35android-10.0.0_r34android-10.0.0_r33android-10.0.0_r32android-10.0.0_r31android-10.0.0_r30android-10.0.0_r29android-10.0.0_r28android-10.0.0_r27android-10.0.0_r26android-10.0.0_r25android-10.0.0_r24android-10.0.0_r23android-10.0.0_r22android-10.0.0_r21android-10.0.0_r20android-10.0.0_r19android-10.0.0_r18android-10.0.0_r16android-10.0.0_r15android-10.0.0_r14android-10.0.0_r13android-10.0.0_r12android10-qpr3-s1-releaseandroid10-qpr3-releaseandroid10-qpr2-s4-releaseandroid10-qpr2-s3-releaseandroid10-qpr2-s2-releaseandroid10-qpr2-s1-releaseandroid10-qpr2-releaseandroid10-qpr1-releaseandroid10-qpr1-mainline-releaseandroid10-qpr1-d-releaseandroid10-qpr1-c-s1-releaseandroid10-qpr1-c-releaseandroid10-qpr1-b-s1-releaseandroid10-qpr1-b-releaseandroid10-mainline-media-releaseandroid10-devandroid10-d4-s1-releaseandroid10-d4-releaseandroid10-c2f2-s2-releaseandroid10-c2f2-s1-releaseandroid10-c2f2-releaseHaibo Huang
a1824beabf am: 379937a03f am: 584f90b5e1 Change-Id: I67b17f3c802e4e3139abf245e5dffce58a2c9000
2019-03-13Upgrade googletest to 8b6d3f9c4a774bef3081195d422993323b6bb2e0 am: a1824beabfHaibo Huang
am: 379937a03f Change-Id: Ief301c551a48b44e8518f7b51cbe2e16ff5c23b9
2019-03-13Upgrade googletest to 8b6d3f9c4a774bef3081195d422993323b6bb2e0Haibo Huang
am: a1824beabf Change-Id: I1b289726c3eb9ee21a36d2047e1b019de6d96bb7
2019-03-13Upgrade googletest to 8b6d3f9c4a774bef3081195d422993323b6bb2e0Haibo Huang
Upstream deprecated all *_TEST_CASE_* macros in favor of new *_TEST_SUITE_* macros. But there are still thousands of references to the old ones in Android. As suggested here: https://github.com/google/googletest/commit/db9b85e27522628ef173149a692031b7f2154b55 I defined GTEST_INTERNAL_DEPRECATED to empty to suppress warnings. Test: build Change-Id: Ifffd9f98ab40adde65031d45acf9c47cc252b069
2019-03-05Merge pull request #2158 from CarloWood:masterGennadiy Civil
PiperOrigin-RevId: 236716851
2019-03-05Googletest exportAbseil Team
Fix emission of -Wzero-as-null-pointer-constant when comparing integers. The following code fails to compile: #pragma clang diagnostic error "-Wzero-as-null-pointer-constant" void foo() { EXPECT_EQ(0, 0); } This happens because gtest checks the first argument to EXPECT_EQ and ASSERT_EQ is a null pointer constant. The magic it does to do this causes the warning to be emitted. This patch removes that check. It replaces the explicit check with a Compare overload that can only be selected when 0 or nullptr is passed on the LHS with a pointer on the right. This patch does not suppress -Wzero-as-null-pointer-constant when users are actually using it as NULL. PiperOrigin-RevId: 236654634
2019-03-05Googletest exportAbseil Team
Build gmock cleanly with clang -Wextra-semi and -Wextra-semi-stmt Extends 56ef07a20308 to take -Wc++98-compat-extra-semi (https://reviews.llvm.org/D43162) and -Wextra-semi-stmt (https://reviews.llvm.org/D52695) into account. For https://crbug.com/926235. PiperOrigin-RevId: 236643095
2019-03-01Googletest exportAbseil Team
Let embedders customize GTEST_INTERNAL_DEPRECATED(). GTEST_INTERNAL_DEPRECATED is currently used to nudge googletest users to migrate off old TEST_CASE macros to the new TEST_SUITE macros. This move is non-trivial for Chromium (see https://crbug.com/925652), and might be difficult for other big projects with many dependencies. This CL facilitates moving off of deprecated APIs by making it possible for an embedder to define GTEST_INTERNAL_DEPRECATED() in gtest/internal/custom/gtest-port.h. Example usage: 1) #define GTEST_INTERNAL_DEPRECATED() to nothing, to disable deprecation warnings while migrating off googletest's deprecated APIs. This can be preferable to having to disable all deprecation warnings (-Wno-error=deprecated or -Wno-deprecated-declarations). 2) #define GTEST_INTERNAL_DEPRECATED() for an unsupported compiler. PiperOrigin-RevId: 236171043
2019-03-01Googletest exportAbseil Team
Build gmock cleanly with clang -Wextra-semi For https://crbug.com/926235. From https://github.com/google/googletest/pull/2139. Fixes https://github.com/google/googletest/issues/2138. PiperOrigin-RevId: 235832527
2019-03-01Minor build system fixes.Carlo Wood
2019-02-26Snap for 5335706 from d9faeec156707b6bce45fc64503ab86fecf80b4f to qt-releaseandroid-build-team Robot
Change-Id: I149d1169bc672fa16abbaaddc76f574e33828963
2019-02-25Googletest exportAbseil Team
Replace more pump'd code with variadic templates. PiperOrigin-RevId: 235584585
2019-02-25Merge pull request #2152 from rsinnet/patch-1Gennadiy Civil
Fix grammatical error in primer.md
2019-02-25Fix grammatical error in primer.mdRyan Sinnet
2019-02-25Merge stage-aosp-master into pi-dev-plus-aospXin Li
am: 3f9af3b5e4 Change-Id: I0ced979eaa1b88d2ee8dd86e2e91b87911fc3f1b
2019-02-25Merge stage-aosp-master into pi-dev-plus-aospXin Li
Bug: 126125118 Change-Id: I1af93598273f40882fb512b37aa3bc3e9f3f8ee8
2019-02-22Merge pull request #2147 from ↵Gennadiy Civil
ngie-eign:gtest-test-death-test-dont-hardcode-test-name PiperOrigin-RevId: 235248114
2019-02-22Merge pull request #2126 from ngie-eign:clang-add-more-strict-warningsGennadiy Civil
PiperOrigin-RevId: 235220570
2019-02-21Don't hardcode the filename in ↵Enji Cooper
`CxxExceptionDeathTest.PrintsMessageForStdException` Due to some caveats in the FreeBSD build system and the fact that the source file is used to compile 2 different death tests with different flags, I needed (as a shortterm workaround) to copy the test to 2 differently named files. While this works for compiling the test, as I discovered, this doesn't work with running `CxxExceptionDeathTest.PrintsMessageForStdException`, as the testcase hardcodes `googletest-death-test_ex_test.cc`. Use `__FILE__` when looking for failures, as opposed to looking for the hardcoded name as it can vary depending on how the test was built. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-21Merge pull request #2137 from ngie-eign:clang-ignore-sign-conversionGennadiy Civil
PiperOrigin-RevId: 235012245
2019-02-20DO NOT MERGE - Merge pi-dev@5234907 into stage-aosp-masterXin Li
Bug: 120848293 Change-Id: I8f3e65c59d32019870354f9e17626c85670efa8c
2019-02-20Merge pull request #2061 from samolisov:building-with-bazel-as-a-dll-on-windowsGennadiy Civil
PiperOrigin-RevId: 234845565
2019-02-20Merge pull request #2125 from ngie-eign:clang-unused-parameterGennadiy Civil
PiperOrigin-RevId: 234844287
2019-02-20Merge pull request #2123 from ngie-eign:clang-inconsistent-missing-overrideGennadiy Civil
PiperOrigin-RevId: 234840107
2019-02-20Googletest exportmisterg
Internal Change PiperOrigin-RevId: 234823465
2019-02-20Googletest exportAbseil Team
Update gtest-death-test to use new Fuchsia API Fuchsia has renamed this API and removed the need for several parameters. We now use the newer, simpler API. PiperOrigin-RevId: 234617715
2019-02-20Merge pull request #2141 from dspinellis/index-fixGennadiy Civil
Avoid array index out of range
2019-02-20Avoid array index out of rangeDiomidis Spinellis
Issue: #2140
2019-02-18Ignore `-Wsign-conversion` issuesEnji Cooper
clang++ compilation when `-Wsign-conversion` is currently broken and the issues within the code are varied and widespread. For the time being ignore `-Wsign-conversion` issues, even though some of them are valid and bleed over into issues that would be found with `-Wtautological-compare`, et al. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-13Fix clang `-Wunused-parameter` warningsEnji Cooper
Comment out unused method parameters in their relevant definitions. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-13Fix clang `-Winconsistent-missing-override` warningsEnji Cooper
`DescribeTo(..)` and `MatchAndExplain(..)` in `gmock-matchers_test` both override virtual methods. Remove the `virtual` keyword and apply `override` to them instead. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-13Fix clang `-Winconsistent-missing-override` warningsEnji Cooper
`DescribeTo(..)` and `MatchAndExplain(..)` in `gmock-matchers_test` both override virtual methods. Remove the `virtual` keyword and apply `override` to them instead. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-13Add `cxx_strict_flags` for clang to match FreeBSD's WARNS flagsEnji Cooper
Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-13Merge pull request #2112 from knuto:pr/fix_null_pointerGennadiy Civil
PiperOrigin-RevId: 233825166
2019-02-13Merge pull request #2121 from ngie-eign:add-dragonflybsd-and-kfreebsd-supportGennadiy Civil
PiperOrigin-RevId: 233789488
2019-02-13Merge pull request #2114 from knuto:pr/libtool_supportGennadiy Civil
PiperOrigin-RevId: 233773676
2019-02-13Merge pull request #2119 from ngie-eign:clang-wunused-private-fieldGennadiy Civil
PiperOrigin-RevId: 233762751
2019-02-13Merge pull request #2120 from ngie-eign:clang-compile-with-basic-warns-flagsGennadiy Civil
PiperOrigin-RevId: 233762520
2019-02-13Merge pull request #2113 from knuto:pr/set_old_gtest_verGennadiy Civil
PiperOrigin-RevId: 233748252
2019-02-12Import `patch-bsd-defines` from FreeBSD ports [1]Enji Cooper
As noted in the patch description: * Add DragonFly and GNU/kFreeBSD support. * Implement GetThreadCount() for BSDs. 1. https://svnweb.freebsd.org/ports/head/devel/googletest/files/patch-bsd-defines?revision=488934 Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-12Compile clang with `-Wall -Wshadow -Werror`Enji Cooper
It was not compiling any of the code with warnings prior to this. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-12Fix -Wunused-private-field issues with clangEnji Cooper
Provide dummy accessors for private values that are set in initializers, but not actually used. Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>
2019-02-12Googletest exportmisterg
Internal Change PiperOrigin-RevId: 233614147
2019-02-12Merge pull request #2107 from ciband:feat/finish_platformio_supportGennadiy Civil
PiperOrigin-RevId: 233108234
2019-02-12Merge pull request #2101 from MaEtUgR:fix-cmake-cygwinGennadiy Civil
PiperOrigin-RevId: 233096223
2019-02-12Googletest exportAbseil Team
Internal changes. PiperOrigin-RevId: 232953166
2019-02-12Googletest exportAbseil Team
Fix matcher comparisons for std::reference_wrapper. The googletest docs indicate that std::reference_wrapper should be used to for objects that should not be copied by the matcher (in fact, the ByRef() function is basically the same as a call to std::cref). However, for many types (such as std::string), the overloaded operator== will not resolve correctly. Specifically, this is problematic if operator== depends on template argument deduction, where the same type is named on LHS and RHS. Because template argument deduction happens before any implict conversions for purposes of overload resolution, attempting to compare T with std::reference_wrapper<T> simply looks like a comparison of unlike types. For exapmle, std::reference_wrapper<std::string> is implicitly convertible to 'const std::string&', which would be able to choose an overload specialization of operator==. However, the implicit conversion can only happen after template argument deduction for operator==, so a specialization that would other be an applicable overload is never considered. Note also that this change only affects matchers. There are good reasons that matchers may need to transparently hold a std::reference_wrapper. Other comparisons (like EXPECT_EQ, et. al.) don't need to capture a reference: they don't need to defer evaluation (as in googlemock), and they don't need to avoid copies (as the call chain of matchers does). PiperOrigin-RevId: 232499175
2019-02-12Googletest exportAbseil Team
Internal change PiperOrigin-RevId: 232362580
2019-02-11Set gtest version correctly for older cmake versionsKnut Omang
Signed-off-by: Knut Omang <knut.omang@oracle.com>