aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMaxime Biais <maxime.biais@gmail.com>2016-09-22 11:25:19 +0200
committerMaxime Biais <maxime.biais@gmail.com>2016-09-22 11:25:19 +0200
commit574d020001a933063dc250a03f0bda25bdb5e28a (patch)
treeb4c96e3fac9afc2eb0bf6ce7a514ddff8e2de280
parent18d175d7556b1267dc7d54128125fa125c6fddac (diff)
downloadgradle-perf-android-medium-574d020001a933063dc250a03f0bda25bdb5e28a.tar.gz
Revert "Avoid downloading media on the UI thread"
This reverts commit 6cc56aa1f4cf30ce845ae524caa5d2d2c6e01f90.
-rw-r--r--WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java29
1 files changed, 8 insertions, 21 deletions
diff --git a/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java b/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
index 276383909..e670d7cd7 100644
--- a/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
+++ b/WordPress/src/main/java/org/wordpress/android/ui/posts/EditPostActivity.java
@@ -1439,34 +1439,21 @@ public class EditPostActivity extends AppCompatActivity implements EditorFragmen
* Media
*/
- private void fetchMedia(final List<Uri> mediaUris) {
- new AsyncTask<List<Uri>, Boolean, Void>() {
- @Override
- protected Void doInBackground(List<Uri>... lists) {
- for (Uri mediaUri : mediaUris) {
- if (mediaUri == null) {
- publishProgress(false);
- continue;
- }
-
- if (!addMedia(mediaUri)) {
- publishProgress(false);
- }
- }
-
- return null;
+ private void fetchMedia(List<Uri> mediaUris) {
+ for (Uri mediaUri : mediaUris) {
+ if (mediaUri == null) {
+ Toast.makeText(EditPostActivity.this,
+ getResources().getText(R.string.gallery_error), Toast.LENGTH_SHORT).show();
+ continue;
}
- @Override
- protected void onProgressUpdate(Boolean... values) {
- // use onProgressUpdate to Toast on error
+ if (!addMedia(mediaUri)) {
Toast.makeText(EditPostActivity.this, getResources().getText(R.string.gallery_error),
Toast.LENGTH_SHORT).show();
}
- }.execute(mediaUris);
+ }
}
-
private void updateMediaFileOnServer(WPImageSpan wpIS) {
Blog currentBlog = WordPress.getCurrentBlog();
if (currentBlog == null || wpIS == null)