aboutsummaryrefslogtreecommitdiff
path: root/src/core/ext/filters
diff options
context:
space:
mode:
authorYash Tibrewal <yashkt@google.com>2018-08-21 10:11:53 -0700
committerYash Tibrewal <yashkt@google.com>2018-08-21 10:11:53 -0700
commit85ff14dd16524b408bd30eb76d790be126aebb90 (patch)
treef3e3c03b29b004e9fda9aed62bf2cb42f0d88004 /src/core/ext/filters
parentb91d96bd573ac996cac26d5d6eb1ad68ff83e9e8 (diff)
downloadgrpc-grpc-85ff14dd16524b408bd30eb76d790be126aebb90.tar.gz
Modify existing error child manipulation
Diffstat (limited to 'src/core/ext/filters')
-rw-r--r--src/core/ext/filters/http/client/http_client_filter.cc9
-rw-r--r--src/core/ext/filters/http/server/http_server_filter.cc5
-rw-r--r--src/core/ext/filters/message_size/message_size_filter.cc3
3 files changed, 7 insertions, 10 deletions
diff --git a/src/core/ext/filters/http/client/http_client_filter.cc b/src/core/ext/filters/http/client/http_client_filter.cc
index 04ac4ac947..f44dc032a7 100644
--- a/src/core/ext/filters/http/client/http_client_filter.cc
+++ b/src/core/ext/filters/http/client/http_client_filter.cc
@@ -164,13 +164,8 @@ static void recv_trailing_metadata_ready(void* user_data, grpc_error* error) {
} else {
GRPC_ERROR_REF(error);
}
- if (calld->recv_initial_metadata_error != GRPC_ERROR_NONE) {
- if (error == GRPC_ERROR_NONE) {
- error = GRPC_ERROR_REF(calld->recv_initial_metadata_error);
- } else if (error != calld->recv_initial_metadata_error) {
- error = grpc_error_add_child(error, calld->recv_initial_metadata_error);
- }
- }
+ error = grpc_error_add_child(
+ error, GRPC_ERROR_REF(calld->recv_initial_metadata_error));
GRPC_CLOSURE_RUN(calld->original_recv_trailing_metadata_ready, error);
}
diff --git a/src/core/ext/filters/http/server/http_server_filter.cc b/src/core/ext/filters/http/server/http_server_filter.cc
index c66f531a89..926afeec84 100644
--- a/src/core/ext/filters/http/server/http_server_filter.cc
+++ b/src/core/ext/filters/http/server/http_server_filter.cc
@@ -321,8 +321,9 @@ static void hs_recv_message_ready(void* user_data, grpc_error* err) {
static void hs_recv_trailing_metadata_ready(void* user_data, grpc_error* err) {
grpc_call_element* elem = static_cast<grpc_call_element*>(user_data);
call_data* calld = static_cast<call_data*>(elem->call_data);
- err =
- grpc_error_maybe_add_child(err, calld->recv_initial_metadata_ready_error);
+ err = grpc_error_add_child(
+ GRPC_ERROR_REF(err),
+ GRPC_ERROR_REF(calld->recv_initial_metadata_ready_error));
GRPC_CLOSURE_RUN(calld->original_recv_trailing_metadata_ready, err);
}
diff --git a/src/core/ext/filters/message_size/message_size_filter.cc b/src/core/ext/filters/message_size/message_size_filter.cc
index b5ca1be804..a5f5f8e2ff 100644
--- a/src/core/ext/filters/message_size/message_size_filter.cc
+++ b/src/core/ext/filters/message_size/message_size_filter.cc
@@ -155,7 +155,8 @@ static void recv_message_ready(void* user_data, grpc_error* error) {
static void recv_trailing_metadata_ready(void* user_data, grpc_error* error) {
grpc_call_element* elem = static_cast<grpc_call_element*>(user_data);
call_data* calld = static_cast<call_data*>(elem->call_data);
- error = grpc_error_maybe_add_child(error, calld->error);
+ error =
+ grpc_error_add_child(GRPC_ERROR_REF(error), GRPC_ERROR_REF(calld->error));
// Invoke the next callback.
GRPC_CLOSURE_RUN(calld->next_recv_trailing_metadata_ready, error);
}