aboutsummaryrefslogtreecommitdiff
path: root/src/core/ext/filters
diff options
context:
space:
mode:
authorncteisen <ncteisen@gmail.com>2018-07-30 22:36:25 -0700
committerncteisen <ncteisen@gmail.com>2018-07-30 22:36:25 -0700
commit885c33da8bb363014e4231f8b5f3da024923f287 (patch)
tree79611aa591598716080555a371f8319e529db081 /src/core/ext/filters
parente888e93293310259b9d4bbabff2baf312cdd8973 (diff)
downloadgrpc-grpc-885c33da8bb363014e4231f8b5f3da024923f287.tar.gz
reviewer feedback
Diffstat (limited to 'src/core/ext/filters')
-rw-r--r--src/core/ext/filters/client_channel/client_channel_channelz.cc11
-rw-r--r--src/core/ext/filters/client_channel/client_channel_channelz.h7
2 files changed, 9 insertions, 9 deletions
diff --git a/src/core/ext/filters/client_channel/client_channel_channelz.cc b/src/core/ext/filters/client_channel/client_channel_channelz.cc
index 7120ec57f1..d904fc28b2 100644
--- a/src/core/ext/filters/client_channel/client_channel_channelz.cc
+++ b/src/core/ext/filters/client_channel/client_channel_channelz.cc
@@ -155,12 +155,11 @@ SubchannelNode::SubchannelNode(grpc_subchannel* subchannel,
size_t channel_tracer_max_nodes)
: BaseNode(EntityType::kSubchannel),
subchannel_(subchannel),
- target_(UniquePtr<char>(
- gpr_strdup(grpc_subchannel_get_target(subchannel_)))) {
- trace_.Init(channel_tracer_max_nodes);
-}
+ target_(
+ UniquePtr<char>(gpr_strdup(grpc_subchannel_get_target(subchannel_)))),
+ trace_(channel_tracer_max_nodes) {}
-SubchannelNode::~SubchannelNode() { trace_.Destroy(); }
+SubchannelNode::~SubchannelNode() {}
void SubchannelNode::PopulateConnectivityState(grpc_json* json) {
grpc_connectivity_state state;
@@ -199,7 +198,7 @@ grpc_json* SubchannelNode::RenderJson() {
grpc_json_create_child(nullptr, json, "target", target_.get(),
GRPC_JSON_STRING, false);
// fill in the channel trace if applicable
- grpc_json* trace_json = trace_->RenderJson();
+ grpc_json* trace_json = trace_.RenderJson();
if (trace_json != nullptr) {
trace_json->key = "trace"; // this object is named trace in channelz.proto
grpc_json_link_child(json, trace_json, nullptr);
diff --git a/src/core/ext/filters/client_channel/client_channel_channelz.h b/src/core/ext/filters/client_channel/client_channel_channelz.h
index 5e01fdf2a3..9a3fc1d6f1 100644
--- a/src/core/ext/filters/client_channel/client_channel_channelz.h
+++ b/src/core/ext/filters/client_channel/client_channel_channelz.h
@@ -23,6 +23,7 @@
#include "src/core/lib/channel/channel_args.h"
#include "src/core/lib/channel/channel_stack.h"
+#include "src/core/lib/channel/channel_trace.h"
#include "src/core/lib/channel/channelz.h"
#include "src/core/lib/gprpp/inlined_vector.h"
@@ -78,12 +79,12 @@ class SubchannelNode : public BaseNode {
// proxy methods to composed classes.
void AddTraceEvent(ChannelTrace::Severity severity, grpc_slice data) {
- trace_->AddTraceEvent(severity, data);
+ trace_.AddTraceEvent(severity, data);
}
void AddTraceEventWithReference(ChannelTrace::Severity severity,
grpc_slice data,
RefCountedPtr<BaseNode> referenced_channel) {
- trace_->AddTraceEventWithReference(severity, data, referenced_channel);
+ trace_.AddTraceEventWithReference(severity, data, referenced_channel);
}
void RecordCallStarted() { call_counter_.RecordCallStarted(); }
void RecordCallFailed() { call_counter_.RecordCallFailed(); }
@@ -93,7 +94,7 @@ class SubchannelNode : public BaseNode {
grpc_subchannel* subchannel_;
UniquePtr<char> target_;
CallCountingHelper call_counter_;
- ManualConstructor<ChannelTrace> trace_;
+ ChannelTrace trace_;
void PopulateConnectivityState(grpc_json* json);
};