diff options
author | Noah Eisen <ncteisen@gmail.com> | 2018-08-31 10:07:25 -0700 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-08-31 10:07:25 -0700 |
commit | 99680244c4d2b36934363a35089662a4651c9517 (patch) | |
tree | 66f3d51f8687e9df84e1ecf09ccfb16801866e38 /src | |
parent | 3a3b602b0b5cce0facc1d4fcab6687e7ba3ba926 (diff) | |
parent | f8a4aae1197e586d5c34f1acff450eac4d764c4b (diff) | |
download | grpc-grpc-99680244c4d2b36934363a35089662a4651c9517.tar.gz |
Merge pull request #16209 from ncteisen/bugprone-undefined-memory-manipulation
Clang Tidy: Bugprone Undefined Memory Manipulation
Diffstat (limited to 'src')
-rw-r--r-- | src/core/ext/filters/client_channel/client_channel.cc | 1 | ||||
-rw-r--r-- | src/core/lib/surface/channel.cc | 1 | ||||
-rw-r--r-- | src/core/tsi/alts_transport_security.cc | 4 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/core/ext/filters/client_channel/client_channel.cc b/src/core/ext/filters/client_channel/client_channel.cc index d2bf4f388d..8044b4e4cd 100644 --- a/src/core/ext/filters/client_channel/client_channel.cc +++ b/src/core/ext/filters/client_channel/client_channel.cc @@ -457,7 +457,6 @@ get_service_config_from_resolver_result_locked(channel_data* chand) { grpc_uri* uri = grpc_uri_parse(server_uri, true); GPR_ASSERT(uri->path[0] != '\0'); service_config_parsing_state parsing_state; - memset(&parsing_state, 0, sizeof(parsing_state)); parsing_state.server_name = uri->path[0] == '/' ? uri->path + 1 : uri->path; service_config->ParseGlobalParams(parse_retry_throttle_params, diff --git a/src/core/lib/surface/channel.cc b/src/core/lib/surface/channel.cc index 82635d3c21..e3dde51d69 100644 --- a/src/core/lib/surface/channel.cc +++ b/src/core/lib/surface/channel.cc @@ -100,7 +100,6 @@ grpc_channel* grpc_channel_create_with_builder( return channel; } - memset(channel, 0, sizeof(*channel)); channel->target = target; channel->is_client = grpc_channel_stack_type_is_client(channel_stack_type); size_t channel_tracer_max_nodes = 0; // default to off diff --git a/src/core/tsi/alts_transport_security.cc b/src/core/tsi/alts_transport_security.cc index 2fd408103b..dac23bbf7a 100644 --- a/src/core/tsi/alts_transport_security.cc +++ b/src/core/tsi/alts_transport_security.cc @@ -45,7 +45,9 @@ void grpc_tsi_alts_signal_for_cq_destroy() { } void grpc_tsi_alts_init() { - memset(&g_alts_resource, 0, sizeof(alts_shared_resource)); + g_alts_resource.channel = nullptr; + g_alts_resource.cq = nullptr; + g_alts_resource.is_cq_drained = false; gpr_mu_init(&g_alts_resource.mu); gpr_cv_init(&g_alts_resource.cv); } |