Age | Commit message (Collapse) | Author |
|
Bug: 279548314
Test: presubmit
Change-Id: Iabdd9020ebdcab7b6d347a0391246418fbd8f63d
|
|
Change was created by the release automation script. See go/grpc-release
|
|
Backport of https://github.com/grpc/grpc/pull/35589
|
|
Backport #35542 and #35616 for 1.61.x release
---------
Co-authored-by: Nick Cooke <nickcooke@google.com>
|
|
Change was created by the release automation script. See
go/grpc-release.
|
|
Change was created by the release automation script. See
go/grpc-release.
|
|
(#35659) (#35672)
Just to be future-proof, I'm amending the `void` return status of
`BuildAndRegisterGlobal` in `OpenTelemetryPluginBuilder` to
absl::Status.
|
|
We are no longer sure about this API, so re-experimentalizing it.
|
|
present in server metrics" to v1.61.x (#35646)
Backport
https://github.com/grpc/grpc/commit/16b71d91d896fb6dc46db3897c173720c9402be1
to v1.61.x.
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
|
|
Change was created by the release automation script. See
go/grpc-release.
A few Ruby fixes added to `v1.61.x` branch after the `-pre1` cut.
|
|
(#35488)" (#35613)
The `grpc_channel_args` is retained on the Ruby object and used for
recreating the channel after forking in
grpc_rb_channel_maybe_recreate_channel_after_fork(). Previously, the key
for each argument was taken from a Ruby string directly, which could be
invalidated if the Ruby string is modified or moved by the GC. Duplicate
the string for the key instead, so we own it.
Reproducer in https://github.com/grpc/grpc/issues/35489
<!--
If you know who should review your pull request, please assign it to
that person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate lang label.
-->
Closes #35488
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35488 from
Shopify:key-uaf c1813cee0184a5003f01dd1086df4f322917281b
PiperOrigin-RevId: 599304551
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
|
|
Change was created by the release automation script. See
go/grpc-release.
|
|
The release process requires all experiments to be set to either `true`
or `false`, not `debug`.
|
|
Add support for GCE resources in CSM Observability.
Additionally, fix a bug where we were not adding the remote workload's canonical service label for unknown resource types.
Also, if zone and region are both specified, zone takes precedence.
Closes #35371
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35371 from yashykt:GceSupportToCsm e3064d8c3c1c59131b8a0e8cf6e3d1b4b421d612
PiperOrigin-RevId: 597989825
|
|
Closes #35449
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35449 from ctiller:h2-settings f67e542a8b557617838e19ace37250ecff25172b
PiperOrigin-RevId: 597970333
|
|
PiperOrigin-RevId: 597953881
|
|
Part of the release process for 1.61. This PR is generated by the release process script.
Closes #35543
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35543 from stanley-cheung:bump_core_version_202401121911 b01100fd44ee4e0366fc4aa0d1e5d214322bad4e
PiperOrigin-RevId: 597935684
|
|
We were getting errors due to insane amounts of padding: enforce limits, fix b/319533934.
Closes #35537
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35537 from ctiller:fff 9f5f31ef27b46631b78edbae1d9e445115fbb25f
PiperOrigin-RevId: 597899598
|
|
I originally made this change a couple of years ago as part of addressing b/238634105, but that bug turned out to actually be fixed by #30266, so I deprioritized this change and never got back to it. However, I'm now looking at another crash related to the LRS call in b/316407706, and while I don't know what the cause of this bug is yet, this code cleanup will make the code a lot easier to understand and reason about, so it seems useful to push forward.
Closes #30273
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/30273 from markdroth:xds_client_lrs_ref_leak 70facbddeaf2f3c2798d452e1f0c1449b3c1ef59
PiperOrigin-RevId: 597897473
|
|
Replace "upb:collections" with "upb:message"
Replace "upb/collections" with "upb/message"
Replace "upb:upb" with "upb:mem" and/or "upb:base"
Replace "upb/upb.hpp" with "upb/mem/arena.hpp" and/or "upb/base/status.hpp"
Closes #35510
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35510 from ericsalo:master 112392a050489f59f91aa6db78e14408db75d98e
PiperOrigin-RevId: 597872730
|
|
As documented in [0], there are two certificate verification callbacks in the OpenSSL/BoringSSL TLS API. The one taken as a parameter to SSL_CTX_set_verify is the "verify callback". It is called multiple times during a single certificate verification is used to suppress errors and otherwise be notified about various events during verification.
Such a callback is not appropriate for accepting all certificates (you waste time processing things that will be thrown away), nor for post-verification inspection of the result (it will run multiple times). This is, however, what gRPC does with it.
Rather, gRPC should have used SSL_CTX_set_cert_verify_callback, which swaps out the verification process entirely. That is called exactly once per handshake and allows you to skip the verification, or verify and then inspect the results afterwards. Fix gRPC to heed the documentation.
In addition, this PR fixes a lifetime bug in gRPC's handling of the root certificate. RootCertExtractCallback stashes the root certificate without retaining it anywhere, but the X509_STORE_CTX will shortly be destroyed. There is no immediate guarantee the X509 object lasts as long as the SSL object. It most likely does because the object is often cached in the X509_STORE, which lives on the SSL_CTX, but this is at best, non-obvious. Instead, gRPC should have made
g_ssl_ex_verified_root_cert_index own a refcount to the X509 object by registering a free function and calling X509_up_ref when saving the value.
[0] https://commondatastorage.googleapis.com/chromium-boringssl-docs/ssl.h.html#SSL_CTX_set_verify
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #35369
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35369 from davidben:wrong-verify-callback 5ccf3cf0f90295ee1d1cb96cece311b7dcccf24a
PiperOrigin-RevId: 597872521
|
|
It looks like this ended up getting deleted in https://github.com/grpc/grpc/pull/34350 probably when merging.
Also, the `Init` method in the otel test library is getting unwieldy. I'm going to send out a follow-up PR to convert this into a builder instead.
Closes #35532
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35532 from yashykt:OTelPluginBuilderFix 372bf26338cb89b440fbb470a1fe3388d0002070
PiperOrigin-RevId: 597846622
|
|
Closes #35505
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35505 from ctiller:pbepec 54c023e589cc4a04e919a88e1d01500b0bf58133
PiperOrigin-RevId: 597845579
|
|
clarity (#35531)
Closes #35531
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35531 from markdroth:xds_client_cleanup 1b197cb90a0f8d21c9facccc583347f527898ee3
PiperOrigin-RevId: 597698967
|
|
Closes #35526
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35526 from yashykt:DeexperimentalizeCsmPluginOption 441eccb8579e8687aad13aa7b21db3d40c201a65
PiperOrigin-RevId: 597675383
|
|
We're having some issues internally, rolling this change back for now and wait for the affected users to figure out a solution.
This reverts: https://github.com/grpc/grpc/pull/35002, https://github.com/grpc/grpc/pull/35482 and https://github.com/grpc/grpc/commit/6872a7a47355128fe2c4ec17ed85f37cf9bdc848
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #35522
PiperOrigin-RevId: 597671989
|
|
Disable renegotiation for TLS
This option was added in OpenSSL 1.1.1, thus why it is inside of the include guards.
https://github.com/grpc/grpc/issues/35368
Closes #35444
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35444 from gtcooke94:disable_renegotiation 715533c90c1cd06ea96d08fe3039b5a849d22453
PiperOrigin-RevId: 597653469
|
|
(#35210)
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #35210
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35210 from yijiem:csm-service-label 6a6a7d177478a31248be8f4e551c7c991157c4be
PiperOrigin-RevId: 597641393
|
|
Closes #35509
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35509 from yashykt:DeeexperimentalizeOTelPlugin f5edf94f2cc089ec584cb85c2e0d1473a6a300f4
PiperOrigin-RevId: 597613307
|
|
Closes #35502
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35502 from ctiller:tpl3 17da58ad37ac99b511078746954bfc5912298caa
PiperOrigin-RevId: 597467779
|
|
We probably want to reconsider this types role in the system, but for now removing it would be a large job. Move it to somewhere isolated for now.
Closes #35504
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35504 from ctiller:move-it-stats 9ee755db798fa0aaaaed1855990a764b5a7078f0
PiperOrigin-RevId: 597382258
|
|
I realized that this field wasn't actually necessary, since the string is already present in the map key.
Closes #35503
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35503 from markdroth:xds_config_remove_cluster_name 94d5edc133d03cf2de8e6dd5551cee83e9a55188
PiperOrigin-RevId: 597375018
|
|
(#35500)
Closes #35500
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35500 from ctiller:tpl 3aef6fd7dbc1ce423cce9f0e1ea950dd9f3ce715
PiperOrigin-RevId: 597357575
|
|
Implements the aggregate cluster changes described in gRFC A75 (https://github.com/grpc/proposal/pull/405).
Closes #35313
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35313 from markdroth:xds_aggregate_cluster_fix 85cfd70c597a950abfcd171368776726712924bf
PiperOrigin-RevId: 597326624
|
|
Closes #35497
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35497 from ctiller:chippity 66fce33280f1c41ca5cf26bc6956533e64ffa9ac
PiperOrigin-RevId: 597315580
|
|
(Required recursively splitting some other targets too)
Gets us closer to eliminating `grpc_base`, and (more importantly) sets up some pieces of transport to be split out so I can rebuild them in coming months.
Closes #35496
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35496 from ctiller:chipchip 5319fb925dc723ab0ed15021abc8a87a2b157c4d
PiperOrigin-RevId: 597304996
|
|
last-used time rather than EDS health state (#35397)
Part of the work needed for in-progress gRFC A75 (https://github.com/grpc/proposal/pull/405).
Closes #35397
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35397 from markdroth:xds_ssa_subchannel_management_revamp 8902deafadb1a1116b7ad432b25870e4de522367
PiperOrigin-RevId: 597288930
|
|
(#35501)
Closes #35501
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35501 from ctiller:tpl2 9834ee4ae2e9b8d4dc01f57796a75da367b1c6b0
PiperOrigin-RevId: 597277587
|
|
Part of the work needed for in-progress gRFC A75 (https://github.com/grpc/proposal/pull/405).
Closes #35395
PiperOrigin-RevId: 597064473
|
|
Closes #35472
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35472 from ctiller:gsaf 630b5514a7ec6f291aa2406af5632c53df15b17d
PiperOrigin-RevId: 597045999
|
|
Closes #35471
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35471 from ctiller:slrf b9e685c1c187e2acbfe9ae14dea7223af3ca5359
PiperOrigin-RevId: 597040097
|
|
Closes #35469
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35469 from ctiller:caf 1dffe24fcbafa6854cdccdc91d29dae5f0a509a0
PiperOrigin-RevId: 597040037
|
|
Closes #35491
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35491 from drfloob:cleanup-posix-ee-native-resolver 1c97ff5216a8e5d6873a70ec9f1cf0c43b6f4e27
PiperOrigin-RevId: 597035026
|
|
Closes #35470
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35470 from ctiller:scsf 789b365616d67a95659a6e60b6364855311e0085
PiperOrigin-RevId: 597006442
|
|
What was there trips some tooling and will cause some repo maintenance issues going forward
PiperOrigin-RevId: 596992313
|
|
Closes #35458
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35458 from drfloob:windows-native-ee-resolver 364b7103424f0b15d44d4385fd2ea0d323ab6b47
PiperOrigin-RevId: 596981099
|
|
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #35482
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35482 from XuanWang-Amos:fix_registered_method 49321c83b8da361377511ae53127c369518eb4f9
PiperOrigin-RevId: 596967469
|
|
Closes #35434
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35434 from yashykt:OTelPluginOption 1db870bed4ba55cad5515c3586200fa17f5ce226
PiperOrigin-RevId: 596966190
|
|
Fixed
```
/var/local/git/grpc/src/core/ext/transport/chaotic_good/frame_header.cc:69:15: error: no member named 'StrCat' in namespace 'absl'
absl::StrCat("Invalid header length: ", header.header_length));
~~~~~~^
```
Closes #35478
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35478 from veblush:fix-header d6c94b63e7aa0711a63f1d43526c5cc18d62fdb4
PiperOrigin-RevId: 596966091
|
|
//test/core/end2end:cancel_after_invoke_test
Based on discussions with drfloob@
PiperOrigin-RevId: 596958525
|