diff options
| author | cpovirk <cpovirk@google.com> | 2021-09-27 08:02:09 -0700 |
|---|---|---|
| committer | Google Java Core Libraries <java-core-libraries-team+copybara@google.com> | 2021-09-27 08:04:14 -0700 |
| commit | 0ad6d6d9e1a2eab6f05c7609868db494b5e3d212 (patch) | |
| tree | 038d7e295f69f0b6b30ca2d18a4ea1e8dd52c8be /guava-gwt/src/com/google/common | |
| parent | 7396bab41807702f2ce94517d0f58b8e52f603f8 (diff) | |
| download | guava-0ad6d6d9e1a2eab6f05c7609868db494b5e3d212.tar.gz | |
Strip `@Nullable` annotations from GWT sources.
If we use `@Nullable`, the GWT compiler requires access to _the source code for `@Nullable`_ -- at least when `@Nullable` appears in _certain_ locations (type parameter bounds, type arguments, maybe others?). When we began using those annotations in those locations, I inserted a workaround into our own build to supply access to the source code for `@Nullable`. (That required not only depending on that source code but also providing a hacky, local `.gwt.xml` file. That means that our _users_ would _also_ need to do both of those things, which we really shouldn't require.) I had intended to improve upon this before the 31.0 release, but I didn't make a note about it in the right place :(
The fix of simply removing the annotations works fine, since only the GWT compiler ever sees these sources, and it doesn't care about type annotations.
(OK, our j2cl users could eventually care about the lack of annotations. But we haven't yet we applied `@NullMarked` to our classes externally, so the difference to them is between "lack of nullness information" and "possibly null" -- which means essentially nothing.)
(One way to look at this CL is as an edited, very partial rollback of CL 364918297.)
RELNOTES=Fixed [GWT compilation failure](https://groups.google.com/g/guava-discuss/c/I32pgyyj1N8/m/pXcyky2hAgAJ) introduced in release 31.0.
PiperOrigin-RevId: 399190627
Diffstat (limited to 'guava-gwt/src/com/google/common')
| -rw-r--r-- | guava-gwt/src/com/google/common/ForceGuavaCompilation.gwt.xml | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/guava-gwt/src/com/google/common/ForceGuavaCompilation.gwt.xml b/guava-gwt/src/com/google/common/ForceGuavaCompilation.gwt.xml index 86373cf5e..93f5404da 100644 --- a/guava-gwt/src/com/google/common/ForceGuavaCompilation.gwt.xml +++ b/guava-gwt/src/com/google/common/ForceGuavaCompilation.gwt.xml @@ -13,7 +13,6 @@ <inherits name="com.google.common.xml.Xml" /> <inherits name="com.google.thirdparty.publicsuffix.PublicSuffixPatterns" /> <inherits name="com.google.thirdparty.publicsuffix.PublicSuffixType" /> - <inherits name="org.checkerframework.checker.nullness.qual.Qual" /> <!-- com.google.common.testing.Testing is located in GuavaTests under guava-gwt/test --> |