diff options
author | Paul Duffin <paulduffin@google.com> | 2015-01-06 16:25:10 +0000 |
---|---|---|
committer | Paul Duffin <paulduffin@google.com> | 2015-01-09 11:56:52 +0000 |
commit | 12f8ed0821380c1a961ced21c81d260047a7fd10 (patch) | |
tree | 9345bba5c6eb0f48a2cfc0fdc0f3f8891e8d42dd /guava-tests | |
parent | 75b00c56951b33e251c6c64655109d188fb10349 (diff) | |
download | guava-12f8ed0821380c1a961ced21c81d260047a7fd10.tar.gz |
Replaced usages of Unsafe in UnsignedBytes with standard Java
Fixes the last build error on Android. AOSP does not require any
additional changes in order for it to compile against this.
Change-Id: Ifda74a29e0435de702c15720915e79e76b510c9d
Diffstat (limited to 'guava-tests')
-rw-r--r-- | guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java | 19 | ||||
-rw-r--r-- | guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java | 6 |
2 files changed, 3 insertions, 22 deletions
diff --git a/guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java b/guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java index eb874f62b..a576346a9 100644 --- a/guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java +++ b/guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java @@ -36,7 +36,6 @@ public class UnsignedBytesBenchmark extends SimpleBenchmark { private byte[] ba3; private byte[] ba4; private Comparator<byte[]> javaImpl; - private Comparator<byte[]> unsafeImpl; // 4, 8, 64, 1K, 1M, 1M (unaligned), 64M, 64M (unaligned) //@Param({"4", "8", "64", "1024", "1048576", "1048577", "6710884", "6710883"}) @@ -56,8 +55,6 @@ public class UnsignedBytesBenchmark extends SimpleBenchmark { ba4[ba1.length - 1] = (byte) 42; javaImpl = UnsignedBytes.lexicographicalComparatorJavaImpl(); - unsafeImpl = - UnsignedBytes.LexicographicalComparatorHolder.UnsafeComparator.INSTANCE; } public void timeLongEqualJava(int reps) { @@ -68,14 +65,6 @@ public class UnsignedBytesBenchmark extends SimpleBenchmark { } } - public void timeLongEqualUnsafe(int reps) { - for (int i = 0; i < reps; ++i) { - if (unsafeImpl.compare(ba1, ba2) != 0) { - throw new Error(); // deoptimization - } - } - } - public void timeDiffLastJava(int reps) { for (int i = 0; i < reps; ++i) { if (javaImpl.compare(ba3, ba4) == 0) { @@ -84,14 +73,6 @@ public class UnsignedBytesBenchmark extends SimpleBenchmark { } } - public void timeDiffLastUnsafe(int reps) { - for (int i = 0; i < reps; ++i) { - if (unsafeImpl.compare(ba3, ba4) == 0) { - throw new Error(); // deoptimization - } - } - } - public static void main(String[] args) { /* try { diff --git a/guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java b/guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java index 916db9e2d..bdb36f4c7 100644 --- a/guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java +++ b/guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java @@ -226,9 +226,9 @@ public class UnsignedBytesTest extends TestCase { public void testLexicographicalComparatorDefaultChoice() { Comparator<byte[]> defaultComparator = UnsignedBytes.lexicographicalComparator(); - Comparator<byte[]> unsafeComparator = - UnsignedBytes.LexicographicalComparatorHolder.UnsafeComparator.INSTANCE; - assertSame(defaultComparator, unsafeComparator); + Comparator<byte[]> pureJavaComparator = + UnsignedBytes.LexicographicalComparatorHolder.PureJavaComparator.INSTANCE; + assertSame(defaultComparator, pureJavaComparator); } public void testLexicographicalComparator() { |