aboutsummaryrefslogtreecommitdiff
path: root/guava-tests
diff options
context:
space:
mode:
authorPaul Duffin <paulduffin@google.com>2015-01-23 14:44:38 +0000
committerPaul Duffin <paulduffin@google.com>2015-08-05 14:21:35 +0100
commit6bde63a9a675546c727b939819993812ef24b30e (patch)
treeb2aa54bc121749f8dff438ee2a6c4304cac9a3ec /guava-tests
parent9dd148481d0f4705aa7f560a24c9d8a72a493a9a (diff)
downloadguava-6bde63a9a675546c727b939819993812ef24b30e.tar.gz
Replaced usages of Unsafe in UnsignedBytes with standard Java
This fixes the last Android compilation failure so it will now compile on Android. AOSP does not require any changes in order for it to compile against this. Change-Id: I2a546ce1452fbc449de41f232f4ffdcf8a329b13
Diffstat (limited to 'guava-tests')
-rw-r--r--guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java19
-rw-r--r--guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java6
2 files changed, 3 insertions, 22 deletions
diff --git a/guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java b/guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java
index 19b6802b8..fd03d991e 100644
--- a/guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java
+++ b/guava-tests/benchmark/com/google/common/primitives/UnsignedBytesBenchmark.java
@@ -36,7 +36,6 @@ public class UnsignedBytesBenchmark {
private byte[] ba3;
private byte[] ba4;
private Comparator<byte[]> javaImpl;
- private Comparator<byte[]> unsafeImpl;
// 4, 8, 64, 1K, 1M, 1M (unaligned), 64M, 64M (unaligned)
//@Param({"4", "8", "64", "1024", "1048576", "1048577", "6710884", "6710883"})
@@ -56,8 +55,6 @@ public class UnsignedBytesBenchmark {
ba4[ba1.length - 1] = (byte) 42;
javaImpl = UnsignedBytes.lexicographicalComparatorJavaImpl();
- unsafeImpl =
- UnsignedBytes.LexicographicalComparatorHolder.UnsafeComparator.INSTANCE;
}
@Benchmark void longEqualJava(int reps) {
@@ -68,14 +65,6 @@ public class UnsignedBytesBenchmark {
}
}
- @Benchmark void longEqualUnsafe(int reps) {
- for (int i = 0; i < reps; ++i) {
- if (unsafeImpl.compare(ba1, ba2) != 0) {
- throw new Error(); // deoptimization
- }
- }
- }
-
@Benchmark void diffLastJava(int reps) {
for (int i = 0; i < reps; ++i) {
if (javaImpl.compare(ba3, ba4) == 0) {
@@ -84,14 +73,6 @@ public class UnsignedBytesBenchmark {
}
}
- @Benchmark void diffLastUnsafe(int reps) {
- for (int i = 0; i < reps; ++i) {
- if (unsafeImpl.compare(ba3, ba4) == 0) {
- throw new Error(); // deoptimization
- }
- }
- }
-
/*
try {
UnsignedBytesBenchmark bench = new UnsignedBytesBenchmark();
diff --git a/guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java b/guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java
index 575eb7e73..c74e8a215 100644
--- a/guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java
+++ b/guava-tests/test/com/google/common/primitives/UnsignedBytesTest.java
@@ -226,9 +226,9 @@ public class UnsignedBytesTest extends TestCase {
public void testLexicographicalComparatorDefaultChoice() {
Comparator<byte[]> defaultComparator =
UnsignedBytes.lexicographicalComparator();
- Comparator<byte[]> unsafeComparator =
- UnsignedBytes.LexicographicalComparatorHolder.UnsafeComparator.INSTANCE;
- assertSame(defaultComparator, unsafeComparator);
+ Comparator<byte[]> pureJavaComparator =
+ UnsignedBytes.LexicographicalComparatorHolder.PureJavaComparator.INSTANCE;
+ assertSame(defaultComparator, pureJavaComparator);
}
public void testLexicographicalComparator() {