diff options
| author | cpovirk <cpovirk@google.com> | 2019-10-23 12:26:01 -0700 |
|---|---|---|
| committer | Colin Decker <cgdecker@gmail.com> | 2019-10-24 14:57:48 -0400 |
| commit | 5ff90caf1562f89aaed56252f05b4a5bf8b57197 (patch) | |
| tree | 6d0a7078f04ec2de190deeac67033cc8abd06094 /pom.xml | |
| parent | 79983a915f6c37bda832b37ab6f9e7ac09c57388 (diff) | |
| download | guava-5ff90caf1562f89aaed56252f05b4a5bf8b57197.tar.gz | |
Prepare to move gwt-user to test scope after we remove GWT-RPC support.
When we do that, we'll no longer be able to compile ForceGuavaCompilationEntryPoint as part of the normal javac compile or build its Javadoc (because of the "missing" dependency).
(ForceGuavaCompilationEntryPoint lives under the main (i.e., non-test) sources because we want to ensure that our prod code compiles without any dependencies added by our tests.)
So exclude it from the javac compile, and turn off building Javadoc altogether. (Javadoc already isn't useful for guava-gwt, since it covers only ForceGuavaCompilationEntryPoint and the internal serialization classes. Once the serialization classes go away and ForceGuavaCompilationEntryPoint is hidden, we would get an error from Javadoc because it wouldn't find *any* sources.)
Removing ForceGuavaCompilationEntryPoint from the javac compile is fine: I've verified that the GWT compiler still runs and identifies any GWT compilation errors. And I've diffed the resulting GWT jars.
While here, I moved some GWT-specific configuration into the guava-gwt pom.xml.
Relevant to https://github.com/google/truth/issues/637
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=276327335
Diffstat (limited to 'pom.xml')
| -rw-r--r-- | pom.xml | 10 |
1 files changed, 0 insertions, 10 deletions
@@ -123,11 +123,6 @@ <plugin> <artifactId>maven-jar-plugin</artifactId> <version>3.0.2</version> - <configuration> - <excludes> - <exclude>**/ForceGuavaCompilation*</exclude> - </excludes> - </configuration> </plugin> <plugin> <artifactId>maven-source-plugin</artifactId> @@ -139,11 +134,6 @@ <goals><goal>jar</goal></goals> </execution> </executions> - <configuration> - <excludes> - <exclude>**/ForceGuavaCompilation*</exclude> - </excludes> - </configuration> </plugin> <plugin> <groupId>org.codehaus.mojo</groupId> |