aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-20Use BUILD_HOST_STATIC_DALVIK_JAVA_LIBRARY for guice-hostdex am: 0afca749f4 ↵android-wear-8.1.0_r1android-vts-8.1_r9android-vts-8.1_r8android-vts-8.1_r7android-vts-8.1_r6android-vts-8.1_r5android-vts-8.1_r4android-vts-8.1_r3android-vts-8.1_r14android-vts-8.1_r13android-vts-8.1_r12android-vts-8.1_r11android-vts-8.1_r10android-vts-8.0_r9android-vts-8.0_r8android-vts-8.0_r7android-vts-8.0_r6android-vts-8.0_r2android-vts-8.0_r13android-vts-8.0_r12android-vts-8.0_r11android-vts-8.0_r10android-vts-8.0_r1android-security-8.1.0_r93android-security-8.1.0_r92android-security-8.1.0_r91android-security-8.1.0_r90android-security-8.1.0_r89android-security-8.1.0_r88android-security-8.1.0_r87android-security-8.1.0_r86android-security-8.1.0_r85android-security-8.1.0_r84android-security-8.1.0_r83android-security-8.1.0_r82android-security-8.0.0_r54android-security-8.0.0_r53android-security-8.0.0_r52android-o-mr1-preview-2android-o-mr1-preview-1android-o-mr1-iot-preview-6android-cts-8.1_r9android-cts-8.1_r8android-cts-8.1_r7android-cts-8.1_r6android-cts-8.1_r5android-cts-8.1_r4android-cts-8.1_r3android-cts-8.1_r25android-cts-8.1_r24android-cts-8.1_r23android-cts-8.1_r22android-cts-8.1_r21android-cts-8.1_r20android-cts-8.1_r2android-cts-8.1_r19android-cts-8.1_r18android-cts-8.1_r17android-cts-8.1_r16android-cts-8.1_r15android-cts-8.1_r14android-cts-8.1_r13android-cts-8.1_r12android-cts-8.1_r11android-cts-8.1_r10android-cts-8.1_r1android-cts-8.0_r9android-cts-8.0_r8android-cts-8.0_r7android-cts-8.0_r6android-cts-8.0_r5android-cts-8.0_r4android-cts-8.0_r3android-cts-8.0_r26android-cts-8.0_r25android-cts-8.0_r24android-cts-8.0_r23android-cts-8.0_r22android-cts-8.0_r21android-cts-8.0_r20android-cts-8.0_r2android-cts-8.0_r19android-cts-8.0_r18android-cts-8.0_r17android-cts-8.0_r16android-cts-8.0_r15android-cts-8.0_r14android-cts-8.0_r13android-cts-8.0_r12android-cts-8.0_r11android-cts-8.0_r10android-cts-8.0_r1android-8.1.0_r9android-8.1.0_r81android-8.1.0_r80android-8.1.0_r8android-8.1.0_r79android-8.1.0_r78android-8.1.0_r77android-8.1.0_r76android-8.1.0_r75android-8.1.0_r74android-8.1.0_r73android-8.1.0_r72android-8.1.0_r71android-8.1.0_r70android-8.1.0_r7android-8.1.0_r69android-8.1.0_r68android-8.1.0_r67android-8.1.0_r66android-8.1.0_r65android-8.1.0_r64android-8.1.0_r63android-8.1.0_r62android-8.1.0_r61android-8.1.0_r60android-8.1.0_r6android-8.1.0_r53android-8.1.0_r52android-8.1.0_r51android-8.1.0_r50android-8.1.0_r5android-8.1.0_r48android-8.1.0_r47android-8.1.0_r46android-8.1.0_r45android-8.1.0_r43android-8.1.0_r42android-8.1.0_r41android-8.1.0_r40android-8.1.0_r4android-8.1.0_r39android-8.1.0_r38android-8.1.0_r37android-8.1.0_r36android-8.1.0_r35android-8.1.0_r33android-8.1.0_r32android-8.1.0_r31android-8.1.0_r30android-8.1.0_r3android-8.1.0_r29android-8.1.0_r28android-8.1.0_r27android-8.1.0_r26android-8.1.0_r25android-8.1.0_r23android-8.1.0_r22android-8.1.0_r21android-8.1.0_r20android-8.1.0_r2android-8.1.0_r19android-8.1.0_r18android-8.1.0_r17android-8.1.0_r16android-8.1.0_r15android-8.1.0_r14android-8.1.0_r13android-8.1.0_r12android-8.1.0_r11android-8.1.0_r10android-8.1.0_r1android-8.0.0_r9android-8.0.0_r7android-8.0.0_r51android-8.0.0_r50android-8.0.0_r49android-8.0.0_r48android-8.0.0_r47android-8.0.0_r46android-8.0.0_r45android-8.0.0_r44android-8.0.0_r43android-8.0.0_r42android-8.0.0_r41android-8.0.0_r40android-8.0.0_r4android-8.0.0_r39android-8.0.0_r38android-8.0.0_r37android-8.0.0_r36android-8.0.0_r35android-8.0.0_r34android-8.0.0_r33android-8.0.0_r32android-8.0.0_r31android-8.0.0_r30android-8.0.0_r3android-8.0.0_r29android-8.0.0_r28android-8.0.0_r27android-8.0.0_r26android-8.0.0_r25android-8.0.0_r24android-8.0.0_r23android-8.0.0_r22android-8.0.0_r21android-8.0.0_r2android-8.0.0_r17android-8.0.0_r16android-8.0.0_r15android-8.0.0_r13android-8.0.0_r12android-8.0.0_r11android-8.0.0_r10android-8.0.0_r1security-oc-releasesecurity-oc-mr1-releaseoreo-vts-releaseoreo-security-releaseoreo-releaseoreo-r6-releaseoreo-r5-releaseoreo-r4-releaseoreo-r3-releaseoreo-r2-releaseoreo-mr1-wear-releaseoreo-mr1-vts-releaseoreo-mr1-security-releaseoreo-mr1-s1-releaseoreo-mr1-releaseoreo-mr1-devoreo-mr1-cuttlefish-testingoreo-mr1-cts-releaseoreo-m8-releaseoreo-m7-releaseoreo-m6-s4-releaseoreo-m6-s3-releaseoreo-m6-s2-releaseoreo-m5-releaseoreo-m4-s9-releaseoreo-m4-s8-releaseoreo-m4-s7-releaseoreo-m4-s6-releaseoreo-m4-s5-releaseoreo-m4-s4-releaseoreo-m4-s3-releaseoreo-m4-s2-releaseoreo-m4-s12-releaseoreo-m4-s11-releaseoreo-m4-s10-releaseoreo-m4-s1-releaseoreo-m3-releaseoreo-m2-s5-releaseoreo-m2-s4-releaseoreo-m2-s3-releaseoreo-m2-s2-releaseoreo-m2-s1-releaseoreo-m2-releaseoreo-dr3-releaseoreo-dr2-releaseoreo-dr1-releaseoreo-dr1-devoreo-devoreo-cts-releaseo-mr1-iot-preview-6Colin Cross
am: 080ef5fd67 am: 77f6e08c51 am: 411312e790 Change-Id: Ica6ea71648acaaded0d0fb89683a6ce63e3a8f52
2017-01-20Use BUILD_HOST_STATIC_DALVIK_JAVA_LIBRARY for guice-hostdex am: 0afca749f4 ↵android-wear-o-preview-4android-wear-o-preview-3android-o-preview-4android-o-preview-3android-o-preview-2android-o-iot-preview-5android-n-iot-preview-4o-iot-preview-5n-iot-preview-4Colin Cross
am: 080ef5fd67 am: 77f6e08c51 Change-Id: Id9de2d283bacb0982614efd29cd733b8bbf91271
2017-01-20Use BUILD_HOST_STATIC_DALVIK_JAVA_LIBRARY for guice-hostdex am: 0afca749f4Colin Cross
am: 080ef5fd67 Change-Id: I0c23243c1ec95b001fde81b09527fd9808a51b3c
2017-01-20Use BUILD_HOST_STATIC_DALVIK_JAVA_LIBRARY for guice-hostdexColin Cross
am: 0afca749f4 Change-Id: I559c4b161100efac08a60c6677147ebe578ce0d2
2017-01-19Use BUILD_HOST_STATIC_DALVIK_JAVA_LIBRARY for guice-hostdexandroid-o-preview-1android-n-mr2-preview-2o-previewColin Cross
BUILD_HOST_STATIC_DALVIK_JAVA_LIBRARY must be used for libraries that will be linked with LOCAL_STATIC_JAVA_LIBRARIES. Test: m -j java Change-Id: Ibf03dd9255882d472b6172602e74e8d9de981b1c
2016-11-29Use junit-host instead of junit am: 788548b2d6 am: b6e6f3ada8 am: dac8e85864Paul Duffin
am: fd4da2840b Change-Id: I9dca646f0943511e5b280fbf4c5ca60f3534b277
2016-11-29Use junit-host instead of junit am: 788548b2d6 am: b6e6f3ada8Paul Duffin
am: dac8e85864 Change-Id: Icb34fae18a0864848384fbb7266d01ad49984573
2016-11-29Use junit-host instead of junit am: 788548b2d6Paul Duffin
am: b6e6f3ada8 Change-Id: I9e3148e8b44d2743b8b627b97900b3be78914a31
2016-11-29Use junit-host instead of junitandroid-n-mr2-preview-1Paul Duffin
am: 788548b2d6 Change-Id: Id47886afc34e47ece769cc8707add1f731363433
2016-11-29Use junit-host instead of junitPaul Duffin
Bug: 30188076 Test: make checkbuild Change-Id: Ic8d56444a37c7425f72c4c55b3b936583b46ee80
2016-04-28build: Add device-side support for the AOSP. am: 3c28180 am: 61c5de6 am: dd02caeIgor Murashkin
am: 6455114 * commit '6455114c53029b9e0511dfbb6280c10c461ccc6c': build: Add device-side support for the AOSP. Change-Id: Id58eea3d9f10df481f82776478bfce74c5c15add
2016-04-28build: Add device-side support for the AOSP. am: 3c28180 am: 61c5de6Igor Murashkin
am: dd02cae * commit 'dd02cae677404f96e0359e51d0a77ac91174a057': build: Add device-side support for the AOSP. Change-Id: If8b54fff67d32d308246081db6dfb74664031ef1
2016-04-28build: Add device-side support for the AOSP. am: 3c28180android-n-mr1-preview-2android-n-mr1-preview-1Igor Murashkin
am: 61c5de6 * commit '61c5de62c488a0140ab6dd8a9ba7ec3ff9dcf95b': build: Add device-side support for the AOSP. Change-Id: I1b27bcda47b53f63c6e2968b976d96074dc171b4
2016-04-28build: Add device-side support for the AOSP.Igor Murashkin
am: 3c28180 * commit '3c281807bfef61b077cb2e010890c11be31feb6b': build: Add device-side support for the AOSP. Change-Id: Ie6f6842dd4d24d0bd8f312fc7d5f5ab12a4e3a3f
2016-04-26build: Add device-side support for the AOSP.android-wear-n-preview-3android-wear-n-preview-2android-wear-n-preview-1android-wear-7.1.1_r1android-n-preview-5android-n-preview-4android-n-preview-3android-n-iot-preview-2nougat-mr1-wear-releasen-iot-preview-2Igor Murashkin
Bug: 27521545 Change-Id: Ic254894f7dc838e0529b6cd648838b51fea84d0d (cherry picked from commit 83b7ddb6a7b4db66d57c35ceb51fdbbb8a922aff)
2016-04-04build: Add device-side support for the AOSP. am: 83b7ddbIgor Murashkin
am: af3b325 * commit 'af3b325e3a3a431d50aac8548e7e03868724420d': build: Add device-side support for the AOSP. Change-Id: I03607cb6da62c9566828dff6a5456fa62eb00daa
2016-04-04build: Add device-side support for the AOSP.Igor Murashkin
am: 83b7ddb * commit '83b7ddb6a7b4db66d57c35ceb51fdbbb8a922aff': build: Add device-side support for the AOSP. Change-Id: If825a74820cd3b5e938cb4effe8dfff5e260b0f0
2016-04-01build: Add device-side support for the AOSP.android-cts_7.1_r1android-cts-7.1_r9android-cts-7.1_r8android-cts-7.1_r7android-cts-7.1_r6android-cts-7.1_r5android-cts-7.1_r4android-cts-7.1_r3android-cts-7.1_r29android-cts-7.1_r28android-cts-7.1_r27android-cts-7.1_r26android-cts-7.1_r25android-cts-7.1_r24android-cts-7.1_r23android-cts-7.1_r22android-cts-7.1_r21android-cts-7.1_r20android-cts-7.1_r2android-cts-7.1_r19android-cts-7.1_r18android-cts-7.1_r17android-cts-7.1_r16android-cts-7.1_r15android-cts-7.1_r14android-cts-7.1_r13android-cts-7.1_r12android-cts-7.1_r11android-cts-7.1_r10android-cts-7.1_r1android-cts-7.0_r9android-cts-7.0_r8android-cts-7.0_r7android-cts-7.0_r6android-cts-7.0_r5android-cts-7.0_r4android-cts-7.0_r33android-cts-7.0_r32android-cts-7.0_r31android-cts-7.0_r30android-cts-7.0_r3android-cts-7.0_r29android-cts-7.0_r28android-cts-7.0_r27android-cts-7.0_r26android-cts-7.0_r25android-cts-7.0_r24android-cts-7.0_r23android-cts-7.0_r22android-cts-7.0_r21android-cts-7.0_r20android-cts-7.0_r2android-cts-7.0_r19android-cts-7.0_r18android-cts-7.0_r17android-cts-7.0_r16android-cts-7.0_r15android-cts-7.0_r14android-cts-7.0_r13android-cts-7.0_r12android-cts-7.0_r11android-cts-7.0_r10android-cts-7.0_r1android-7.1.2_r9android-7.1.2_r8android-7.1.2_r6android-7.1.2_r5android-7.1.2_r4android-7.1.2_r39android-7.1.2_r38android-7.1.2_r37android-7.1.2_r36android-7.1.2_r33android-7.1.2_r32android-7.1.2_r30android-7.1.2_r3android-7.1.2_r29android-7.1.2_r28android-7.1.2_r27android-7.1.2_r25android-7.1.2_r24android-7.1.2_r23android-7.1.2_r2android-7.1.2_r19android-7.1.2_r18android-7.1.2_r17android-7.1.2_r16android-7.1.2_r15android-7.1.2_r14android-7.1.2_r13android-7.1.2_r12android-7.1.2_r11android-7.1.2_r10android-7.1.2_r1android-7.1.1_r9android-7.1.1_r8android-7.1.1_r7android-7.1.1_r61android-7.1.1_r60android-7.1.1_r6android-7.1.1_r59android-7.1.1_r58android-7.1.1_r57android-7.1.1_r56android-7.1.1_r55android-7.1.1_r54android-7.1.1_r53android-7.1.1_r52android-7.1.1_r51android-7.1.1_r50android-7.1.1_r49android-7.1.1_r48android-7.1.1_r47android-7.1.1_r46android-7.1.1_r45android-7.1.1_r44android-7.1.1_r43android-7.1.1_r42android-7.1.1_r41android-7.1.1_r40android-7.1.1_r4android-7.1.1_r39android-7.1.1_r38android-7.1.1_r35android-7.1.1_r33android-7.1.1_r32android-7.1.1_r31android-7.1.1_r3android-7.1.1_r28android-7.1.1_r27android-7.1.1_r26android-7.1.1_r25android-7.1.1_r24android-7.1.1_r23android-7.1.1_r22android-7.1.1_r21android-7.1.1_r20android-7.1.1_r2android-7.1.1_r17android-7.1.1_r16android-7.1.1_r15android-7.1.1_r14android-7.1.1_r13android-7.1.1_r12android-7.1.1_r11android-7.1.1_r10android-7.1.1_r1android-7.1.0_r7android-7.1.0_r6android-7.1.0_r5android-7.1.0_r4android-7.1.0_r3android-7.1.0_r2android-7.1.0_r1android-7.0.0_r9android-7.0.0_r8android-7.0.0_r7android-7.0.0_r6android-7.0.0_r5android-7.0.0_r4android-7.0.0_r36android-7.0.0_r35android-7.0.0_r34android-7.0.0_r33android-7.0.0_r32android-7.0.0_r31android-7.0.0_r30android-7.0.0_r3android-7.0.0_r29android-7.0.0_r28android-7.0.0_r27android-7.0.0_r24android-7.0.0_r21android-7.0.0_r19android-7.0.0_r17android-7.0.0_r15android-7.0.0_r14android-7.0.0_r13android-7.0.0_r12android-7.0.0_r11android-7.0.0_r10android-7.0.0_r1nougat-releasenougat-mr2.3-releasenougat-mr2.2-releasenougat-mr2.1-releasenougat-mr2-security-releasenougat-mr2-releasenougat-mr2-pixel-releasenougat-mr2-devnougat-mr1.8-releasenougat-mr1.7-releasenougat-mr1.6-releasenougat-mr1.5-releasenougat-mr1.4-releasenougat-mr1.3-releasenougat-mr1.2-releasenougat-mr1.1-releasenougat-mr1-volantis-releasenougat-mr1-security-releasenougat-mr1-releasenougat-mr1-flounder-releasenougat-mr1-devnougat-mr1-cts-releasenougat-mr0.5-releasenougat-dr1-releasenougat-devnougat-cts-releasenougat-bugfix-releaseIgor Murashkin
Bug: 27521545 Change-Id: Ic254894f7dc838e0529b6cd648838b51fea84d0d
2016-03-24Merge remote-tracking branch 'goog/master' into nyc-devIgor Murashkin
Bug: 27552463 Change-Id: If058b2de991c4813d49a5d844b8610405fb3bc5f
2016-03-22build: Add support for building guice within the AOSP (host only).android-n-preview-2Igor Murashkin
Builds the no_aop variant only since Android doesn't support bytecode weaving. Bug: 27552463 Change-Id: I71b4f3b26b9307b36444cecc75d67de03be9cb23
2016-03-16android: Add project metadataIgor Murashkin
Bug: 27552463 Change-Id: I71cff480c9b5fb813f3209cd6186e96b124f94ca
2016-03-16Merge branch 'upstream-master'Igor Murashkin
Initial downstream of guice code (tag 4.0) from https://github.com/google/guice/ Bug: 27552463 Change-Id: Ia72763ed396d2f3ac3bc2bc66fb3e383818e1c82
2016-03-09Initial empty repositoryBill Yi
2015-04-28Update version to 4.0upstream-masterColin Decker
2015-04-28Merge pull request #920 from google/merge-internal-changesColin Decker
Merge internal changes.
2015-04-28Add more missing @since 4.0 and remove references to *-3.0.jar in ↵cgdecker
extensions' package-info.java files. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=92005346
2015-04-23Merge pull request #919 from ↵Sam Berlin
google/moe_writing_branch_from_156c8cc762fab971efb727c7ab107fa243be2fc9 Merge internal changes
2015-04-23Remove the snapshot repository that was configured to support ↵cgruber
dagger-adapter. Dagger 2 is now released, so this is not necessary. Left the TODO in there, because the pom inheritance hierarchy needs to be brought up to something more current (e.g. sonatype's OSS parent pom, etc.) ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91730888
2015-04-23Also fix usages of a couple of @Beta APIs.cgdecker
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91720693
2015-04-22Merge pull request #917 from mcculls/align-dagger-adapter-nameSam Berlin
Align dagger-adapter name and add it to the Bill-Of-Materials pom.xml
2015-04-22Align dagger-adapter name and add it to the Bill-Of-Materials pom.xmlStuart McCulloch
2015-04-22Merge pull request #916 from benmccann/missing-sinceSam Berlin
Add missing @since tags for classes
2015-04-21Add missing @since tags for 4.0Ben McCann
2015-04-21Merge pull request #915 from ↵Sam Berlin
google/moe_writing_branch_from_156c8cc762fab971efb727c7ab107fa243be2fc9 Merge internal changes
2015-04-21Update dagger-adapter to depend on dagger-2.0 (and swap in the up-to-date ↵cgruber
api jar for the ant build) ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91679331
2015-04-21Implement more granular locks for a Singleton scope in Guice.timofeyb
Now when you can create two independent singletons using the same injector in different threads. This make it easy to create scopes creating singletons using thread pools with all the concurrency being done by Guice. As a nice side effect Singleton scope is no longer treated specially in Guice codebase. The obvious problem to solve is potential deadlocks: A requires B, B requires C, C requires A where all are singletons and all are created simultaneously. It's impossible to detect this deadlock using information within one thread, so we have to have a shared storage. An idea is to have a map of creators' locks and a map of which threads are waiting for other singletons to be created. Using this information circular dependencies are trivially discovered within O(N) where N is a number of concurrent threads. Important to not that no other deadlock scenarios within Guice code is introduced as Guice does not expose any other scopes that can span several threads. Now it would be possible for client code to deadlock on itself with two lazy singletons calling each other's providers during creation. This is deemed as a non-issue as it is up to the client to write a thread-safe code. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=91610630
2015-04-21Add a default value and make it true for dagger & guice MapKey.sameb
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89998087
2015-04-08Merge pull request #911 from mcculls/dependency-stack-performanceSam Berlin
Improve performance of internal DependencyStack collection
2015-04-05Change initial DependencyStack size from 10 to 16Stuart McCulloch
2015-03-24Merge pull request #912 from google/moe-changesSam Berlin
Merge internal changes
2015-03-23Some work on issue 910 -- ensure that anonymous keys & typeliterals don'tsameb
retain references to their parent classes. Still some more work to do in WeakKeySet to let it clean up more frequently, but this should help for now. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89328452
2015-03-23Fix ModuleAnnotatedMethodScanners so that they scan modules installed insameb
binders created from skipSources or withSource. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89146131
2015-03-23Add ability to not scope exception to RemoteProviderBindercnester
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=87524840
2015-03-23Move detailed javadoc description down to implementation classStuart McCulloch
2015-03-21Improve performance of internal DependencyStack collectionStuart McCulloch
2015-02-25Merge pull request #905 from ↵Sam Berlin
google/moe_writing_branch_from_b605a34702d8d8112983aca891e3e2b6987ec45e Merge internal changes
2015-02-24Further fixes for https://github.com/google/guice/issues/904 -- java8 generatessameb
default methods for subclasses when they override generic methods with the more specific type. We use a two-tiered approach to fixing: (1) try to use MethodHandles + unreflectSpecial, which lets us call default method implementations directly, and if that doesn't work then (2) try to map default methods to compatible method signatures that could be the overrides of the method. (1) may not always work because we're using a private API [new Lookup(clazz, int)], but we need to do that in order to non-public classes. (2) may not always work because it's possible to have more than one compatible method signature. In the unlikely case that both (1) & (2) fail, we give an error message. Also: we must validate the default method's return type for visibility vs the factory type's visibility too. This ends up with two possible differences caused by java8: a) If the Lookup cxtor can't be used (different JDK, version skew, etc..) and there's more than one compatible method signature: we fail. b) If the default method's return type isn't public but the factory is public: we fail. For reference, javac8 generates a default method in the following scenario: interface Parent<I extends CharSequence, O extends Number> { O create(I input); } interface Child<String, Integer> { Integer create(String input); } Child has a generated default method of: Number create(CharSequence input); ... so, for example, failure could be newly triggered if 'Number' was package-private but Child was public, or if the reflection APIs didn't work and Child also had a 'Integer create(StringBuilder input);' method. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=87097207
2015-02-24Add a snapshot repository to guice's parent pom configuration, so it can ↵cgruber
rely on snapshot versions of things while in development. This should change nothing about release-time as snapshot dependencies are not kosher for release. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=86827570
2015-02-24Give the dagger interop extension a name, remove the explicit dependency on ↵sameb
the parent (which should happen automatically), and use ${project.version} instead of hard-coding the version... like the other extensions. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=86826607
2015-02-24s/Set/Optional and fix grammar.sameb
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=86803793