From bdaef22ff44c33498aa65f999c9274d7dcd883f0 Mon Sep 17 00:00:00 2001
From: Colin Cross <ccross@android.com>
Date: Mon, 14 Jan 2019 16:41:18 -0800
Subject: Exit on failure in genrule for loop

Bash does not exit early on failures in a for loop, and it returns
the exit code of the last time through the loop.  Exit explicitly
on failures in the loop.

Bug: 122712680
Test: m checkbuild
Change-Id: I19de5cec09ca467f73e6a8a0abe0fc02bc17fa64
---
 Android.bp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'Android.bp')

diff --git a/Android.bp b/Android.bp
index 3fdc2cb0..c8b91678 100644
--- a/Android.bp
+++ b/Android.bp
@@ -85,7 +85,7 @@ genrule {
     ],
     cmd: "for src in $(in); do " +
         "  mkdir -p $$(dirname $(genDir)/$${src}) && " +
-        "  $(location guice_munge) -DNO_AOP $${src} > $(genDir)/$${src}; " +
+        "  $(location guice_munge) -DNO_AOP $${src} > $(genDir)/$${src} || exit 1; " +
         " done && " +
         " $(location soong_zip) -o $(out) -C $(genDir) -D $(genDir)",
 }
-- 
cgit v1.2.3