summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-07 14:11:55 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-07 14:11:55 +0000
commit1f09f12add39877c300cbb0bb1ac33e0e484c568 (patch)
treeab4b88ce7d5b53686ad5d19ac6658adfcd5b2e2e
parentf9858e742c190030311a2a31d56ce409a7acc24e (diff)
parenta0c54a4c17c81896e2da9bf1a2cda837ebbe6f57 (diff)
downloadicu-1f09f12add39877c300cbb0bb1ac33e0e484c568.tar.gz
Fix ICUServiceThreadTest flakiness am: 404526ce6e am: 1447a68d44 am: a0c54a4c17
Change-Id: I23dca0684979aeaca42c3db3532a1839a27687ef
-rw-r--r--android_icu4j/src/main/java/android/icu/impl/ICUService.java6
-rw-r--r--icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java6
2 files changed, 8 insertions, 4 deletions
diff --git a/android_icu4j/src/main/java/android/icu/impl/ICUService.java b/android_icu4j/src/main/java/android/icu/impl/ICUService.java
index 850da1afd..aa79df43e 100644
--- a/android_icu4j/src/main/java/android/icu/impl/ICUService.java
+++ b/android_icu4j/src/main/java/android/icu/impl/ICUService.java
@@ -597,13 +597,15 @@ public class ICUService extends ICUNotifier {
Factory f = lIter.previous();
f.updateVisibleIDs(mutableMap);
}
- this.idcache = Collections.unmodifiableMap(mutableMap);
+ Map<String, Factory> result = Collections.unmodifiableMap(mutableMap);
+ this.idcache = result;
+ return result;
} finally {
factoryLock.releaseRead();
}
}
+ return idcache;
}
- return idcache;
}
private Map<String, Factory> idcache;
diff --git a/icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java b/icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java
index 4db16b382..afdbfa9f7 100644
--- a/icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java
+++ b/icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java
@@ -592,13 +592,15 @@ public class ICUService extends ICUNotifier {
Factory f = lIter.previous();
f.updateVisibleIDs(mutableMap);
}
- this.idcache = Collections.unmodifiableMap(mutableMap);
+ Map<String, Factory> result = Collections.unmodifiableMap(mutableMap);
+ this.idcache = result;
+ return result;
} finally {
factoryLock.releaseRead();
}
}
+ return idcache;
}
- return idcache;
}
private Map<String, Factory> idcache;