summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-07 13:31:39 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-02-07 13:31:39 +0000
commit1447a68d44147724dcbb20669efae0b05d31f2ea (patch)
treeab4b88ce7d5b53686ad5d19ac6658adfcd5b2e2e
parent79f2c25bbca4bcf745643021a08deffd7ba52db7 (diff)
parent404526ce6ebc40ec877863cbae77e8e9cd704ace (diff)
downloadicu-1447a68d44147724dcbb20669efae0b05d31f2ea.tar.gz
Fix ICUServiceThreadTest flakiness am: 404526ce6e
Change-Id: I281ea9a5e408b1f45088092a863e20b471bdf44e
-rw-r--r--android_icu4j/src/main/java/android/icu/impl/ICUService.java6
-rw-r--r--icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java6
2 files changed, 8 insertions, 4 deletions
diff --git a/android_icu4j/src/main/java/android/icu/impl/ICUService.java b/android_icu4j/src/main/java/android/icu/impl/ICUService.java
index 850da1afd..aa79df43e 100644
--- a/android_icu4j/src/main/java/android/icu/impl/ICUService.java
+++ b/android_icu4j/src/main/java/android/icu/impl/ICUService.java
@@ -597,13 +597,15 @@ public class ICUService extends ICUNotifier {
Factory f = lIter.previous();
f.updateVisibleIDs(mutableMap);
}
- this.idcache = Collections.unmodifiableMap(mutableMap);
+ Map<String, Factory> result = Collections.unmodifiableMap(mutableMap);
+ this.idcache = result;
+ return result;
} finally {
factoryLock.releaseRead();
}
}
+ return idcache;
}
- return idcache;
}
private Map<String, Factory> idcache;
diff --git a/icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java b/icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java
index 4db16b382..afdbfa9f7 100644
--- a/icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java
+++ b/icu4j/main/classes/core/src/com/ibm/icu/impl/ICUService.java
@@ -592,13 +592,15 @@ public class ICUService extends ICUNotifier {
Factory f = lIter.previous();
f.updateVisibleIDs(mutableMap);
}
- this.idcache = Collections.unmodifiableMap(mutableMap);
+ Map<String, Factory> result = Collections.unmodifiableMap(mutableMap);
+ this.idcache = result;
+ return result;
} finally {
factoryLock.releaseRead();
}
}
+ return idcache;
}
- return idcache;
}
private Map<String, Factory> idcache;