diff options
| author | Victor Chang <vichang@google.com> | 2018-12-24 16:58:14 +0000 |
|---|---|---|
| committer | Victor Chang <vichang@google.com> | 2019-01-11 10:15:13 +0000 |
| commit | 9aebd667ddcfd6a7012e27c8346d6f3fa40c4c1c (patch) | |
| tree | ca10d489654c4c5c502c8d158d422ab7d98a9448 /android_icu4c | |
| parent | fbbec54879b7c1914ec2efb555889453db692ae4 (diff) | |
| download | icu-9aebd667ddcfd6a7012e27c8346d6f3fa40c4c1c.tar.gz | |
Show build-time error if linking libicuuc without the ANDROID_LINK_SHARED_ICU4C flag
If an Android libarary links aganist libicuuc without this flag,
stops the build process. Only the following libraries should have this
flag,
- Libraries in Runtime APEX module
Otherwise, the libraries should use libandroidicu.
Note that libandroidicu has no C++ API.
Bug: 117094880
Test: m checkbuild
Change-Id: I579b056cdb0bf00d03072fdaa606f0991eb8e8d2
Diffstat (limited to 'android_icu4c')
| -rw-r--r-- | android_icu4c/include/uconfig_local.h | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/android_icu4c/include/uconfig_local.h b/android_icu4c/include/uconfig_local.h index ec4a4a069..4b4e76d35 100644 --- a/android_icu4c/include/uconfig_local.h +++ b/android_icu4c/include/uconfig_local.h @@ -20,13 +20,9 @@ * stops the build process. Only the following libraries should have this * flag, * - Libraries in Runtime APEX module - * - Host libraries - * - Includes libicuuc as a static library * Otherwise, the libraries should use libandroidicu. */ #if defined(__ANDROID__) && !defined(ANDROID_LINK_SHARED_ICU4C) -// TODO: Enable #error when the exception flag ANDROID_LINK_SHARED_ICU4C is -// added to all the android libraries -// #error "Please use libandroidicu and do not directly link to libicuuc or libicui18n." +#error "Please use libandroidicu and do not directly link to libicuuc or libicui18n." #endif |