aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAurimas Liutikas <aurimas@google.com>2017-02-17 13:14:02 -0800
committerAurimas Liutikas <aurimas@google.com>2017-02-17 13:14:02 -0800
commit9b06472d34f1ead256dd91ff2f39439589447bd3 (patch)
tree616638a121772903eba4382d88e3120a426f370a
parent7ce69df55d5a599246b39b28188a6f70e4d25f31 (diff)
downloadiptables-9b06472d34f1ead256dd91ff2f39439589447bd3.tar.gz
Suppress warnings in external/iptables.
Supress existing warning types and enable -Werror to prevent any regressions. Bug: 28697744 Test: make iptables ip6tables has no warnings Change-Id: I40bcec8ab2846c8e786b37499200aaae393d662d
-rw-r--r--iptables/Android.mk13
-rw-r--r--libxtables/Android.mk4
2 files changed, 13 insertions, 4 deletions
diff --git a/iptables/Android.mk b/iptables/Android.mk
index d0fd7d36..a6f2ae6f 100644
--- a/iptables/Android.mk
+++ b/iptables/Android.mk
@@ -1,4 +1,13 @@
LOCAL_PATH:= $(call my-dir)
+
+commonFlags:= \
+ -Wno-missing-field-initializers \
+ -Wno-sign-compare \
+ -Wno-pointer-arith \
+ -Wno-unused-parameter \
+ -Wno-parentheses-equality \
+ -Werror
+
#----------------------------------------------------------------
# iptables
@@ -14,7 +23,7 @@ LOCAL_CFLAGS+=-DXTABLES_INTERNAL
LOCAL_CFLAGS+=-D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DENABLE_IPV4
# Accommodate arm-eabi-4.4.3 tools that don't set __ANDROID__
LOCAL_CFLAGS+=-D__ANDROID__
-LOCAL_CFLAGS += -Wno-sign-compare -Wno-pointer-arith
+LOCAL_CFLAGS += $(commonFlags)
LOCAL_SRC_FILES:= \
xtables-multi.c iptables-xml.c xshared.c \
@@ -51,7 +60,7 @@ LOCAL_CFLAGS+=-DXTABLES_INTERNAL
LOCAL_CFLAGS+=-D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DENABLE_IPV6
# Accommodate arm-eabi-4.4.3 tools that don't set __ANDROID__
LOCAL_CFLAGS+=-D__ANDROID__
-LOCAL_CFLAGS += -Wno-sign-compare -Wno-pointer-arith
+LOCAL_CFLAGS += $(commonFlags)
LOCAL_SRC_FILES:= \
xtables-multi.c iptables-xml.c xshared.c \
diff --git a/libxtables/Android.mk b/libxtables/Android.mk
index beae9420..1fb44e8d 100644
--- a/libxtables/Android.mk
+++ b/libxtables/Android.mk
@@ -13,7 +13,7 @@ LOCAL_CFLAGS:=-DNO_SHARED_LIBS=1
LOCAL_CFLAGS+=-DXTABLES_INTERNAL
LOCAL_CFLAGS+=-DXTABLES_LIBDIR=\"xtables_libdir_not_used\"
LOCAL_CFLAGS+=-D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DENABLE_IPV4 -DENABLE_IPV6
-LOCAL_CFLAGS += -Wno-sign-compare -Wno-pointer-arith -Wno-type-limits -Wno-missing-field-initializers -Wno-unused-parameter -Wno-clobbered
+LOCAL_CFLAGS += -Wno-sign-compare -Wno-pointer-arith -Wno-type-limits -Wno-missing-field-initializers -Wno-unused-parameter -Wno-clobbered -Wno-tautological-compare -Werror
LOCAL_LDFLAGS:=-version-info 10:0:0
LOCAL_SRC_FILES:= \
@@ -35,7 +35,7 @@ LOCAL_CFLAGS+=-DXTABLES_INTERNAL
LOCAL_CFLAGS+=-DXTABLES_LIBDIR=\"xtables_libdir_not_used\"
LOCAL_CFLAGS+=-D_LARGEFILE_SOURCE=1 -D_LARGE_FILES -D_FILE_OFFSET_BITS=64 -D_REENTRANT -DENABLE_IPV4 -DENABLE_IPV6
-LOCAL_CFLAGS += -Wno-sign-compare -Wno-pointer-arith -Wno-type-limits -Wno-missing-field-initializers -Wno-unused-parameter -Wno-clobbered
+LOCAL_CFLAGS += -Wno-sign-compare -Wno-pointer-arith -Wno-type-limits -Wno-missing-field-initializers -Wno-unused-parameter -Wno-clobbered -Wno-tautological-compare -Werror
LOCAL_SRC_FILES:= \
xtables.c xtoptions.c