aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-12-22Translated using Weblate (Portuguese (Brazil))Rafael Fontenelle
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/pt_BR/ Signed-off-by: Rafael Fontenelle <rafaelff@gnome.org> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-22README: Update historyPetr Vorel
+ wording in title Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-21po: Upper case DNS and IP abbreviationsPetr Vorel
Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-21Translated using Weblate (Portuguese (Brazil))Rafael Fontenelle
Currently translated at 97.2% (245 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/pt_BR/ Signed-off-by: Rafael Fontenelle <rafaelff@gnome.org> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-21Translated using Weblate (French)Jean-Baptiste Holcroft
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/fr/ Signed-off-by: Jean-Baptiste Holcroft <jean-baptiste@holcroft.fr> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-20Translated using Weblate (Georgian)Temuri Doghonadze
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/ka/ Signed-off-by: Temuri Doghonadze <temuri.doghonadze@gmail.com> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-20Translated using Weblate (Korean)김인수
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/ko/ Signed-off-by: 김인수 <simmon@nplob.com> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-20Translated using Weblate (Chinese (Simplified) (zh_CN))yangyangdaji
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/zh_CN/ Signed-off-by: yangyangdaji <1504305527@qq.com> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-20Translated using Weblate (Portuguese (Brazil))Rafael Fontenelle
Currently translated at 94.4% (238 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/pt_BR/ Signed-off-by: Rafael Fontenelle <rafaelff@gnome.org> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-20Translated using Weblate (German)Marek Küthe
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/de/ Signed-off-by: Marek Küthe <m.k@mk16.de> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-20Translated using Weblate (Ukrainian)Yuri Chornoivan
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/uk/ Signed-off-by: Yuri Chornoivan <yurchor@ukr.net> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-19man/ping: Another rfc4620 term fixPetr Vorel
rfc4620 specifies "IPv6 Node Information Queries", not "ICMPv6 Node Information Queries". Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-19Translated using Weblate (Czech)Petr Vorel
Currently translated at 99.2% (251 of 253 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/cs/ Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-19po: Update iputils.pot and *.po filesPetr Vorel
Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-19ping: More minor corrections in helpPetr Vorel
rfc4620 specifies "IPv6 Node Information Queries", not "icmp6 node info queries". Add path to MTU. Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-19po: Update iputils.pot and *.po filesPetr Vorel
Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-19tree: Upper case abbreviations in helpPetr Vorel
Write DNS and IP abbreviations in upper case. tracepath: add "reverse" to -n Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-18Translated using Weblate (Czech)Petr Vorel
Currently translated at 99.2% (250 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/cs/ Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-15man/ping: Document collisions and pid_maxPetr Vorel
This is a follow up of d466aab ("Revert "ping: use random value for the identifier field""). Closes: https://github.com/iputils/iputils/pull/507 Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Reviewed-by: Avinesh Kumar <akumar@suse.de> Co-Developed-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-15tracepath: Add NULL pointer assert() checkPetr Vorel
Although it's very unlikely struct addrinfo returned from getaddrinfo() would be NULL when the function returned 0, assert does not harm. Close: https://github.com/iputils/iputils/pull/498 Reported-by: Dmitry Chestnykh <dm.chestnykh@gmail.com> Suggested-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-14ping: arping: Properly fix -Wpedantic warningsPetr Vorel
7c4049b tried to fix -Wpedantic warnings: ../ping/ping.c: In function ‘_pr_addr’: ../ping/ping.c:1769:50: warning: ISO C forbids empty initializer braces before C2X [-Wpedantic] 1769 | static struct sockaddr_storage last_sa = {}; | ^ [28/31] Compiling C object arping.p/arping.c.o ../arping.c: In function ‘event_loop’: ../arping.c:728:40: warning: ISO C forbids empty initializer braces before C2X [-Wpedantic] 728 | struct sockaddr_storage from = {}; | ^ with memset(). But that caused another problem: when target have multiple IP addresses, last entries sometimes lost DNS record ("dns.google"): $ ./builddir/ping/ping -c5 -i0.02 dns.google -v ./builddir/ping/ping: sock4.fd: 3 (socktype: SOCK_DGRAM), sock6.fd: 4 (socktype: SOCK_DGRAM), hints.ai_family: AF_UNSPEC ai->ai_family: AF_INET, ai->ai_canonname: 'dns.google' PING dns.google (8.8.4.4) 56(84) bytes of data. 64 bytes from dns.google (8.8.4.4): icmp_seq=1 ttl=117 time=15.1 ms 64 bytes from dns.google (8.8.4.4): icmp_seq=2 ttl=117 time=22.9 ms 64 bytes from dns.google (8.8.4.4): icmp_seq=3 ttl=117 time=19.3 ms 64 bytes from dns.google (8.8.4.4): icmp_seq=4 ttl=117 time=20.0 ms 64 bytes from 8.8.4.4: icmp_seq=5 ttl=117 time=21.4 ms $ ./builddir/ping/ping -c5 -i0.02 dns.google PING dns.google (8.8.8.8) 56(84) bytes of data. 64 bytes from dns.google (8.8.8.8): icmp_seq=1 ttl=117 time=18.5 ms 64 bytes from dns.google (8.8.8.8): icmp_seq=2 ttl=117 time=33.2 ms 64 bytes from dns.google (8.8.8.8): icmp_seq=3 ttl=117 time=34.1 ms 64 bytes from 8.8.8.8: icmp_seq=4 ttl=117 time=23.3 ms 64 bytes from 8.8.8.8: icmp_seq=5 ttl=117 time=19.2 ms Therefore revert commit 7c4049b698b04b71d97ec86daf1d02fd127360df and replace {} with proper form {0}. The struct sockaddr_storage is declared static, that means that it's not allocated on the function stack, rather than that it's allocated in the program data and the variable lifetime is not limited by the function scope. Hence the code that does = {0} initializes the variable once at the start of the program, while memset() clears it on each function call. Fixes: 7c4049b ("arping / ping: fix couple warnings") Closes: https://github.com/iputils/iputils/pull/505 Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-11Translated using Weblate (Turkish)Oğuz Ersen
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/tr/ Closes: https://github.com/iputils/iputils/pull/506 Signed-off-by: Oğuz Ersen <oguz@ersen.moe> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-11tracepath: Don't assume tv_sec == 0 means unsetJosh Triplett
A CLOCK_MONOTONIC timespec's tv_sec value can legitimately be 0 during the second after booting. Check tv_nsec as well before assuming an unset timestamp. Closes: https://github.com/iputils/iputils/pull/499 Reviewed-by: Petr Vorel <pvorel@suse.cz> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
2023-12-11ping: Handle interval correctly in the second after bootingJosh Triplett
ping assumes that if a timespec has tv_sec == 0, it hasn't been initialized yet. However, in the second after booting up, tv_sec will legitimately be 0. This causes ping to send pings one after another without waiting. Check that tv_nsec is 0 as well. Link: https://github.com/iputils/iputils/pull/499 Reviewed-by: Petr Vorel <pvorel@suse.cz> Tested-by: Petr Vorel <pvorel@suse.cz> Signed-off-by: Josh Triplett <josh@joshtriplett.org>
2023-12-11ping: Add option -H to force reverse DNS resolutionPetr Vorel
Forcing DNS name resolution is useful for numeric destination, or -f option, which by default do not perform it. -H overrides previously defined -n, -n overrides previously defined -H (useful, when one of them is in alias it can still be overridden). Fixes: https://github.com/iputils/iputils/issues/421 Fixes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=650479 Closes: https://github.com/iputils/iputils/pull/494 Reported-by: Vincent Lefevre <vincent@vinc17.net> Reported-by: Michele Guerini Rocco <rnhmjoj@inventati.org> Reviewed-by: Vincent Lefevre <vincent@vinc17.net> Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Reviewed-by: Guillaume Nault <guillaume.nault@wanadoo.fr> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-11ping: Improve reverse DNS description in helpPetr Vorel
ping -n option is about reverse DNS resolution, using just "DNS resolution" was misleading, therefore add the word "reverse". Also upper case DNS abbreviation. Link: https://github.com/iputils/iputils/pull/494 Suggested-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-11man/ping: Describe the defaults for -n option, rewordPetr Vorel
Link: https://github.com/iputils/iputils/pull/494#issuecomment-1771781092 Suggested-by: Vincent Lefevre <vincent@vinc17.net> Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Reviewed-by: Guillaume Nault <guillaume.nault@wanadoo.fr> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-10Revert "ping: use random value for the identifier field"Petr Vorel
This reverts commit 5026c2221a15bf13e601eade015c971bf07a27e9. Unlike TCP and UDP, which use port to uniquely identify the socket to deliver data, ICMP use identifier field (ID) to identify the socket. Therefore if on the same machine, at the same time, two ping processes use the same ID, echo reply can be delivered to the wrong socket. This is known problem due 16 bit ID field (65535). We used to use PID to get unique number. The default value of /proc/sys/kernel/pid_max is 32768 (half). The problem is not new, but it was hidden until 5f6bec5 ("ping: Print reply with wrong source with warning"). 5026c22 changed it to use our random implementation to increase security. But that actually increases the collisions on systems that use ping heavily: e.g. ping run with Nagios via Debian specific check-host-alive Nagios plugin: $ ping -n -v -D -W 1 -i 1 -c 5 -M 'do' -s 56 -O "$Host") (75-100 ping instances in the reported issue.) Because we consider warning from 5f6bec5 useful and not consider leaking PID information as a real security issue, we revert 5026c22. getpid() is used in other ping implementations: * fping https://github.com/schweikert/fping/blob/develop/src/fping.c#L496 * busybox https://git.busybox.net/busybox/tree/networking/ping.c#n376 * FreeBSD https://cgit.freebsd.org/src/tree/sbin/ping/ping.c#n632 * inetutils https://git.savannah.gnu.org/cgit/inetutils.git/tree/ping/ping.c#n286 * Apple https://opensource.apple.com/source/network_cmds/network_cmds-433/ping.tproj/ping.c.auto.html In case leaking PID *is* a real problem, we could solve this with comparing the ICMP optional data. We could add 128 bit random value to check. But we already use struct timeval if packet size is big enough for it (>= 16 bits), therefore we could use it for comparing for most of the packet sizes (the default is 56 bits). Fixes: https://github.com/iputils/iputils/issues/489 Closes: https://github.com/iputils/iputils/pull/503 Reported-by: Miloslav Hůla <miloslav.hula@gmail.com> Suggested-by: Cyril Hrubis <chrubis@suse.cz> Acked-by: Johannes Segitz jsegitz@suse.de Acked-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-04Revert "ping: Avoid computing twice checksum"Petr Vorel
This reverts commit d8296c9b0725d7b4a2d412efc8b43ef551c37fc1. This breaks ping on raw socket on IPv4 (ping hangs). Fixes: d8296c9 ("ping: Avoid computing twice checksum") Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-04ping: Remove useless castingPetr Vorel
Closes: https://github.com/iputils/iputils/pull/501 Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-12-04ping: Avoid computing twice checksumPetr Vorel
By default (on default size or size >= sizeof(struct timeval): i.e. >= 16 and without -U), ping calculates checksump twice. Avoid that. Closes: https://github.com/iputils/iputils/pull/501 Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-11-15man/ping: Update TTL detailsPetr Vorel
Update old TTL info from RFC 793 with RFC 9293 (TTL used to be 60, but now it must be configurable). NOTE the default and maximum value. Remove also telnet and ftp info (deprecated tools). Fixes: https://github.com/iputils/iputils/issues/488 Closes: https://github.com/iputils/iputils/pull/497 Reported-by: Greg Skinner <gds@alum.mit.edu> Suggested-by: Greg Skinner <gds@alum.mit.edu> Reviewed-by: Greg Skinner <gds@alum.mit.edu> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-11-14doc/tracepath: Document error messagesPetr Vorel
Implements: https://github.com/iputils/iputils/issues/463 Closes: https://github.com/iputils/iputils/pull/495 Suggested-by: Marek Küthe <m.k@mk16.de> Reviewed-by: Marek Küthe <m.k@mk16.de> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-20Translated using Weblate (Finnish)Jan Kuparinen
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/fi/ Signed-off-by: Jan Kuparinen <copper_fin@hotmail.com> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-20ping: Use print target when empty ai_canonnamePetr Vorel
On certain network setup getaddrinfo() can return empty ai_canonname when forcing IP protocol version. Instead of printing nothing in "PING" line use the target. This fixes the output of PING line: $ ping seznam.cz -c1 -4 -v ... ai->ai_family: AF_INET6, ai->ai_canonname: 'seznam.cz' ai->ai_family: AF_INET6, ai->ai_canonname: '' ai->ai_family: AF_INET, ai->ai_canonname: '' PING (77.75.79.222) 56(84) bytes of data. 64 bytes from www.seznam.cz (77.75.79.222): icmp_seq=1 ttl=55 time=4.82 ms to $ ping seznam.cz -c1 -4 -v ... PING seznam.cz (77.75.79.222) 56(84) bytes of data. 64 bytes from www.seznam.cz (77.75.79.222): icmp_seq=1 ttl=55 time=4.88 ms Implements: https://github.com/iputils/iputils/issues/421 Link: https://github.com/iputils/iputils/pull/478#issuecomment-1676119425 Reported-by: Michele Guerini Rocco <rnhmjoj@inventati.org> Reported-by: Robert Scheck <robert@fedoraproject.org> Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-17README.maintainer: Update to use scriptsPetr Vorel
Update docs to suggest to use tools/tag-release.sh, tools/create-tarballs.sh and tools/tag-release.sh scripts. Simplify description. Changes: * Generate own tarballs, sign them. * Don't sign github files, discourage using it. * Stop suggesting -u keyid, because tools/create-tarballs.sh does not support it (not needed for the current maintainers). * Minor formatting fixes. Closes: https://github.com/iputils/iputils/pull/492 Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-17tools: Add script for creating tarballs and checksumsPetr Vorel
A helper for new releases. meson puts '*' before filename in checksums, therefore they are unusable. Also it puts them into separate files. Therefore recreate them manually with sha256sum and put them into single file. Sign it with GPG. Implements: https://github.com/iputils/iputils/issues/479 Reviewed-by: Mike Frysinger <vapier@gmail.com> Reviewed-by: Noah Meyerhans <noahm@debian.org> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-17tools: Add a script for tagging the releasePetr Vorel
A helper for new releases. Functions will be reused in another script (next commit). Reviewed-by: Mike Frysinger <vapier@gmail.com> Reviewed-by: Noah Meyerhans <noahm@debian.org> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-15Translated using Weblate (Czech)Petr Vorel
Currently translated at 98.8% (249 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/cs/ Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-15Translated using Weblate (Chinese (Simplified) (zh_CN))yangyangdaji
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/zh_CN/ Signed-off-by: yangyangdaji <1504305527@qq.com> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-15Translated using Weblate (Georgian)Temuri Doghonadze
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/ka/ Signed-off-by: Temuri Doghonadze <temuri.doghonadze@gmail.com> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-15Translated using Weblate (Korean)김인수
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/ko/ Signed-off-by: 김인수 <simmon@nplob.com> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-15Translated using Weblate (Ukrainian)Yuri Chornoivan
Currently translated at 100.0% (252 of 252 strings) Translation: iputils/iputils Translate-URL: https://translate.fedoraproject.org/projects/iputils/iputils/uk/ Signed-off-by: Yuri Chornoivan <yurchor@ukr.net> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-06po: Update iputils.pot and *.po filesPetr Vorel
To reflect change in commit fb75557. Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-06tools: Add helper for updating po filesPetr Vorel
Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-06ping: Improve interval error messagePetr Vorel
Improve too low interval for user on broadcast, multicast and flood error message. Instead of printing "raw" interval (i.e. -i value * 1000) it's more user friendly to print requested -i value. $ ./builddir/ping/ping -b 192.168.122.255 -i0.1 WARNING: pinging broadcast address ./builddir/ping/ping: minimal interval for broadcast ping for user must be >= 1000 ms, use -i 1 (or higher) $ ./builddir/ping/ping -i0.1 ff02::1%tun0 ./builddir/ping/ping: minimal interval for multicast ping for user must be >= 1000 ms, use -i 1 (or higher) NOTE: Too low -i value and -f for user without -i use the same message (maybe that should be further improved): $ ./builddir/ping/ping ::1 -f PING ::1 (::1) 56 data bytes ./builddir/ping/ping: cannot flood, minimal interval for user must be >= 2 ms, use -i 0.002 (or higher) $ ./builddir/ping/ping -i 0.0019 ::1 PING ::1 (::1) 56 data bytes ./builddir/ping/ping: cannot flood, minimal interval for user must be >= 2 ms, use -i 0.002 (or higher) Modified strings are localized. Link: https://github.com/iputils/iputils/issues/484#issuecomment-1691025991 Closes: https://github.com/iputils/iputils/pull/487 Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-06ping: Add constant for broadcast/multicast intervalPetr Vorel
Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-06ping: Rename interval constantsPetr Vorel
Add underscores for readability. Interval is in milliseconds, thus MS. This is a preparation for next commit which will add longer constant which would be unreadable without underscore. OTOH it's probably not a good idea to rename all constants (it'd pollute git history), therefore renamed only interval constants. Reviewed-by: Cyril Hrubis <chrubis@suse.cz> Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-01man/ping: -e requires parameterPetr Vorel
-e option was missing parameter called identifier. Adding it requires also moving option in SYNOPSIS section. Fixes: 43e38f2 ("ping: Add option -e to set Identifier field for ICMP ECHO_REQUEST") Signed-off-by: Petr Vorel <pvorel@suse.cz>
2023-10-01man/ping: Move -e to correct place (sort alphabetically)Petr Vorel
Fixes: 43e38f2 ("ping: Add option -e to set Identifier field for ICMP ECHO_REQUEST") Signed-off-by: Petr Vorel <pvorel@suse.cz>