diff options
author | Mirko Friedenhagen <mfriedenhagen@gmail.com> | 2013-11-15 21:11:56 +0100 |
---|---|---|
committer | Mirko Friedenhagen <mfriedenhagen@gmail.com> | 2013-11-15 21:11:56 +0100 |
commit | 7d98f8b6ecbcd01771afe875512fda12eb6c8ec3 (patch) | |
tree | e4b142cb3a46082e5a04a68d45101469822d532e /jacoco-maven-plugin | |
parent | 962a13d7703ce7c530871a61b38fb579486d4266 (diff) | |
download | jacoco-7d98f8b6ecbcd01771afe875512fda12eb6c8ec3.tar.gz |
Move the socket initialization to outer scope.
This guarentees that socket is not null.
Diffstat (limited to 'jacoco-maven-plugin')
-rw-r--r-- | jacoco-maven-plugin/src/org/jacoco/maven/DumpMojo.java | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/jacoco-maven-plugin/src/org/jacoco/maven/DumpMojo.java b/jacoco-maven-plugin/src/org/jacoco/maven/DumpMojo.java index 885e450a..bd424656 100644 --- a/jacoco-maven-plugin/src/org/jacoco/maven/DumpMojo.java +++ b/jacoco-maven-plugin/src/org/jacoco/maven/DumpMojo.java @@ -103,11 +103,9 @@ public class DumpMojo extends AbstractJacocoMojo { try { final ExecFileLoader loader = new ExecFileLoader(); - Socket socket = null; + final Socket socket = tryConnect(); try { - - // 1. Open socket connection - socket = tryConnect(); + // 1. Get streams from socket final RemoteControlWriter remoteWriter = new RemoteControlWriter( socket.getOutputStream()); final RemoteControlReader remoteReader = new RemoteControlReader( @@ -122,9 +120,7 @@ public class DumpMojo extends AbstractJacocoMojo { remoteReader.read(); } finally { - if (socket != null) { - socket.close(); - } + socket.close(); } // 3. Write execution data to file |