Do not render source files page if no source information is available.

2 files changed, 14 insertions, 10 deletions

diff --git a/org.jacoco.report/src/org/jacoco/report/internal/html/page/PackagePage.java b/org.jacoco.report/src/org/jacoco/report/internal/html/page/PackagePage.java
index f374846a..5844ec91 100644
--- a/org.jacoco.report/src/org/jacoco/report/internal/html/page/PackagePage.java
+++ b/org.jacoco.report/src/org/jacoco/report/internal/html/page/PackagePage.java
@@ -29,6 +29,7 @@ import org.jacoco.report.internal.html.resources.Styles;
 public class PackagePage extends TablePage<IPackageCoverage> {
 
 	private final PackageSourcePage packageSourcePage;
+	private final boolean sourceCoverageExists;
 
 	/**
 	 * Creates a new visitor in the given context.
@@ -50,11 +51,14 @@ public class PackagePage extends TablePage<IPackageCoverage> {
 		super(node, parent, folder, context);
 		packageSourcePage = new PackageSourcePage(node, parent, locator,
 				folder, context, this);
+		sourceCoverageExists = !node.getSourceFiles().isEmpty();
 	}
 
 	@Override
 	public void render() throws IOException {
-		packageSourcePage.render();
+		if (sourceCoverageExists) {
+			packageSourcePage.render();
+		}
 		renderClasses();
 		super.render();
 	}
@@ -87,8 +91,10 @@ public class PackagePage extends TablePage<IPackageCoverage> {
 
 	@Override
 	protected void infoLinks(final HTMLElement span) throws IOException {
-		final String link = packageSourcePage.getLink(folder);
-		span.a(link, Styles.EL_SOURCE).text("Source Files");
+		if (sourceCoverageExists) {
+			final String link = packageSourcePage.getLink(folder);
+			span.a(link, Styles.EL_SOURCE).text("Source Files");
+		}
 		super.infoLinks(span);
 	}
 
diff --git a/org.jacoco.report/src/org/jacoco/report/internal/html/page/PackageSourcePage.java b/org.jacoco.report/src/org/jacoco/report/internal/html/page/PackageSourcePage.java
index cbd9f4fe..c7f0bf0b 100644
--- a/org.jacoco.report/src/org/jacoco/report/internal/html/page/PackageSourcePage.java
+++ b/org.jacoco.report/src/org/jacoco/report/internal/html/page/PackageSourcePage.java
@@ -32,7 +32,7 @@ import org.jacoco.report.internal.html.resources.Styles;
 public class PackageSourcePage extends TablePage<IPackageCoverage> {
 
 	private final ISourceFileLocator locator;
-	private Map<String, ILinkable> sourceFilePages;
+	private final Map<String, ILinkable> sourceFilePages;
 	private final ILinkable packagePage;
 
 	/**
@@ -58,11 +58,12 @@ public class PackageSourcePage extends TablePage<IPackageCoverage> {
 		super(node, parent, folder, context);
 		this.locator = locator;
 		this.packagePage = packagePage;
+		this.sourceFilePages = new HashMap<String, ILinkable>();
 	}
 
 	@Override
 	public void render() throws IOException {
-		sourceFilePages = renderSourceFilePages();
+		renderSourceFilePages();
 		super.render();
 	}
 
@@ -75,9 +76,7 @@ public class PackageSourcePage extends TablePage<IPackageCoverage> {
 		return sourceFilePages.get(name);
 	}
 
-	private final Map<String, ILinkable> renderSourceFilePages()
-			throws IOException {
-		final Map<String, ILinkable> sourceFiles = new HashMap<String, ILinkable>();
+	private final void renderSourceFilePages() throws IOException {
 		final String packagename = getNode().getName();
 		for (final ISourceFileCoverage s : getNode().getSourceFiles()) {
 			final String sourcename = s.getName();
@@ -89,12 +88,11 @@ public class PackageSourcePage extends TablePage<IPackageCoverage> {
 				final SourceFilePage sourcePage = new SourceFilePage(s, reader,
 						locator.getTabWidth(), this, folder, context);
 				sourcePage.render();
-				sourceFiles.put(sourcename, sourcePage);
+				sourceFilePages.put(sourcename, sourcePage);
 				addItem(sourcePage);
 			}
 
 		}
-		return sourceFiles;
 	}
 
 	@Override