diff options
author | Matt Nelson <matt.nelson@cerner.com> | 2017-05-17 10:09:41 -0500 |
---|---|---|
committer | Matt Nelson <matt.nelson@cerner.com> | 2017-05-17 10:09:41 -0500 |
commit | c39e3d26cc91c7968377382be00515d103af2a44 (patch) | |
tree | a78c904c5cf67c331bdbb7a64a17256453eb4f5c /org.jacoco.report | |
parent | d9caed9db04181c06e7ce02a2750fdfc7f220ecb (diff) | |
download | jacoco-c39e3d26cc91c7968377382be00515d103af2a44.tar.gz |
create reusable parseValue method for ratio limits
Diffstat (limited to 'org.jacoco.report')
-rw-r--r-- | org.jacoco.report/src/org/jacoco/report/check/Limit.java | 33 |
1 files changed, 13 insertions, 20 deletions
diff --git a/org.jacoco.report/src/org/jacoco/report/check/Limit.java b/org.jacoco.report/src/org/jacoco/report/check/Limit.java index 1e2634aa..2b25e256 100644 --- a/org.jacoco.report/src/org/jacoco/report/check/Limit.java +++ b/org.jacoco.report/src/org/jacoco/report/check/Limit.java @@ -124,13 +124,7 @@ public class Limit { * checked */ public void setMinimum(final String minimum) { - if (minimum == null) { - this.minimum = null; - } else if (isPercent(minimum)) { - this.minimum = percentToBigDecimal(minimum); - } else { - this.minimum = new BigDecimal(minimum); - } + this.minimum = parseValue(minimum); } /** @@ -151,22 +145,21 @@ public class Limit { * checked */ public void setMaximum(final String maximum) { - if (maximum == null) { - this.maximum = null; - } else if (isPercent(maximum)) { - this.maximum = percentToBigDecimal(maximum); - } else { - this.maximum = new BigDecimal(maximum); - } + this.maximum = parseValue(maximum); } - private static boolean isPercent(final String value) { - return value.trim().endsWith("%"); - } + private static BigDecimal parseValue(final String value) { + if (value == null) { + return null; + } + + final String trimmedValue = value.trim(); + if (trimmedValue.endsWith("%")) { + final String percent = trimmedValue.substring(0, trimmedValue.length() - 1); + return new BigDecimal(percent).movePointLeft(2); + } - private static BigDecimal percentToBigDecimal(final String value) { - final String percent = value.trim().substring(0, value.length() - 1); - return new BigDecimal(percent).movePointLeft(2); + return new BigDecimal(trimmedValue); } String check(final ICoverageNode node) { |