diff options
author | Egor Andreevich <egor@squareup.com> | 2020-01-14 14:08:36 -0600 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-01-14 14:08:36 -0600 |
commit | 2b7adc794b2ec7fbce3c23409283110757ca7596 (patch) | |
tree | c2d4b7181083356bf6519c74b5217a2573b14a6f | |
parent | 8ce7d7568c23afbd1cbb56ffbd24ae696f1b92b1 (diff) | |
parent | ecfcfca2781e1edd2a98a8508294ea0ad40e88a6 (diff) | |
download | javapoet-2b7adc794b2ec7fbce3c23409283110757ca7596.tar.gz |
Merge pull request #756 from square/egorand/200114/overriding-note
Add a comment about dropping parameter annotations in MethodSpec.overriding
-rw-r--r-- | src/main/java/com/squareup/javapoet/MethodSpec.java | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/main/java/com/squareup/javapoet/MethodSpec.java b/src/main/java/com/squareup/javapoet/MethodSpec.java index b1e61c4..2284ef5 100644 --- a/src/main/java/com/squareup/javapoet/MethodSpec.java +++ b/src/main/java/com/squareup/javapoet/MethodSpec.java @@ -233,6 +233,8 @@ public final class MethodSpec { } methodBuilder.returns(TypeName.get(method.getReturnType())); + // Copying parameter annotations from the overridden method can be incorrect so we're + // deliberately dropping them. See https://github.com/square/javapoet/issues/482. methodBuilder.addParameters(ParameterSpec.parametersOf(method) .stream() .map(parameterSpec -> { |