From ecfcfca2781e1edd2a98a8508294ea0ad40e88a6 Mon Sep 17 00:00:00 2001 From: Egor Andreevici Date: Tue, 14 Jan 2020 07:25:08 -0600 Subject: Add a comment about dropping parameter annotations in MethodSpec.overriding --- src/main/java/com/squareup/javapoet/MethodSpec.java | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/main') diff --git a/src/main/java/com/squareup/javapoet/MethodSpec.java b/src/main/java/com/squareup/javapoet/MethodSpec.java index b1e61c4..2284ef5 100644 --- a/src/main/java/com/squareup/javapoet/MethodSpec.java +++ b/src/main/java/com/squareup/javapoet/MethodSpec.java @@ -233,6 +233,8 @@ public final class MethodSpec { } methodBuilder.returns(TypeName.get(method.getReturnType())); + // Copying parameter annotations from the overridden method can be incorrect so we're + // deliberately dropping them. See https://github.com/square/javapoet/issues/482. methodBuilder.addParameters(ParameterSpec.parametersOf(method) .stream() .map(parameterSpec -> { -- cgit v1.2.3