aboutsummaryrefslogtreecommitdiff
path: root/third_party
diff options
context:
space:
mode:
authorFabian Meumertzheim <meumertzheim@code-intelligence.com>2021-03-19 14:26:02 +0100
committerFabian Meumertzheim <fabian@meumertzhe.im>2021-03-22 15:05:37 +0100
commitc95ecbf9db8263eea620384666ee724fa75b1b1b (patch)
treedfa557a023d1413799c24dbd1373d8c42c2ee8bb /third_party
parent70487525453c60e755bd7b18bc591c9c084d4fdf (diff)
downloadjazzer-api-c95ecbf9db8263eea620384666ee724fa75b1b1b.tar.gz
Do not intercept JVM-internal C stdlib calls
The JVM frequently calls strcmp/memcmp/..., which fills up the table of recent compares with entries that are either duplicates of values already reported by the bytecode instrumentation or JDK-internal strings that are not relevant for fuzzing. This commit adds an ignorelist to the C stdlib interceptors that filters out calls from known JVM libraries. If the fuzz target has not yet loaded a native library, all such callbacks are ignored, which greatly improves fuzzer performance for string-heavy targets. E.g., JsonSanitizerDenylistFuzzer takes < 1 million runs now when it used to take over 3 million.
Diffstat (limited to 'third_party')
-rw-r--r--third_party/BUILD.bazel1
-rw-r--r--third_party/libFuzzer-make-interceptors-configurable.patch109
-rw-r--r--third_party/libFuzzer-pass-death-callback-to-jazzer.patch4
3 files changed, 112 insertions, 2 deletions
diff --git a/third_party/BUILD.bazel b/third_party/BUILD.bazel
index 11a555eb..b391ce54 100644
--- a/third_party/BUILD.bazel
+++ b/third_party/BUILD.bazel
@@ -2,6 +2,7 @@ exports_files([
"gflags-use-double-dash-args.patch",
"jacoco-make-probe-inserter-subclassable.patch",
"jacoco_internal.BUILD",
+ "libFuzzer-make-interceptors-configurable.patch",
"libFuzzer-pass-death-callback-to-jazzer.patch",
"libFuzzer.BUILD",
"libjpeg_turbo.BUILD",
diff --git a/third_party/libFuzzer-make-interceptors-configurable.patch b/third_party/libFuzzer-make-interceptors-configurable.patch
new file mode 100644
index 00000000..9420c4aa
--- /dev/null
+++ b/third_party/libFuzzer-make-interceptors-configurable.patch
@@ -0,0 +1,109 @@
+diff --git compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp
+index b87798603fda..10e34ee86cce 100644
+--- compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp
++++ compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp
+@@ -147,11 +147,18 @@ DEFINE_REAL(char *, strstr, const char *, const char *)
+ DEFINE_REAL(char *, strcasestr, const char *, const char *)
+ DEFINE_REAL(void *, memmem, const void *, size_t, const void *, size_t)
+
++extern "C" __attribute__((weak)) bool
++__sanitizer_weak_is_relevant_pc(void * caller_pc) {
++ return false;
++}
++
+ ATTRIBUTE_INTERFACE int bcmp(const char *s1, const char *s2, size_t n) {
+ if (!FuzzerInited)
+ return internal_memcmp(s1, s2, n);
+ int result = REAL(bcmp)(s1, s2, n);
+- __sanitizer_weak_hook_memcmp(GET_CALLER_PC(), s1, s2, n, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_memcmp(caller_pc, s1, s2, n, result);
+ return result;
+ }
+
+@@ -159,7 +166,9 @@ ATTRIBUTE_INTERFACE int memcmp(const void *s1, const void *s2, size_t n) {
+ if (!FuzzerInited)
+ return internal_memcmp(s1, s2, n);
+ int result = REAL(memcmp)(s1, s2, n);
+- __sanitizer_weak_hook_memcmp(GET_CALLER_PC(), s1, s2, n, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_memcmp(caller_pc, s1, s2, n, result);
+ return result;
+ }
+
+@@ -167,7 +176,9 @@ ATTRIBUTE_INTERFACE int strncmp(const char *s1, const char *s2, size_t n) {
+ if (!FuzzerInited)
+ return internal_strncmp(s1, s2, n);
+ int result = REAL(strncmp)(s1, s2, n);
+- __sanitizer_weak_hook_strncmp(GET_CALLER_PC(), s1, s2, n, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_strncmp(caller_pc, s1, s2, n, result);
+ return result;
+ }
+
+@@ -175,21 +186,27 @@ ATTRIBUTE_INTERFACE int strcmp(const char *s1, const char *s2) {
+ if (!FuzzerInited)
+ return internal_strcmp(s1, s2);
+ int result = REAL(strcmp)(s1, s2);
+- __sanitizer_weak_hook_strcmp(GET_CALLER_PC(), s1, s2, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_strcmp(caller_pc, s1, s2, result);
+ return result;
+ }
+
+ ATTRIBUTE_INTERFACE int strncasecmp(const char *s1, const char *s2, size_t n) {
+ ensureFuzzerInited();
+ int result = REAL(strncasecmp)(s1, s2, n);
+- __sanitizer_weak_hook_strncasecmp(GET_CALLER_PC(), s1, s2, n, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_strncasecmp(caller_pc, s1, s2, n, result);
+ return result;
+ }
+
+ ATTRIBUTE_INTERFACE int strcasecmp(const char *s1, const char *s2) {
+ ensureFuzzerInited();
+ int result = REAL(strcasecmp)(s1, s2);
+- __sanitizer_weak_hook_strcasecmp(GET_CALLER_PC(), s1, s2, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_strcasecmp(caller_pc, s1, s2, result);
+ return result;
+ }
+
+@@ -197,14 +214,18 @@ ATTRIBUTE_INTERFACE char *strstr(const char *s1, const char *s2) {
+ if (!FuzzerInited)
+ return internal_strstr(s1, s2);
+ char *result = REAL(strstr)(s1, s2);
+- __sanitizer_weak_hook_strstr(GET_CALLER_PC(), s1, s2, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_strstr(caller_pc, s1, s2, result);
+ return result;
+ }
+
+ ATTRIBUTE_INTERFACE char *strcasestr(const char *s1, const char *s2) {
+ ensureFuzzerInited();
+ char *result = REAL(strcasestr)(s1, s2);
+- __sanitizer_weak_hook_strcasestr(GET_CALLER_PC(), s1, s2, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_strcasestr(caller_pc, s1, s2, result);
+ return result;
+ }
+
+@@ -212,7 +233,9 @@ ATTRIBUTE_INTERFACE
+ void *memmem(const void *s1, size_t len1, const void *s2, size_t len2) {
+ ensureFuzzerInited();
+ void *result = REAL(memmem)(s1, len1, s2, len2);
+- __sanitizer_weak_hook_memmem(GET_CALLER_PC(), s1, len1, s2, len2, result);
++ void *caller_pc = GET_CALLER_PC();
++ if (__sanitizer_weak_is_relevant_pc(caller_pc))
++ __sanitizer_weak_hook_memmem(caller_pc, s1, len1, s2, len2, result);
+ return result;
+ }
+
diff --git a/third_party/libFuzzer-pass-death-callback-to-jazzer.patch b/third_party/libFuzzer-pass-death-callback-to-jazzer.patch
index 31bd2af1..3fb9fbb0 100644
--- a/third_party/libFuzzer-pass-death-callback-to-jazzer.patch
+++ b/third_party/libFuzzer-pass-death-callback-to-jazzer.patch
@@ -1,5 +1,5 @@
diff --git compiler-rt/lib/fuzzer/FuzzerExtFunctions.def compiler-rt/lib/fuzzer/FuzzerExtFunctions.def
-index 51edf8444..e31f00402 100644
+index 51edf8444e94..e31f0040268b 100644
--- compiler-rt/lib/fuzzer/FuzzerExtFunctions.def
+++ compiler-rt/lib/fuzzer/FuzzerExtFunctions.def
@@ -42,7 +42,7 @@ EXT_FUNC(__sanitizer_symbolize_pc, void,
@@ -12,7 +12,7 @@ index 51edf8444..e31f00402 100644
EXT_FUNC(__msan_scoped_disable_interceptor_checks, void, (), false);
EXT_FUNC(__msan_scoped_enable_interceptor_checks, void, (), false);
diff --git compiler-rt/lib/fuzzer/FuzzerLoop.cpp compiler-rt/lib/fuzzer/FuzzerLoop.cpp
-index 6e3bf44f8..9d17b911c 100644
+index 149742b4c2fe..7b361423cc32 100644
--- compiler-rt/lib/fuzzer/FuzzerLoop.cpp
+++ compiler-rt/lib/fuzzer/FuzzerLoop.cpp
@@ -138,8 +138,8 @@ void Fuzzer::HandleMalloc(size_t Size) {