summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSungsoo Lim <sungsoo@google.com>2016-07-20 16:51:04 +0000
committerandroid-build-merger <android-build-merger@google.com>2016-07-20 16:51:04 +0000
commitfb76bf32454ad32290f8d6613c6ef3ddb6368a1d (patch)
treee978abacd264d7d6a1a0d087427b7f82528722a4
parenta3c15ad42d2a54afd18c2683a0a1b0c80524a6c0 (diff)
parent364ccf5071db8c62721ba5ac25765dcd45fcddb5 (diff)
downloadjhead-fb76bf32454ad32290f8d6613c6ef3ddb6368a1d.tar.gz
Fix possible out of bounds accesses am: ee54e6ceb6 am: 4c7c4297b5
am: 364ccf5071 Change-Id: I19f2d0732e514adca28f85f0c3b9e1b3f6b67ae2
-rw-r--r--gpsinfo.c2
-rw-r--r--makernote.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/gpsinfo.c b/gpsinfo.c
index cbf261e..0377300 100644
--- a/gpsinfo.c
+++ b/gpsinfo.c
@@ -174,7 +174,7 @@ void ProcessGpsInfo(unsigned char * DirStart, int ByteCountUnused, unsigned char
unsigned OffsetVal;
OffsetVal = Get32u(DirEntry+8);
// If its bigger than 4 bytes, the dir entry contains an offset.
- if (OffsetVal+ByteCount > ExifLength){
+ if (OffsetVal > UINT32_MAX - ByteCount || OffsetVal+ByteCount > ExifLength){
// Bogus pointer offset and / or bytecount value
ErrNonfatal("Illegal value pointer for tag %04x", Tag,0);
continue;
diff --git a/makernote.c b/makernote.c
index cf40c6b..514518d 100644
--- a/makernote.c
+++ b/makernote.c
@@ -62,7 +62,7 @@ void ProcessCanonMakerNoteDir(unsigned char * DirStart, unsigned char * OffsetBa
unsigned OffsetVal;
OffsetVal = Get32u(DirEntry+8);
// If its bigger than 4 bytes, the dir entry contains an offset.
- if (OffsetVal+ByteCount > ExifLength){
+ if (OffsetVal > UINT32_MAX - ByteCount || OffsetVal+ByteCount > ExifLength){
// Bogus pointer offset and / or bytecount value
ErrNonfatal("Illegal value pointer for tag %04x", Tag,0);
continue;