diff options
| author | cpovirk <cpovirk@google.com> | 2019-10-03 12:49:27 -0700 |
|---|---|---|
| committer | Chris Povirk <beigetangerine@gmail.com> | 2019-10-04 12:12:19 -0400 |
| commit | a8489ffa85dfab937dcc9e8d59904cefc4331f31 (patch) | |
| tree | 9e69a1543e2bae66e565a4f3a6f16e2b8653a29d | |
| parent | d4339f8f3de2a2bb903d8b1149e7d27642fda833 (diff) | |
| download | jimfs-a8489ffa85dfab937dcc9e8d59904cefc4331f31.tar.gz | |
Use AutoService as a proper annotation processor.
I was going to say that this also paves the way for including the annotation as a non-optional dependency, should we wish to follow our Guava precedent for annotations:
- https://github.com/google/guava/issues/2824
- https://github.com/google/guava/issues/2721
But I see that it's retention=SOURCE anyway, so there isn't much reason to do that -- except maybe consistency with other annotation packages someday. (Maybe it's still a negative then, as it might still let people rely on our transitive dependency?)
I think the relationship of all this to Java 11 was that I might have to set an Automatic-Module-Name on AutoService, and it makes more sense to set it after we've done the processor-vs.-annotation artifact split. Once I was upgrading, it made sense to set up the annotation processor the Right Away, now that we're using a version in which that works. (Or maybe it always worked but now it's nice that it gets the processor off the classpath?) Or maybe there was some other reason for the change to the annotation-processor setup; once again, I forget. It looks like it might have been that AutoService stops running when I switch how we run Error Prone. Hopefully this was the solution :) But it's probably a good idea in any case.
This CL is basically following the "alternatively" instructions in https://github.com/google/auto/blob/master/value/userguide/index.md#in-pomxml
...even though the AutoService instructions haven't been similarly updated yet: https://github.com/google/auto/tree/master/service#download
-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=272720556
| -rw-r--r-- | jimfs/pom.xml | 2 | ||||
| -rw-r--r-- | pom.xml | 10 |
2 files changed, 9 insertions, 3 deletions
diff --git a/jimfs/pom.xml b/jimfs/pom.xml index 85bd173..6c8f9c8 100644 --- a/jimfs/pom.xml +++ b/jimfs/pom.xml @@ -52,7 +52,7 @@ <!-- Compile-time dependencies --> <dependency> <groupId>com.google.auto.service</groupId> - <artifactId>auto-service</artifactId> + <artifactId>auto-service-annotations</artifactId> <optional>true</optional> </dependency> <dependency> @@ -86,6 +86,7 @@ <properties> <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> + <auto-service.version>1.0-rc6</auto-service.version> <java.version>1.7</java.version> <guava.version>27.0.1-android</guava.version> </properties> @@ -109,8 +110,8 @@ <!-- Compile-time dependencies --> <dependency> <groupId>com.google.auto.service</groupId> - <artifactId>auto-service</artifactId> - <version>1.0-rc3</version> + <artifactId>auto-service-annotations</artifactId> + <version>${auto-service.version}</version> </dependency> <dependency> <groupId>com.google.code.findbugs</groupId> @@ -190,6 +191,11 @@ <artifactId>guava-beta-checker</artifactId> <version>1.0</version> </path> + <path> + <groupId>com.google.auto.service</groupId> + <artifactId>auto-service</artifactId> + <version>${auto-service.version}</version> + </path> </annotationProcessorPaths> </configuration> <executions> |