From f3f62f5ec3b23823b2ce02e37bc707dc85c56461 Mon Sep 17 00:00:00 2001 From: Laura Abbott Date: Mon, 28 Sep 2015 15:39:14 -0700 Subject: depmod: Don't fall back to uname on bad version Currently, if a value that doesn't match a kernel version ("%u.%u") is passed in, depmod silently falls back to using uname. Rather than try and work around the caller passing bad data, just exit out instead. --- tools/depmod.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/depmod.c b/tools/depmod.c index 348735f..a585d47 100644 --- a/tools/depmod.c +++ b/tools/depmod.c @@ -2476,7 +2476,11 @@ static int do_depmod(int argc, char *argv[]) } } - if (optind < argc && is_version_number(argv[optind])) { + if (optind < argc) { + if (!is_version_number(argv[optind])) { + ERR("Bad version passed %s\n", argv[optind]); + goto cmdline_failed; + } cfg.kversion = argv[optind]; optind++; } else { -- cgit v1.2.3