diff options
| author | Ram Mohan M <ram.mohan@ittiam.com> | 2023-10-05 01:24:47 +0530 |
|---|---|---|
| committer | Harish Mahendrakar <harish.mahendrakar@ittiam.com> | 2023-10-04 13:51:14 -0700 |
| commit | 583887f906a432918a34c40aa58820b33b91d5a7 (patch) | |
| tree | 017de103f88e04d1a50d6ee416b9149b75bf7480 | |
| parent | a7b6206fab667ab4e719416bf6fe5960b21da8e5 (diff) | |
| download | libavc-583887f906a432918a34c40aa58820b33b91d5a7.tar.gz | |
libavc: correct return value of buf mgr avbl check util
The function returns status as success even in failed scenarios.
This is corrected.
| -rw-r--r-- | common/ih264_buf_mgr.c | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/common/ih264_buf_mgr.c b/common/ih264_buf_mgr.c index 0b5a596..061edf5 100644 --- a/common/ih264_buf_mgr.c +++ b/common/ih264_buf_mgr.c @@ -408,8 +408,7 @@ void* ih264_buf_mgr_get_next_free(buf_mgr_t *ps_buf_mgr, WORD32 *pi4_buf_id) /** ******************************************************************************* * -* @brief -* Checks the buffer manager for free buffers available. +* @brief Checks the buffer manager for free buffers available. * * @par Description: * Checks if there are any free buffers available @@ -417,22 +416,22 @@ void* ih264_buf_mgr_get_next_free(buf_mgr_t *ps_buf_mgr, WORD32 *pi4_buf_id) * @param[in] ps_buf_mgr * Pointer to the buffer manager * -* @returns Returns 0 if available, -1 otherwise +* @returns Returns IH264_SUCCESS if available, IH264_FAIL otherwise * * @remarks -* None +* none * ******************************************************************************* */ IH264_ERROR_T ih264_buf_mgr_check_free(buf_mgr_t *ps_buf_mgr) { WORD32 id; - IH264_ERROR_T ret = IH264_SUCCESS; + IH264_ERROR_T ret = IH264_FAIL; IH264_ERROR_T rettmp = IH264_SUCCESS; + rettmp = ih264_buf_mgr_lock(ps_buf_mgr); - RETURN_IF((rettmp != IH264_SUCCESS), ret); + RETURN_IF((rettmp != IH264_SUCCESS), rettmp); - ret = IH264_FAIL; for(id = 0; id < ps_buf_mgr->i4_active_buf_cnt; id++) { if((ps_buf_mgr->au4_status[id] == 0) && @@ -443,10 +442,9 @@ IH264_ERROR_T ih264_buf_mgr_check_free(buf_mgr_t *ps_buf_mgr) } } rettmp = ih264_buf_mgr_unlock(ps_buf_mgr); - RETURN_IF((rettmp != IH264_SUCCESS), ret); + RETURN_IF((rettmp != IH264_SUCCESS), rettmp); return ret; - } |