diff options
| author | Bertrand SIMONNET <bsimonnet@chromium.org> | 2015-07-22 09:34:51 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-07-22 19:31:20 +0000 |
| commit | f264b223fd6b0d3a8aa6421a5176dd2347742453 (patch) | |
| tree | c38af2052b8e1ec7088c51d04eb0508ebf952a36 | |
| parent | 336d2c323e500ae23dccfa9be827024c1772ef7c (diff) | |
| download | libbrillo-f264b223fd6b0d3a8aa6421a5176dd2347742453.tar.gz | |
libchromeos: Don't rely on the internal of std::string.
We should not rely on the fact that string copy might be done lazily.
BUG=None
TEST=`FEATURES=test emerge-gizmo libchromeos --nodeps` works.
Change-Id: Ie0a798b9be6347a715203b291d083757f8d66510
Reviewed-on: https://chromium-review.googlesource.com/287503
Trybot-Ready: Bertrand Simonnet <bsimonnet@chromium.org>
Tested-by: Bertrand Simonnet <bsimonnet@chromium.org>
Reviewed-by: Christopher Wiley <wiley@chromium.org>
Commit-Queue: Bertrand Simonnet <bsimonnet@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
| -rw-r--r-- | chromeos/http/http_connection_curl_unittest.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chromeos/http/http_connection_curl_unittest.cc b/chromeos/http/http_connection_curl_unittest.cc index 0eea0d8..06869ad 100644 --- a/chromeos/http/http_connection_curl_unittest.cc +++ b/chromeos/http/http_connection_curl_unittest.cc @@ -228,8 +228,7 @@ TEST_F(HttpCurlConnectionTest, FinishRequest) { {"X-Foo", "bar"}, }; std::unique_ptr<MockStream> response_stream(new MockStream); - EXPECT_CALL(*response_stream, WriteAllBlocking(response_data.c_str(), - response_data.size(), _)) + EXPECT_CALL(*response_stream, WriteAllBlocking(_, response_data.size(), _)) .WillOnce(Return(true)); EXPECT_CALL(*response_stream, CanSeek()) .WillOnce(Return(false)); |