diff options
| author | Bertrand SIMONNET <bsimonnet@chromium.org> | 2015-07-23 13:04:02 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-07-24 04:17:07 +0000 |
| commit | 793c7cf2dd99b07ec99dc8f057960564db3e69e5 (patch) | |
| tree | 4bd4820597782f9acda1472c20fff72b8e1ed7e6 /chromeos | |
| parent | e20603670f44d8b21874c1281ce82cd0f4bcc576 (diff) | |
| download | libbrillo-793c7cf2dd99b07ec99dc8f057960564db3e69e5.tar.gz | |
libchromeos: Fix race condition in process_test.
Running the process with Start instead of Run before checking the output
make it possible to read the output before the program exits.
BUG=None
TEST=`FEATURES=test emerge-gizmo libchromeos --nodeps` works.
Change-Id: I021b2d6d03fb8d99fd0673ed37746d23c11bf2cb
Reviewed-on: https://chromium-review.googlesource.com/287891
Trybot-Ready: Bertrand Simonnet <bsimonnet@chromium.org>
Tested-by: Bertrand Simonnet <bsimonnet@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Bertrand Simonnet <bsimonnet@chromium.org>
Diffstat (limited to 'chromeos')
| -rw-r--r-- | chromeos/process_test.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chromeos/process_test.cc b/chromeos/process_test.cc index 61d3d6e..8ecb90f 100644 --- a/chromeos/process_test.cc +++ b/chromeos/process_test.cc @@ -64,7 +64,7 @@ TEST(SimpleProcess, BindFd) { process.AddArg(kBinEcho); process.AddArg(kMsg); process.BindFd(fds[1], 1); - process.Start(); + process.Run(); memset(buf, 0, sizeof(buf)); EXPECT_EQ(read(fds[0], buf, sizeof(buf) - 1), strlen(kMsg) + 1); EXPECT_EQ(std::string(kMsg) + "\n", std::string(buf)); |