From e39c5304fcf65f80d6f0dd1cff0a4b16aa919f1d Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Thu, 28 Sep 2017 13:39:39 -0700 Subject: Use -Werror in external/libcap * Share all warning flags in libcap_defaults. Bug: 66996870 Test: build with WITH_TIDY=1 Change-Id: Ibafe6f474dc18293158b8d368ba41396a4e442ac --- Android.bp | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/Android.bp b/Android.bp index 152b85c..e6e1c66 100644 --- a/Android.bp +++ b/Android.bp @@ -12,6 +12,17 @@ // See the License for the specific language governing permissions and // limitations under the License. +cc_defaults { + name: "libcap_defaults", + cflags: [ + "-Wall", + "-Werror", + "-Wno-unused-parameter", + "-Wno-unused-result", + "-Wno-tautological-compare", + ], +} + cc_library { name: "libcap", host_supported: true, @@ -19,11 +30,7 @@ cc_library { vndk: { enabled: true, }, - - cflags: [ - "-Wno-unused-parameter", - "-Wno-tautological-compare", - ], + defaults: ["libcap_defaults"], srcs: [ "libcap/cap_alloc.c", @@ -52,10 +59,7 @@ cc_binary { srcs: ["progs/getcap.c"], - cflags: [ - "-Wno-unused-parameter", - "-Wno-tautological-compare", - ], + defaults: ["libcap_defaults"], static_libs: [ "libcap", @@ -67,10 +71,7 @@ cc_binary { srcs: ["progs/setcap.c"], - cflags: [ - "-Wno-unused-parameter", - "-Wno-tautological-compare", - ], + defaults: ["libcap_defaults"], static_libs: [ "libcap", -- cgit v1.2.3