Merge various clean-ups from upstream

The only functionality change here is to mouse scroll handling, which
won't affect Android as we don't use the library for mice. The other
changes are assorted cleanups including for variable-length array
issues, address sanitizer crashes, and various other small code issues.

Bug: 314743031
Test: Treehugger
Change-Id: I8655f873a13a9ba3b8ef437246c0c368f8bd1b76

1 files changed, 11 insertions, 11 deletions

diff --git a/src/immediate_interpreter_unittest.cc b/src/immediate_interpreter_unittest.cc
index c7c6db2..994b11c 100644
--- a/src/immediate_interpreter_unittest.cc
+++ b/src/immediate_interpreter_unittest.cc
@@ -28,31 +28,31 @@ TEST(ImmediateInterpreterTest, ScrollEventTest) {
   EXPECT_EQ(22.0, ev3.dy);
   EXPECT_EQ(33.0, ev3.dt);
 
-  ScrollEventBuffer* evbuf = new ScrollEventBuffer(2);
-  evbuf->Insert(1.0, 2.0, 3.0);
-  ev1 = evbuf->Get(0);
+  ScrollEventBuffer evbuf(2);
+  evbuf.Insert(1.0, 2.0, 3.0);
+  ev1 = evbuf.Get(0);
   EXPECT_EQ(1.0, ev1.dx);
   EXPECT_EQ(2.0, ev1.dy);
   EXPECT_EQ(3.0, ev1.dt);
-  ev1 = evbuf->Get(3);
+  ev1 = evbuf.Get(3);
   EXPECT_EQ(0.0, ev1.dx);
   EXPECT_EQ(0.0, ev1.dy);
   EXPECT_EQ(0.0, ev1.dt);
 }
 
 TEST(ImmediateInterpreterTest, HardwareStateBufferTest) {
-  HardwareStateBuffer* hsb = new HardwareStateBuffer(10);
-  hsb->Reset(0);
-  EXPECT_EQ(hsb->Size(), 10);
+  HardwareStateBuffer hsb(10);
+  hsb.Reset(0);
+  EXPECT_EQ(hsb.Size(), 10);
 }
 
 TEST(ImmediateInterpreterTest, ScrollManagerTest) {
-  PropRegistry* my_prop_reg = new PropRegistry();
-  ScrollManager* sm = new ScrollManager(my_prop_reg);
-  ScrollEventBuffer* scroll_buffer = new ScrollEventBuffer(2);
+  PropRegistry my_prop_reg;
+  ScrollManager sm(&my_prop_reg);
+  ScrollEventBuffer scroll_buffer(2);
   ScrollEvent ev;
 
-  sm->RegressScrollVelocity(*scroll_buffer, 1, &ev);
+  sm.RegressScrollVelocity(scroll_buffer, 1, &ev);
   EXPECT_EQ(0.0, ev.dx);
   EXPECT_EQ(0.0, ev.dy);
   EXPECT_EQ(1.0, ev.dt);