summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-01-10Fix findings of wvla-cxx-extensionRyan Beltran
This CL fixes occurances of the wvla-cxx-extension warning in platform/gestures. This is a newly introduced warning in Clang and existing occurances in ChromeOS break compatibility with future releases of LLVM. BUG=b:316021385 TEST=emerge-atlas chromeos-base/gestures Change-Id: If0eb2999d8a5abc3a367dc1c863d53258804d721 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5160432 Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Ryan Beltran <ryanbeltran@chromium.org> Code-Coverage: Sean O'Brien <seobrien@chromium.org> Tested-by: Ryan Beltran <ryanbeltran@chromium.org>
2023-12-13ImmediateInterpreter: fix UBSan vla-bound check failureHarry Cutts
The fs array in GetGesturingFingers could potentially be given a length of 0 (a valid value of HardwareState::finger_cnt). Allocating a zero-length array can lead to undefined behaviour in C++, so this is causing a crash due to UBSan's vla-bound check in Android. While I'm unable to reproduce the crash locally, the stack trace points to the line declaring fs, and it's the only variable-length array in the method, so I think we can be confident that this is the fix. BUG=b:315418482 TEST=On Android, run Gestures library and inputflinger tests; install the library on a device and check motions, gestures, etc. perform normally (tested on a Pixel Tablet with an Apple Magic Trackpad 1) Change-Id: If0bbe7f43ccd761f4a9cb80a55b69cb94e371ba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5106028 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Auto-Submit: Harry Cutts <hcutts@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Code-Coverage: Torsha Banerjee <torsha@google.com> Reviewed-by: Henry Barnor <hbarnor@chromium.org> Reviewed-by: Torsha Banerjee <torsha@google.com> Tested-by: Harry Cutts <hcutts@chromium.org>
2023-12-01ImmediateInterpreter: initialize prev_gesture_type_Harry Cutts
The first time SyncInterpretImpl was called after the interpreter was created, the unitialized value of prev_gesture_type_ would be loaded into memory. This often caused a Clang's undefined behaviour sanitizer (UBSan) to abort with a load-invalid-value error. BUG=b:313902875 TEST=On a Pixel Tablet, connect a touchpad and check it doesn't crash (repeat a few times) Change-Id: I8f3f588c026d71aee58a0aa5a5adbe20ad6a100a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5079347 Tested-by: Harry Cutts <hcutts@chromium.org> Reviewed-by: Sean O'Brien <seobrien@chromium.org> Commit-Queue: Sean O'Brien <seobrien@chromium.org> Auto-Submit: Harry Cutts <hcutts@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Harry Cutts <hcutts@chromium.org>
2023-11-28Disable sanitizers for x86_64 explicitlyArpit Singh
We are getting test failures on Android, to unblock upgrade of gesturelib on Android disabling sanitizers on x86_64 explicitly Test=atest libchrome-gestures_test Bug=b:311110623 Change-Id: Ie98ad1aff3a5f3d16acd58140b8d3ca86db27a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5062954 Code-Coverage: Harry Cutts <hcutts@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Reviewed-by: Pirama Arumuga Nainar <pirama@google.com> Code-Coverage: Arpit Singh <arpitks@google.com> Auto-Submit: Arpit Singh <arpitks@google.com> Commit-Queue: Harry Cutts <hcutts@chromium.org> Tested-by: Arpit Singh <arpitks@google.com>
2023-11-27Note that HardwareState::fingers can be nullHarry Cutts
BUG=b:245989146 TEST=none Change-Id: Ie80d06b0d2e05be1190c423872465d55285e9d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5056835 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Henry Barnor <hbarnor@chromium.org> Tested-by: Harry Cutts <hcutts@chromium.org> Code-Coverage: Henry Barnor <hbarnor@chromium.org> Tested-by: Arpit Singh <arpitks@google.com> Auto-Submit: Harry Cutts <hcutts@chromium.org> Reviewed-by: Henry Barnor <hbarnor@chromium.org> Reviewed-by: Arpit Singh <arpitks@google.com>
2023-11-27Disable sanitizers for x86Arpit Singh
We are getting test failures on x86 on Android, to unblock upgrade of gesturelib on Android disabling sanitizers on x86 Test=atest libchrome-gestures_test Bug=b:311110623 Change-Id: Idd1ee3683d6d787b7b08c099ce04b1b2f25b35ca Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5059091 Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Arpit Singh <arpitks@google.com> Tested-by: Arpit Singh <arpitks@google.com> Code-Coverage: Harry Cutts <hcutts@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org>
2023-11-24Avoid calling memcpy with invalid destinationArpit Singh
Deep copy of a HardwareState with zero fingers causes memcpy call to copy zero bytes to a null destination. This behaviour is undefined and UndefinedBehaviorSanitizer on Android complains about it. This change adds a check to avoid this unnecessary call. BUG=b:302505955 TEST=atest libchrome-gestures_test Change-Id: I037214e42ac9299260f4c4ed7eb09adcd5a7c06c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5054360 Commit-Queue: Harry Cutts <hcutts@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Arpit Singh <arpitks@google.com>
2023-11-16Ensure touchpad stack version is included with logsHenry Barnor
Use a pointer instead of a temporary variable to hold the touchpad stack version used to initialize the gesture library. This ensures that the touchpad stack version is automatically included when logs are generated. The temporary variable was getting destroyed when it went of scope resulting in logs not having the information. BUG=b:283179221 TEST=CQ TEST=Deployed to Brya device, confirmed in submitted feedback report. Change-Id: I57e7652891c65e747b2c983d459979f08d00539a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5015362 Reviewed-by: Sean O'Brien <seobrien@chromium.org> Tested-by: Henry Barnor <hbarnor@chromium.org> Commit-Queue: Henry Barnor <hbarnor@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-11-11fix -Wmissing-field-initializers warningsGeorge Burgess IV
Clang's -Wmissing-field-initializers now complains about missing initializers in structs init'ed using `.designators`. Fix up about 100 instances of this. BUG=b:305723283 TEST=FEATURES=test emerge-hana Change-Id: Ida87c19428aebdeee94eaf4a95f2339f8d0e63d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5014383 Commit-Queue: Henry Barnor <hbarnor@chromium.org> Reviewed-by: Henry Barnor <hbarnor@chromium.org> Tested-by: George Burgess <gbiv@chromium.org> Code-Coverage: Henry Barnor <hbarnor@chromium.org>
2023-11-02Fix visitorAdityaK
``` external/libcxx/include/variant:587:19: error: static assertion failed due to requirement 'is_invocable_v<(anonymous namespace)::Visitor (lambda at external/libchrome-gestures/src/activity_replay.cc: `std::visit` requires the visitor to be exhaustive. 587 | static_assert(is_invocable_v<_Visitor, _Values...>, ``` Test: source build/envsetup.sh lunch aosp_x86_64-userdebug cd master-plus-llvm/external/libchrome-gestures mm Bug: b/308807804 Change-Id: Ia0150688a6715370f3365ee790a8cba0b18ba38c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4996084 Auto-Submit: Aditya Kumar <appujee@google.com> Commit-Queue: Aditya Kumar <appujee@google.com> Reviewed-by: Sean O'Brien <seobrien@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Aditya Kumar <appujee@google.com>
2023-10-27Set delegate to handle changes to debug loggingseobrien
Changes to debug logging status was not being applied properly there was no delegate to handle changes to the gesture property. This CL makes sure the event debug logging property it handled. BUG=b:286851905 TEST=deploy and check that IntWasWritten is called. Change-Id: I7a9c9200e7a21c33b3076858073f9d9d18009d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4979150 Tested-by: Sean O'Brien <seobrien@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Torsha Banerjee <torsha@google.com> Commit-Queue: Sean O'Brien <seobrien@chromium.org> Code-Coverage: Torsha Banerjee <torsha@google.com> Reviewed-by: Henry Barnor <hbarnor@chromium.org>
2023-10-26ImmediateInterpreter: replace origin_timestamps_ with metricsHarry Cutts
Origin timestamps were already being collected by FingerMetrics, so removing origin_timestamps_ reduces duplication and should make it easier to separate out the tap-to-click logic later. BUG=b:245989146 TEST=run unit tests on Android; try tapping to click before and after the change, check there's no behaviour difference Change-Id: I5e0afb9e4a640b15de1255e3d3d27a9e9eb12d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4966486 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org>
2023-10-26Expose flag to report palm detected by firmware to gestures-libArpit Singh
We currently don't report palms detected by firmware to gestures-lib, this leads to situations where gesture lib consideres a touch to be lifted if its reported as palm by firmware. This can also cause unintended tap-to-click, and prevent bottom-right click from working as intended. BUG=b:302505955 TEST=atest libchrome-gestures_test Change-Id: I172af6b3d46997bfefe68b4bede5c80d522bad3d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4974106 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Arpit Singh <arpitks@google.com> Reviewed-by: Sean O'Brien <seobrien@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org>
2023-10-24gestures: Add support for differentiating BTN_SIDE and BTN_EXTRADavid Padlipsky
BUG=b:241965717 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gestures Change-Id: I65605f928f8524c9c494a8cea6432f51c084c848 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4973858 Tested-by: David Padlipsky <dpad@google.com> Commit-Queue: David Padlipsky <dpad@google.com> Reviewed-by: Sean O'Brien <seobrien@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-10-18Android.bp: sanitize tests, enable more sanitizersHarry Cutts
Since some of the unit tests are quite complex, I think it's worth enabling sanitizers for them. BUG=b:302041840 TEST=run unit tests on Android Change-Id: Id5fea00ff5e633c2d202ef539b03920c4dbf096c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4916790 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Tested-by: Harry Cutts <hcutts@chromium.org> Code-Coverage: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Siarhei Vishniakou <svv@google.com> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
2023-10-17gestures: fix ill-formed codeGeorge Burgess IV
To resolve ambiguities during overload resolution, `using V::operator()...;` is needed here in well-formed C++ code. Clang incorrectly let this code pass without diagnostics before. See discussion on https://reviews.llvm.org/D155387 for more details. BUG=b:305745122 TEST=emerge-jacuzzi gestures Change-Id: I96dc35d87a0289863adc847a158b62e6f22a655e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4944553 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: George Burgess <gbiv@chromium.org> Reviewed-by: Sean O'Brien <seobrien@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org>
2023-10-09LoggingFilterInterpreterTest: use std::tmpnamHarry Cutts
This stops a testlog.dump file from being created in the current directory when the test gets run, and makes the test pass when run on Android without an AndroidTest.xml file present (i.e. when developing off the upstream main branch without the Android-specific patch that adds it). BUG=b:245989146 TEST=run unit tests on Android Change-Id: I18f98ea60b259b8e62d522f640419c6d29a71c7f Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4915780 Commit-Queue: Torsha Banerjee <torsha@google.com> Auto-Submit: Harry Cutts <hcutts@chromium.org> Commit-Queue: Henry Barnor <hbarnor@chromium.org> Code-Coverage: Henry Barnor <hbarnor@chromium.org> Reviewed-by: Torsha Banerjee <torsha@google.com> Reviewed-by: Henry Barnor <hbarnor@chromium.org> Tested-by: Harry Cutts <hcutts@chromium.org>
2023-10-04ImmediateInterpreter: parameterize TapToClickEnableTestHarry Cutts
Making this a parameterized test makes it a bit clearer what's going on, and allows us to make a couple of other simplifications, like removing the need to reset the interpreter mid-test. BUG=b:245989146 TEST=run the unit tests on Android; break some expectations and check the failure messages include context (index and test mode) Change-Id: Ia87e671a7ee6ad2101ccaa61762c50255b6a4f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4908032 Reviewed-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: William Mahon <wmahon@google.com> Tested-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org>
2023-09-26Tidy up HardwareProperties literals in unit testsHarry Cutts
Specifically: * Use field names in the initializers themselves, rather than comments labelling each value * This reduces the chance of a value getting put in the wrong field by mistake, and allows us to omit values for the points below * Remove initialization of deprecated screen_x_dpi and screen_y_dpi fields, except in the activity log tests (where we still want to check they're recorded correctly) * Add default values of 0 for the left and top fields, which allows them to be omitted in most of the literals * Add a common constant in the metrics interpreter tests, since they all use the same values and they're not referenced in assertions etc. BUG=b:245989146 TEST=run unit tests Change-Id: Ic1f09aa9f08db914eeb3fdbbbec72ef9f2b90f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4874371 Commit-Queue: Harry Cutts <hcutts@chromium.org> Tested-by: Harry Cutts <hcutts@chromium.org> Reviewed-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20Remove redundant ActivityLog key string constantsDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture LOW_COVERAGE_REASON=activity_replay is unit test code only Change-Id: I68941312f4bd909c9221a3fa3c3c051adc099d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4834762 Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Denis Brockus <dbrockus@chromium.org>
2023-09-20Add ability to limit activity event debug loggingDenis Brockus
Instead of having a master switch to turn on event debug logging, I believe due to the static limitations of the buffer that having the ability to reduce to only what you want to see, as an option, makes sense. The event debugging is reduced to // Base Event Types Gesture, HardwareState, HandleTimer // FilterInterpreter Debug Event Types Accel, Box, ClickWiggle, FingerMerge, FlingStop, HapticButtonGenerator, Iir, IntegratGesture, Logging, Lookahead, Metrics, NonLinearity, PalmClassifying, Scaling, SensorJump, SplitCorrecting, StationaryWiggle, StuckButtonInhibitor, T5R2Correcting, Timestamp, TrendClassifying, // Interpreter Debug Event Types ImmediateInterpreter, MouseInterpreter, MultitouchMouseInterpreter, NOTE: As of this CL, all of the Base Event Type options are implemented but the other Debug Event Types only exist for Accel and Timestamp. Since this is being added as a framework, I included the others so when/if they are added they will have been consistently included. BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I620873bcdc5f7533c6aa635c503dd2e37693c057 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4798937 Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20HapticButtonGeneratorFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I7a54f1b14104704b4a6c146c7d97c33f3f7ec052 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789379 Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20T5R2FilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Id192cbde1831a3e9059494611e25b1f5282efd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789378 Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20SplitCorrectingFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I9d6b484861f5a5b59d0894e75afd918ecb787293 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789377 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org>
2023-09-20SensorJumpFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Icaa1331cef5828048e3867bf4b94380fd06ad1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789376 Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20NonLinearityFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Idec1bfca65e5966690b6ffdbdfa4151dda7e40a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789375 Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20MultitouchMouseInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Ia98bc7b901ab4362cb170dc4163e281c27a8d0df Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789374 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org>
2023-09-20MouseInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I7e3c473404997d3f4535a318250f1c6a2c189b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789373 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org>
2023-09-20Add MouseInterpreter emulate scroll wheel for code coverageDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I62d993a998997e78f45a3745160a3fffc94df707 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4873791 Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20IntegralGestureFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I47a63a33a18c2ff12e5bdd33ebb8406fd825cfe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789372 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org>
2023-09-20IirFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Id00e785353de47d5392e103b6ec10d3e2b909524 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4789371 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20StuckButtonInhibitorFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I943689d387bf4f7fae086e47555583d1828171f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775272 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Denis Brockus <dbrockus@chromium.org>
2023-09-20FingerMergeFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Id43b91fb9d3fc44856bd220a289c0aea3a533c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775271 Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20ScalingFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Ifabe5cbb98417b28e3a8b8d4731d83cbcf5d2ab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775270 Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
2023-09-20MetricsFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I1d2affd9e69e82b381bd1e26011f16becfce000a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775269 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
2023-09-20TrendClassifyingFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I3e00c9ad0e726ef166198d9c0ffb550d51d1ec0b Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775268 Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20StationaryWiggleFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I86689aed93ce5b5a093acd95871bd85f93bb998e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775267 Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20BoxFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Iabeafc7a415ce80676ccb2bb994c196bedb7058e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775266 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
2023-09-20Add BoxFilterInterpreter::ZeroSizeBoxTest for coverageDenis Brockus
Change-Id: I89655ee23401c4874007f0db1065dc9af0bd99e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4873790 Tested-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org>
2023-09-20LookaheadFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: If524a867dfd4f102e4f61663f0777ecd9ecd3a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775265 Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Harry Cutts <hcutts@chromium.org>
2023-09-20Add LookaheadFilterInterpreter code coverageDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I8a4daeb48be471f565bab8bf963da629075c1289 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4874991 Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20PalmClassifyingFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I27034c7cef1b5a7974f79b4ef982ac88841183a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775264 Tested-by: Denis Brockus <dbrockus@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Harry Cutts <hcutts@chromium.org>
2023-09-20ClickWiggleFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I76e340ad3fee2dfedc72ed52d038307fe07247bd Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4775263 Tested-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org>
2023-09-20TimestampFilterInterpreter instrument TimestampHardwareStateDebug debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Ic81559e4a26a677db22210d9be7da7242a52a9e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4711255 Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Henry Barnor <hbarnor@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Denis Brockus <dbrockus@chromium.org>
2023-09-20TimestampFilterInterpreter instrument TimestampGestureDebug debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I19467fa5c7381eae7c98c1646e9dc0f20969ce0e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4769604 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20TimestampFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I2f0ad2f6fb8c4421a87a065873b5926ae5cc79f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4769603 Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Harry Cutts <hcutts@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org>
2023-09-20AccelFilterInterpreter instrument AccelGestureDebug debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: If596af9417b625247b2113841bd03e2f4acc1aab Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4769602 Reviewed-by: Harry Cutts <hcutts@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com> Tested-by: Denis Brockus <dbrockus@chromium.org>
2023-09-20FlingStopFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: Ie4fcd9c8078de86ed7c2484a3035998761d9cc8c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4765973 Commit-Queue: Denis Brockus <dbrockus@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Sean O'Brien <seobrien@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20ImmediateInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I8c579f423a668903397096f00b4b1ef8d3792c35 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4766264 Reviewed-by: Henry Barnor <hbarnor@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Sean O'Brien <seobrien@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
2023-09-20AccelFilterInterpreter instrument event debugDenis Brockus
BUG=b:286851905 TEST=USE="coverage" FEATURES="test noclean" emerge-brya chromeos-base/gesture Change-Id: I0f0c00bc04d1520036f02b55a7ac1292a8429f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/4765971 Reviewed-by: Sean O'Brien <seobrien@chromium.org> Commit-Queue: Denis Brockus <dbrockus@chromium.org> Reviewed-by: Henry Barnor <hbarnor@chromium.org> Tested-by: Denis Brockus <dbrockus@chromium.org> Code-Coverage: Zoss <zoss-cl-coverage@prod.google.com>
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-12 00:42:37 +0000