From d2ec17e2817001e97841fbab6da708a4183da4e1 Mon Sep 17 00:00:00 2001 From: Harry Cutts Date: Fri, 1 Dec 2023 14:25:03 +0000 Subject: ImmediateInterpreter: initialize prev_gesture_type_ The first time SyncInterpretImpl was called after the interpreter was created, the unitialized value of prev_gesture_type_ would be loaded into memory. This often caused a Clang's undefined behaviour sanitizer (UBSan) to abort with a load-invalid-value error. BUG=b:313902875 TEST=On a Pixel Tablet, connect a touchpad and check it doesn't crash (repeat a few times) Change-Id: I8f3f588c026d71aee58a0aa5a5adbe20ad6a100a Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/gestures/+/5079347 Tested-by: Harry Cutts Reviewed-by: Sean O'Brien Commit-Queue: Sean O'Brien Auto-Submit: Harry Cutts Code-Coverage: Zoss Commit-Queue: Harry Cutts --- src/immediate_interpreter.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/immediate_interpreter.cc b/src/immediate_interpreter.cc index 2f793cb..00d8b16 100644 --- a/src/immediate_interpreter.cc +++ b/src/immediate_interpreter.cc @@ -1000,6 +1000,7 @@ ImmediateInterpreter::ImmediateInterpreter(PropRegistry* prop_reg, last_movement_timestamp_(-1.0), swipe_is_vertical_(false), current_gesture_type_(kGestureTypeNull), + prev_gesture_type_(kGestureTypeNull), state_buffer_(8), scroll_buffer_(20), pinch_guess_start_(-1.0), -- cgit v1.2.3