diff options
author | Ari Hausman-Cohen <arihc@google.com> | 2015-08-21 16:28:54 -0700 |
---|---|---|
committer | Ari Hausman-Cohen <arihc@google.com> | 2015-08-21 16:28:54 -0700 |
commit | edc31d6f4bfbbff9efd44c7dc6e4be04d91fc05a (patch) | |
tree | 3e4e530218b24478a8e5bc3d6ab1c6beadb2390d /base | |
parent | db7c5941371d7639578632d11f31fa6698198c36 (diff) | |
download | libchrome-edc31d6f4bfbbff9efd44c7dc6e4be04d91fc05a.tar.gz |
Disabling SecurityTest.CallocOverflow
CallocOverflow test has some difficult issues preventing it from passing.
See b/23428680. Disabling it until these issues are addressed.
BUG: 23428680, 22884411
Change-Id: Ie254ae63e9cb61ff4a575ee0369bff8e85dbe29c
Diffstat (limited to 'base')
-rw-r--r-- | base/security_unittest.cc | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/base/security_unittest.cc b/base/security_unittest.cc index 07ba6f5a0f..1cff1b44ed 100644 --- a/base/security_unittest.cc +++ b/base/security_unittest.cc @@ -109,8 +109,10 @@ bool IsTcMallocBypassed() { bool CallocDiesOnOOM() { // The sanitizers' calloc dies on OOM instead of returning NULL. -// The wrapper function in base/process_util_linux.cc that is used when we -// compile without TCMalloc will just die on OOM instead of returning NULL. +// The wrapper function in base/process/memory_linux.cc that is used when we +// compile without TCMalloc will just die on OOM instead of returning NULL, +// but the wrapper only works with glibc, and the file is not currently +// included in the libchrome build. #if defined(ADDRESS_SANITIZER) || \ defined(MEMORY_SANITIZER) || \ defined(THREAD_SANITIZER) || \ @@ -299,7 +301,8 @@ bool CallocReturnsNull(size_t nmemb, size_t size) { } // Test if calloc() can overflow. -TEST(SecurityTest, CallocOverflow) { +// Currently disabled, see b/23428680 +TEST(SecurityTest, DISABLED_CallocOverflow) { const size_t kArraySize = 4096; const size_t kMaxSizeT = numeric_limits<size_t>::max(); const size_t kArraySize2 = kMaxSizeT / kArraySize + 10; |