diff options
author | Monica Salama <msalama@google.com> | 2019-04-25 20:10:38 +0900 |
---|---|---|
committer | Qijiang Fan <fqj@google.com> | 2020-06-05 12:53:13 +0900 |
commit | ff7553f0a9601c4308159336141066c78dce8e5e (patch) | |
tree | ed38c611c7ed4ed19ea6c8573e0fc6f3187c1c33 /base | |
parent | 57ffe63de2eb808f925a94e037ff8818fedfa512 (diff) | |
download | libchrome-ff7553f0a9601c4308159336141066c78dce8e5e.tar.gz |
Orderfile: Added performance and memory evaluation to the orderfile pipeline
After the generation of the new orderfile, we build two non-instrumented
version of chrome with and without orderfile. We then run benchmarks on each
build. Speedometer2.0 is used to assess the performance. For memory, we
created orderfile.memory_mobile to evaluate the native code memory footprint.
The results are then added to the JSON output.
Bug: 947012
Change-Id: If316e63ef1a50a6d9a6ef0c97200d36035e7640d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543489
Commit-Queue: Monica Basta <msalama@google.com>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Hector Dearman <hjd@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#653978}
CrOS-Libchrome-Original-Commit: 90b8f5b93d432e183a6c18c290d778a282ed14bd
Diffstat (limited to 'base')
-rw-r--r-- | base/android/library_loader/library_prefetcher.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/base/android/library_loader/library_prefetcher.cc b/base/android/library_loader/library_prefetcher.cc index 044964d8b0..2c34cabccd 100644 --- a/base/android/library_loader/library_prefetcher.cc +++ b/base/android/library_loader/library_prefetcher.cc @@ -167,7 +167,7 @@ void DumpResidency(size_t start, } // First line: start-end of text range. - CHECK(IsOrderingSane()); + CHECK(AreAnchorsSane()); CHECK_LE(start, kStartOfText); CHECK_LE(kEndOfText, end); auto start_end = base::StringPrintf("%" PRIuS " %" PRIuS "\n", @@ -297,7 +297,7 @@ int NativeLibraryPrefetcher::PercentageOfResidentCode(size_t start, // static int NativeLibraryPrefetcher::PercentageOfResidentNativeLibraryCode() { - if (!IsOrderingSane()) { + if (!AreAnchorsSane()) { LOG(WARNING) << "Incorrect code ordering"; return -1; } @@ -336,7 +336,7 @@ void NativeLibraryPrefetcher::MadviseForOrderfile() { // static void NativeLibraryPrefetcher::MadviseForResidencyCollection() { - if (!IsOrderingSane()) { + if (!AreAnchorsSane()) { LOG(WARNING) << "Code not ordered, cannot madvise"; return; } |