diff options
| author | Ken Rockot <rockot@chromium.org> | 2017-05-13 05:41:44 +0900 |
|---|---|---|
| committer | Qijiang Fan <fqj@google.com> | 2020-06-05 06:06:26 +0900 |
| commit | bf4c1240c5fb56539a9d4dde8f3d9b3b80b66428 (patch) | |
| tree | 069da4ed7ead229f13bc106bf9aeb27ce4edcc2c /mojo/public/tools/bindings/blink_bindings_configuration.gni | |
| parent | a20021a57c99f5d10183176b8683412448480add (diff) | |
| download | libchrome-bf4c1240c5fb56539a9d4dde8f3d9b3b80b66428.tar.gz | |
Revert "[reland] Support generation of component targets for Mojom C++ bindings"
This reverts commit a999f951a26f1fece78238836b198999b0050ae6.
Reason for revert: Still breaking many tests due to shared libraries missing from isolates. https://crbug.com/720241
Original change's description:
> [reland] Support generation of component targets for Mojom C++ bindings
>
> NOTE: Reland of https://chromium-review.googlesource.com/c/497830/,
> with component dependency fixed. Variant components needed to depend
> on the shared component. This also means struct *_Data classes need
> to be exported, which in turn required moving all their method
> definitions out-of-line. Furthermore, automatically generated shared
> components (when using export_* parameters) need to be unique, so
> this allows component_output_prefix to be set on such targets as well.
>
> This allows developers to force the mojom GN template to emit a
> component target for C++ bindings rather than a source_set and updates
> some existing uses of the export_class_attribute etc parameters to use
> explicit component generation instead.
>
> This is a step towards using mojom component targets by default, but
> that is currently impossible without additional GN support.
>
> BUG=718098
> TBR=jam@chromium.org
> TBR=yzshen@chromium.org
>
> Change-Id: I22e58a9fad78cc1fc40b23067d942082a4b14c0c
> Reviewed-on: https://chromium-review.googlesource.com/504707
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Commit-Queue: Ken Rockot <rockot@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#471334}
TBR=jam@chromium.org,rockot@chromium.org,yzshen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=718098
Change-Id: I4717fb0f9c8a7f52fc863d0ecfc2450b92ca9c76
Reviewed-on: https://chromium-review.googlesource.com/505093
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#471438}
CrOS-Libchrome-Original-Commit: bcce6e40e5649f1d5d2485a49c91212e97e3851a
Diffstat (limited to 'mojo/public/tools/bindings/blink_bindings_configuration.gni')
| -rw-r--r-- | mojo/public/tools/bindings/blink_bindings_configuration.gni | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/mojo/public/tools/bindings/blink_bindings_configuration.gni b/mojo/public/tools/bindings/blink_bindings_configuration.gni index 36e9fdabdf..bb0fc432a3 100644 --- a/mojo/public/tools/bindings/blink_bindings_configuration.gni +++ b/mojo/public/tools/bindings/blink_bindings_configuration.gni @@ -31,4 +31,3 @@ foreach(typemap, _typemaps) { } blacklist = [] -component_macro_suffix = "_BLINK" |