diff options
Diffstat (limited to 'base/trace_event/memory_allocator_dump_unittest.cc')
-rw-r--r-- | base/trace_event/memory_allocator_dump_unittest.cc | 25 |
1 files changed, 15 insertions, 10 deletions
diff --git a/base/trace_event/memory_allocator_dump_unittest.cc b/base/trace_event/memory_allocator_dump_unittest.cc index 85b98d6551..d1cfe91a4f 100644 --- a/base/trace_event/memory_allocator_dump_unittest.cc +++ b/base/trace_event/memory_allocator_dump_unittest.cc @@ -4,6 +4,8 @@ #include "base/trace_event/memory_allocator_dump.h" +#include <stdint.h> + #include "base/format_macros.h" #include "base/strings/stringprintf.h" #include "base/trace_event/memory_allocator_dump_guid.h" @@ -12,6 +14,7 @@ #include "base/trace_event/process_memory_dump.h" #include "base/trace_event/trace_event_argument.h" #include "base/values.h" +#include "build/build_config.h" #include "testing/gtest/include/gtest/gtest.h" namespace base { @@ -21,13 +24,14 @@ namespace { class FakeMemoryAllocatorDumpProvider : public MemoryDumpProvider { public: - bool OnMemoryDump(ProcessMemoryDump* pmd) override { + bool OnMemoryDump(const MemoryDumpArgs& args, + ProcessMemoryDump* pmd) override { MemoryAllocatorDump* root_heap = pmd->CreateAllocatorDump("foobar_allocator"); root_heap->AddScalar(MemoryAllocatorDump::kNameSize, MemoryAllocatorDump::kUnitsBytes, 4096); - root_heap->AddScalar(MemoryAllocatorDump::kNameObjectsCount, + root_heap->AddScalar(MemoryAllocatorDump::kNameObjectCount, MemoryAllocatorDump::kUnitsObjects, 42); root_heap->AddScalar("attr1", "units1", 1234); root_heap->AddString("attr2", "units2", "string_value"); @@ -37,7 +41,7 @@ class FakeMemoryAllocatorDumpProvider : public MemoryDumpProvider { pmd->CreateAllocatorDump("foobar_allocator/sub_heap"); sub_heap->AddScalar(MemoryAllocatorDump::kNameSize, MemoryAllocatorDump::kUnitsBytes, 1); - sub_heap->AddScalar(MemoryAllocatorDump::kNameObjectsCount, + sub_heap->AddScalar(MemoryAllocatorDump::kNameObjectCount, MemoryAllocatorDump::kUnitsObjects, 3); pmd->CreateAllocatorDump("foobar_allocator/sub_heap/empty"); @@ -81,7 +85,7 @@ void CheckString(const MemoryAllocatorDump* dump, void CheckScalar(const MemoryAllocatorDump* dump, const std::string& name, const char* expected_units, - uint64 expected_value) { + uint64_t expected_value) { CheckString(dump, name, MemoryAllocatorDump::kTypeScalar, expected_units, StringPrintf("%" PRIx64, expected_value)); } @@ -124,9 +128,10 @@ TEST(MemoryAllocatorDumpTest, GuidGeneration) { TEST(MemoryAllocatorDumpTest, DumpIntoProcessMemoryDump) { FakeMemoryAllocatorDumpProvider fmadp; - ProcessMemoryDump pmd(make_scoped_refptr(new MemoryDumpSessionState())); + ProcessMemoryDump pmd(new MemoryDumpSessionState(nullptr, nullptr)); + MemoryDumpArgs dump_args = {MemoryDumpLevelOfDetail::DETAILED}; - fmadp.OnMemoryDump(&pmd); + fmadp.OnMemoryDump(dump_args, &pmd); ASSERT_EQ(3u, pmd.allocator_dumps().size()); @@ -136,7 +141,7 @@ TEST(MemoryAllocatorDumpTest, DumpIntoProcessMemoryDump) { EXPECT_EQ("foobar_allocator", root_heap->absolute_name()); CheckScalar(root_heap, MemoryAllocatorDump::kNameSize, MemoryAllocatorDump::kUnitsBytes, 4096); - CheckScalar(root_heap, MemoryAllocatorDump::kNameObjectsCount, + CheckScalar(root_heap, MemoryAllocatorDump::kNameObjectCount, MemoryAllocatorDump::kUnitsObjects, 42); CheckScalar(root_heap, "attr1", "units1", 1234); CheckString(root_heap, "attr2", MemoryAllocatorDump::kTypeString, "units2", @@ -149,7 +154,7 @@ TEST(MemoryAllocatorDumpTest, DumpIntoProcessMemoryDump) { EXPECT_EQ("foobar_allocator/sub_heap", sub_heap->absolute_name()); CheckScalar(sub_heap, MemoryAllocatorDump::kNameSize, MemoryAllocatorDump::kUnitsBytes, 1); - CheckScalar(sub_heap, MemoryAllocatorDump::kNameObjectsCount, + CheckScalar(sub_heap, MemoryAllocatorDump::kNameObjectCount, MemoryAllocatorDump::kUnitsObjects, 3); const MemoryAllocatorDump* empty_sub_heap = pmd.GetAllocatorDump("foobar_allocator/sub_heap/empty"); @@ -159,7 +164,7 @@ TEST(MemoryAllocatorDumpTest, DumpIntoProcessMemoryDump) { DictionaryValue* attrs = nullptr; ASSERT_TRUE(raw_attrs->GetAsDictionary(&attrs)); ASSERT_FALSE(attrs->HasKey(MemoryAllocatorDump::kNameSize)); - ASSERT_FALSE(attrs->HasKey(MemoryAllocatorDump::kNameObjectsCount)); + ASSERT_FALSE(attrs->HasKey(MemoryAllocatorDump::kNameObjectCount)); // Check that the AsValueInfo doesn't hit any DCHECK. scoped_refptr<TracedValue> traced_value(new TracedValue()); @@ -170,7 +175,7 @@ TEST(MemoryAllocatorDumpTest, DumpIntoProcessMemoryDump) { #if !defined(NDEBUG) && !defined(OS_ANDROID) && !defined(OS_IOS) TEST(MemoryAllocatorDumpTest, ForbidDuplicatesDeathTest) { FakeMemoryAllocatorDumpProvider fmadp; - ProcessMemoryDump pmd(make_scoped_refptr(new MemoryDumpSessionState())); + ProcessMemoryDump pmd(new MemoryDumpSessionState(nullptr, nullptr)); pmd.CreateAllocatorDump("foo_allocator"); pmd.CreateAllocatorDump("bar_allocator/heap"); ASSERT_DEATH(pmd.CreateAllocatorDump("foo_allocator"), ""); |