Age | Commit message (Collapse) | Author |
|
trace_event is a feature to measure profiling.
However, it won't be usable in standard library like libchrome,
so remove it.
For build compatibility, small stub and trace_event_common.h
are kept.
Bug: 80375012
Test: Built locally.
Change-Id: Ie2a87d2fa0d3cdbd856044498d0dd2072da2e9ab
|
|
Bug: 73270448
Test: Built locally. Treehugger.
Change-Id: I2c3f193e1677e4a673ab0b3b60c0c3b40a57987b
|
|
libchrome contained unused files. This CL removes them.
- BUILD.gn
Currently gn is not used. We're working on it (in ChromeOS build),
but not a few files are dropped, so we need to revisit here later.
- ios, win specific files.
- base/i18n/. It only contains base_i18n_export.h, which is not used.
- base/trace_event/etw_manifest/. It is for win.
Bug: 73270448
Test: Built locally. Treehugger.
Change-Id: I5c59af648573f3b670f380e3263c456eec296af7
|
|
Since C++11, we have concrete semantics.
Thus, we rely on it.
Note that, we still need to keep LAZY_INSTANCE_INITIALIZER
because it is a macro used in other project, which may
have missing-field-initializers warning enabled.
Bug: 73270448
Test: Built locally. Treehugger.
Change-Id: Ieb59b25c2936d27c3501d21098b248fac2778f0a
|
|
Previous uprevs didn't include several CLs. This re-uprev's to the
r462023.
cf) Missing CLs I found.
https://codereview.chromium.org/2556563002
https://codereview.chromium.org/2754483002
https://codereview.chromium.org/2171833002
https://codereview.chromium.org/2778183003
https://codereview.chromium.org/2500473002
https://codereview.chromium.org/2173523002
https://codereview.chromium.org/2666423002
https://codereview.chromium.org/2723423002
https://codereview.chromium.org/2789463002
https://codereview.chromium.org/2723083004
https://codereview.chromium.org/2637843002
https://codereview.chromium.org/2785943004
https://codereview.chromium.org/2657603004
https://codereview.chromium.org/2774363003
https://codereview.chromium.org/2776853002
https://codereview.chromium.org/2736053003
https://codereview.chromium.org/2779413002
https://codereview.chromium.org/2782503002
https://codereview.chromium.org/2782083003
https://codereview.chromium.org/2399213005
https://codereview.chromium.org/2787383002
https://codereview.chromium.org/2790523004
https://codereview.chromium.org/2787533002
https://codereview.chromium.org/2780983003
https://codereview.chromium.org/2790403003
https://codereview.chromium.org/2747673002
https://codereview.chromium.org/2778173003
https://codereview.chromium.org/2788613004
https://codereview.chromium.org/2781983003
https://codereview.chromium.org/2774223003
Bug: 73270448
Test: Built and ran libchrome_test locally. Run treehugger.
Change-Id: I5e76096d4fcf660571275cce5f4a980a8bb574fe
|
|
libchrome used to hit unused-parameter warning. Now, libchrome is built
with -Wno-unused-parameter flag, and its client libraries/executables
are built with the header files containing pragma to suppress the warning
from libchrome.
Thus, the modification can be removed to reduce the diff from
Chrome upstream.
Bug: 73270448
Test: Built locally. Treehugger.
Change-Id: I51b6349bfdb28ed15df1d12b836adccffabe53bb
|
|
Now libchrome is built with -Wunused-parameter, so we no longer
need the macro.
Bug: 73270448
Test: Built locally. Treehugger.
Change-Id: Ie02279df60b26f78019e28d383c50084695fb07a
|
|
This merge was done against r462023 which corresponds to git commit
32eb7c31af9cab6231f0d3d05206072079177605 from Apr 05, 2017
First attempt, in commit bf8c17f71511c1e90cd8cccfe71f0852c566bd3b was
badly squashed, causing automated test failure in system/bt.
Next one broke mac build.
Test: manually ran all test from system/bt that failed on previous
attempt, plus libchrome_unittest
Change-Id: I60003263418de3078c7be2da9fb1eeaeb786f3d0
|
|
This reverts commit fe2f52931e8e50253d06329d7bf0a4164c7ba580.
Reason for revert: Mac build broken
Change-Id: I3abd2ba6874ec5bd283ba17c36ad0b35bcc3d374
|
|
This reverts commit 1c01c739718e65746f393b405a2bf97ce4cf8523.
Reason for revert: Mac build broken (required for merge conflicts).
Change-Id: Ibc4d6e69095ddd320e9e9814daa1a3a0cb11609f
|
|
Change-Id: Ice279534e47d6edccc8baf2ab62744f3e74f04e8
|
|
This merge was done against r462023 which corresponds to git commit
32eb7c31af9cab6231f0d3d05206072079177605 from Apr 05, 2017
Previous attempt, in commit bf8c17f71511c1e90cd8cccfe71f0852c566bd3b was
badly squashed, causing automated test failure in system/bt.
Test: manually ran all test from system/bt that failed on previous
attempt, plus libchrome_unittest
Change-Id: I539a868af1d06baad3e80a89b8c16fb3d86ab77a
|
|
This reverts commit bf8c17f71511c1e90cd8cccfe71f0852c566bd3b.
Reason for revert: https://buganizer.corp.google.com/issues/70858501
Change-Id: Iedb1193d46ea2211f8b6fdace41902ad8df6d754
|
|
This merge was done against r462023 which corresponds to git commit
32eb7c31af9cab6231f0d3d05206072079177605 from Apr 05, 2017
Change-Id: I70bf77fcb3215da3e17f997752bfdad7d4e6e1c9
|
|
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r456626 which corresponds to git commit
08266b3fca707804065a2cfd60331722ade41969 of Mar 14, 2017
Notable changes are:
- FOR_EACH_OBSERVER macro removed (replaced by use of C++ 11
range-base for loop)
- base::Values no more FundamentalValue
- stl_util moved to base namespace
- some scoped pointers removed in crypto/ in favor
of BoringSSL UniquePtr.
- path() accessor renamed to GetPath() in ScopedTempDir (and other
classes)
- introduction of base::CallbackOnce
Test: All unit-tests should still pass.
Change-Id: I1e65efb167fa708e35ed7c6492f1cb66a6a46104
Merged-In: I180f9defc7607f462389fae17701fff553c4a2d0
|
|
This reverts commit 0601274935e7f632eb0d6ce0fd223b744349d20b.
Reason for revert: Broke the mac_sdk
Exempt-From-Owner-Approval: Fixing mac_sdk
Change-Id: I2cab1818261f3b75dcf7dfc3edf6d6b7bab541a8
|
|
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r456626 which corresponds to git commit
08266b3fca707804065a2cfd60331722ade41969 of Mar 14, 2017
Notable changes are:
- FOR_EACH_OBSERVER macro removed (replaced by use of C++ 11
range-base for loop)
- base::Values no more FundamentalValue
- stl_util moved to base namespace
- some scoped pointers removed in crypto/ in favor
of BoringSSL UniquePtr.
- path() accessor renamed to GetPath() in ScopedTempDir (and other
classes)
- introduction of base::CallbackOnce
Test: All unit-tests should still pass.
Change-Id: I5c2cb41ea4c037fe69fbb425e711b1399d55d591
|
|
Upstream files should be updated and approved upstream.
Bug: 33166666
Test: default build targets
Change-Id: Id9156f1001f3c28224b42f07fdad43dc48f6c042
|
|
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r405848 which corresponds to git commit
909e5d3ecab27bb09cc570c1c215d0221bd6fe53 of Jul 15, 2016
Notable changes are:
- base::Bind() now explicitly disallows captures in lambdas (which was
never allowed in the style guide).
- base::ListValue::iterator now exposes std::unique_ptr<base::Value>
instead of raw base::Value*.
BUG: 29104761
TEST: All tests in libchrome_test pass on dragonboard-eng build
Change-Id: I94b285a3be074efa30c4e71ae93c8f2a99fb0b87
|
|
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r395517 which corresponds to git commit
ebdcb576bb346af95b8ad219f6250daf63122f98 of May 23, 2016
Notable changes are:
- scoped_ptr was removed in favor of std::unique_ptr
- base/thread_task_runner_handle.h was moved to base/threading.
BUG: 28985443
TEST: All tests in libchrome_test pass on dragonboard-eng build
Change-Id: Ic9f9ed1cafe754c96cd2f007984514e091aaba39
|
|
TEST=Build all
Change-Id: I962a83a044a102515c316d04bb65e7c9302e0f0c
|
|
The recent uprev attempt missed a couple Mac-specific files.
Adding them now.
Also, there were some other build breaks in Mac files.
Particularly, had to revert the uprev change to the following file
base/message_loop/message_pump_mac.mm because the change relied
on base::mac::CallWithEHFrame() which was implemented in assembly
and didn't compile on 32 bit platform. So, I have removed the
change introduced with https://codereview.chromium.org/1212093002
on Chromium side.
Change-Id: Ic78acbb22732e64965f99ce31bc8382f228e22bb
|
|
Pulled the latest and greatest version of libchrome from Chromium.
The merge was done against r369476 which corresponds to git commit
0471d0e2e2ef4a544a63481a389e1df33ea7c00a of Jan 14, 2016
Notable changes are:
- base::scoped_ptr<T> is now almost identical to std::unique_ptr<T>
No Pass() method, now std::move() is used on scoped pointers
- basictypes.h is removed and custom int types such as int32 are now
replaced with the standard int32_t and similar from <stdint.h>
- String utility functions are cleaned up/refactored. Now all are in
base:: namespace, many now return values rather than take pointers
for results, ambiguous Booleans are replaced with enums, such as:
base::StartsWithASCII(current_url, "https://", false);
now is:
base::StartsWith(current_url, "https://",
base::CompareCase::INSENSITIVE_ASCII);
- COMPILE_ASSERT() is now replaced with standard static_assert()
- Numeric range constants such as kuint64max are removed in favor of
standard <limits> constructs such as std::numeric_limits<uint64_t>::max()
- base::Value and derived classes use scoped_ptr<> more and support
for raw pointers to base::Value is deprecated and/or removed in
many places.
- base::MessageLoopProxy is completely removed (was marked deprecated before)
- base::MessageLoop::Quit() and QuitClosure are renamed to QuitWhenIdle
and QuitWhenIdleClosure for more semantic clarity.
Change-Id: I1f5436d253a0a32b2299160a76993752d818736f
|
|
In order to help with uprev maintenance, remove all the source files
that are not being built on AOSP/ChromeOS
Change-Id: Iec3221ae8aa02a17326949085b33925382968673
|
|
Bug: 26228533
Test: libchrome builds under clang and gcc with this change
Change-Id: Ie534056c7557652fbbd7c2a134131d1cd25824e5
|
|
This reverts commit b636ff6a8ac3b54b3067289f01848252ab71eceb.
This broke trunk with messages like:
In file included from external/libchrome/base/time/time_posix.cc:29:0:
external/libchrome/base/lazy_instance.h:51:36: error: missing initializer for member 'base::LazyInstance<base::Lock, base::internal::LeakyLazyInstanceTraits<base::Lock> >::private_instance_' [-Werror=missing-field-initializers]
#define LAZY_INSTANCE_INITIALIZER {}
^
external/libchrome/base/time/time_posix.cc:39:38: note: in expansion of macro 'LAZY_INSTANCE_INITIALIZER'
g_sys_time_to_time_struct_lock = LAZY_INSTANCE_INITIALIZER;
^
external/libchrome/base/lazy_instance.h:51:36: error: missing initializer for member 'base::LazyInstance<base::Lock, base::internal::LeakyLazyInstanceTraits<base::Lock> >::private_buf_' [-Werror=missing-field-initializers]
#define LAZY_INSTANCE_INITIALIZER {}
^
external/libchrome/base/time/time_posix.cc:39:38: note: in expansion of macro 'LAZY_INSTANCE_INITIALIZER'
g_sys_time_to_time_struct_lock = LAZY_INSTANCE_INITIALIZER;
^
cc1plus: all warnings being treated as errors
Change-Id: I0c0308e716bd1ed7914e2a032e439a9261d38e56
|
|
Also fix compiler warnings in unit tests, except for unused parameter.
There are a ton of unused parameters in unit tests, and those errors
have no risk of spreading through the platform.
Bug: 26228533
Test: libchrome builds, unittests pass
Change-Id: I50431c8e143902c4b71b4381e4dbbc67cdc4507c
|
|
This is an outdated library that added support for thread/memory safety
annotations before clang was extended to support the same. We don't
run those tools on Chrome OS or Android, and it is easiest just to
remove the library and includes.
Bug: 26253162
Test: Compiles, libchrome unittests pass, brilloemulator_arm64 builds
Change-Id: I72f3bdad82fa830c9c76922d98b16dfeebfb5389
|
|
Update the following classes:
base::FileTracing::Provider
base::internal::PostTaskAndReplyImpl
base::PostTaskAndReplyWorkerPool
base::TraceLog::EnabledStateObserver
Also remove -Wnon-virtual-dtor.
This is avakulenko@chromium.org's
base-334380-file-tracing-provider-virt-dtor.patch from
Chrome OS with a few more classes added. The original commit
was https://chromium-review.googlesource.com/278013.
Bug: 22317122
Change-Id: Ib7e68ed5b92867ad07128ad9279d059a0eb25864
|
|
Copy the unchanged source from
https://chromium.googlesource.com/chromium/src/base/ as of
r334380 (really r334285 a.k.a. 23911a0c in the base/
subtree).
Also add MODULE_LICENSE_BSD and copy Chromium's current
LICENSE file to NOTICE.
Bug: 22317122
Change-Id: I89863bfeca67b3a1ff05e6078f2f9ee4e31c5c99
|