summaryrefslogtreecommitdiff
path: root/base
AgeCommit message (Collapse)Author
2018-06-12Remove Android-specific valgrind patch.Elliott Hughes
Bug: http://b/77856586 Test: builds Change-Id: I98f2926f5acc7a55a1fb6166573cb7753ea16a92
2018-06-01Remove trace_event.android-o-mr1-iot-release-1.0.1Hidehiko Abe
trace_event is a feature to measure profiling. However, it won't be usable in standard library like libchrome, so remove it. For build compatibility, small stub and trace_event_common.h are kept. Bug: 80375012 Test: Built locally. Change-Id: Ie2a87d2fa0d3cdbd856044498d0dd2072da2e9ab
2018-05-29Remove unused files.Hidehiko Abe
event_types.h and id_map.h are moved out from base/ in Chrome ToT. Becuase these are unused, remove them. Bug: 79557560 Test: Ran treehugger. Change-Id: I012f39a51396987bbb87d6978cc53b74d4568c0c
2018-04-25Remove os_compat_android.android-wear-p-preview-2android-p-preview-3android-p-preview-2android-o-mr1-iot-release-1.0.0android-n-iot-release-lg-thinq-wk7Hidehiko Abe
Originally, it was introduced in libmojo, when the library was built with OS_ANDROID. Now, it is no longer OS_ANDROID so those files are no longer used. Bug: 73270448 Test: Built locally. Made sure "#include "base/os_compat_android.h" is wrapped by "#if defined(OS_ANDROID)". Change-Id: Idf9cedb1af69aa4d19bd6b1bbfc9292ee53ac9c0
2018-04-24Migrate libmojo repository into libchrome, part 2.Hidehiko Abe
This CL moves following files. - .gitignore - Android.bp is merged into libchrome's Android.bp. - base/android/* - build/* except build_config.h which is exactly same with libchrome's. - ipc/* - mojo/* except mojo/public/tools/bindings/generators/__init__.py which is unused and not in chrome repository. - soong/* into libchrome_tools/ - third_party/{catapult,jinja2,markupsafe,ply}/* - ui/gfx/{geometry,range}/mojo/* Then, update several paths/build rules to be adapted. Bug: 73606903 Test: Built locally. Ran on DUT. Change-Id: I2a532a42aa68dcb215dbd71d8673192311509726
2018-04-16Update comment.Hidehiko Abe
To address remaining review comments in https://android-review.googlesource.com/c/platform/external/libchrome/+/638248 Bug: None Test: Ran update_libchrom.py. Change-Id: If7738fb4419f597b21dff287b23f6888f91d4625
2018-04-12Migrate libmojo repository into libchrome, part 1.Hidehiko Abe
This CL moves following files. - base/* except base/android/* - devices/* - ui/* except ui/gfx/**/mojom/* - ui/gfx/range/range_mac(_unittest)?.mm are just deleted. Bug: 73606903, 73270448 Test: Built locally. libchrome_test locally. Run update_libchrome.py and made sure no diff is made. Change-Id: I7f47337aa190f901c9c1d41758f312a2b95adc1b
2018-03-15Introduce stack_trace_android.cc.Hidehiko Abe
This CL moves stack_trace_android.cc from libmojo. The file is identical with what is in chrome repository at r462023. Along with the change, this CL removes UCLIBC macro definition. It looks workaround to deal with stack trace. Bug: 73270448, 73606903 Test: Ran on Treehugger. Change-Id: I6b12b767c64c81e07b7a2a29f5073d9aebc47afa
2018-02-22Remove misc unneeded modifications in libchrome.android-p-preview-1android-o-mr1-iot-preview-7o-mr1-iot-preview-7Hidehiko Abe
Bug: 73270448 Test: Built locally. Treehugger. Change-Id: I2c3f193e1677e4a673ab0b3b60c0c3b40a57987b
2018-02-22Remove modification related DEATH_TEST.Hidehiko Abe
Defer DEATH_TEST handling to the Chrome implementation. Bug: 73270448 Test: Built locally and ran libchrome_test. Treehugger. Change-Id: I2fd07559e22317898ee2ff65a2bc7e0436c8955d
2018-02-22Remove unused files.Hidehiko Abe
libchrome contained unused files. This CL removes them. - BUILD.gn Currently gn is not used. We're working on it (in ChromeOS build), but not a few files are dropped, so we need to revisit here later. - ios, win specific files. - base/i18n/. It only contains base_i18n_export.h, which is not used. - base/trace_event/etw_manifest/. It is for win. Bug: 73270448 Test: Built locally. Treehugger. Change-Id: I5c59af648573f3b670f380e3263c456eec296af7
2018-02-22Remove modification for missing-field-initializers from sources.Hidehiko Abe
Since C++11, we have concrete semantics. Thus, we rely on it. Note that, we still need to keep LAZY_INSTANCE_INITIALIZER because it is a macro used in other project, which may have missing-field-initializers warning enabled. Bug: 73270448 Test: Built locally. Treehugger. Change-Id: Ieb59b25c2936d27c3501d21098b248fac2778f0a
2018-02-22Use header files to proxy system headers.Hidehiko Abe
Instead of directly modifying include directives, use header files to proxy system headers. This reduces line-by-line modification from Chrome repository. Bug: 73270448 Test: Built locally. Treehugger. Change-Id: I8f7315fc21634d3c2fb46bb9a72a43974140b9dc
2018-02-21Re-uprev to r462023.Hidehiko Abe
Previous uprevs didn't include several CLs. This re-uprev's to the r462023. cf) Missing CLs I found. https://codereview.chromium.org/2556563002 https://codereview.chromium.org/2754483002 https://codereview.chromium.org/2171833002 https://codereview.chromium.org/2778183003 https://codereview.chromium.org/2500473002 https://codereview.chromium.org/2173523002 https://codereview.chromium.org/2666423002 https://codereview.chromium.org/2723423002 https://codereview.chromium.org/2789463002 https://codereview.chromium.org/2723083004 https://codereview.chromium.org/2637843002 https://codereview.chromium.org/2785943004 https://codereview.chromium.org/2657603004 https://codereview.chromium.org/2774363003 https://codereview.chromium.org/2776853002 https://codereview.chromium.org/2736053003 https://codereview.chromium.org/2779413002 https://codereview.chromium.org/2782503002 https://codereview.chromium.org/2782083003 https://codereview.chromium.org/2399213005 https://codereview.chromium.org/2787383002 https://codereview.chromium.org/2790523004 https://codereview.chromium.org/2787533002 https://codereview.chromium.org/2780983003 https://codereview.chromium.org/2790403003 https://codereview.chromium.org/2747673002 https://codereview.chromium.org/2778173003 https://codereview.chromium.org/2788613004 https://codereview.chromium.org/2781983003 https://codereview.chromium.org/2774223003 Bug: 73270448 Test: Built and ran libchrome_test locally. Run treehugger. Change-Id: I5e76096d4fcf660571275cce5f4a980a8bb574fe
2018-02-20Remove modification to deal with unused-parameter warning.Hidehiko Abe
libchrome used to hit unused-parameter warning. Now, libchrome is built with -Wno-unused-parameter flag, and its client libraries/executables are built with the header files containing pragma to suppress the warning from libchrome. Thus, the modification can be removed to reduce the diff from Chrome upstream. Bug: 73270448 Test: Built locally. Treehugger. Change-Id: I51b6349bfdb28ed15df1d12b836adccffabe53bb
2018-02-19Remove ALLOW_UNUSED_PARAM macro.Hidehiko Abe
Now libchrome is built with -Wunused-parameter, so we no longer need the macro. Bug: 73270448 Test: Built locally. Treehugger. Change-Id: Ie02279df60b26f78019e28d383c50084695fb07a
2018-02-19Deal with -Wunused-parameter in libchrome build rule.Hidehiko Abe
So, now we do not need modification in libchrome to workaround the error. Bug: 73270448 Test: Build locally. Treehugger. Change-Id: I38fe79c1e01fd39a4bdd7121bb58b9b6d9a3da89
2018-02-08Clean up Mac related files.Hidehiko Abe
We droped to support libchrome on Mac host. This CL cleans up Android.bp related to Mac, and removes the files which are no longer used. Bug: 72618679 Test: Build locally, ran Treehugger. Change-Id: I50d0aec5707212be2163286d5c91904196a0be84
2018-01-19libchrome: Add since_origin API to TimeBaseandroid-wear-8.0.0_r1Abhishek Bhardwaj
This change adds the since_origin API to the TimeBase class. Taken from Chrome at r488841. Bug: None Test: Compiled the tree. Change-Id: Ie2196eac8c4a39a48000349f049cbea9decd3023
2017-12-22Uprev the library to r462023 from Chromium, 3rd attemptJakub Pawlowski
This merge was done against r462023 which corresponds to git commit 32eb7c31af9cab6231f0d3d05206072079177605 from Apr 05, 2017 First attempt, in commit bf8c17f71511c1e90cd8cccfe71f0852c566bd3b was badly squashed, causing automated test failure in system/bt. Next one broke mac build. Test: manually ran all test from system/bt that failed on previous attempt, plus libchrome_unittest Change-Id: I60003263418de3078c7be2da9fb1eeaeb786f3d0
2017-12-21Revert "Uprev the library to r462023 from Chromium"Mathieu Chartier
This reverts commit fe2f52931e8e50253d06329d7bf0a4164c7ba580. Reason for revert: Mac build broken Change-Id: I3abd2ba6874ec5bd283ba17c36ad0b35bcc3d374
2017-12-21Revert "Mac build fix"Mathieu Chartier
This reverts commit 1c01c739718e65746f393b405a2bf97ce4cf8523. Reason for revert: Mac build broken (required for merge conflicts). Change-Id: Ibc4d6e69095ddd320e9e9814daa1a3a0cb11609f
2017-12-21Mac build fixJakub Pawlowski
Change-Id: Ice279534e47d6edccc8baf2ab62744f3e74f04e8
2017-12-21Uprev the library to r462023 from ChromiumJakub Pawlowski
This merge was done against r462023 which corresponds to git commit 32eb7c31af9cab6231f0d3d05206072079177605 from Apr 05, 2017 Previous attempt, in commit bf8c17f71511c1e90cd8cccfe71f0852c566bd3b was badly squashed, causing automated test failure in system/bt. Test: manually ran all test from system/bt that failed on previous attempt, plus libchrome_unittest Change-Id: I539a868af1d06baad3e80a89b8c16fb3d86ab77a
2017-12-20Revert "Uprev the library to r462023 from Chromium"Jakub Pawlowski
This reverts commit bf8c17f71511c1e90cd8cccfe71f0852c566bd3b. Reason for revert: https://buganizer.corp.google.com/issues/70858501 Change-Id: Iedb1193d46ea2211f8b6fdace41902ad8df6d754
2017-12-19Uprev the library to r462023 from ChromiumJakub Pawlowski
This merge was done against r462023 which corresponds to git commit 32eb7c31af9cab6231f0d3d05206072079177605 from Apr 05, 2017 Change-Id: I70bf77fcb3215da3e17f997752bfdad7d4e6e1c9
2017-12-19libchrome: Add a couple more headersLuis Hector Chavez
This enables libmojo to use files from ui/gfx/ Exempt-From-Owner-Approval: Fix build Bug: 38318511 Test: m Change-Id: Ie7224ba71deef5965c7a33dfb1fff06ba4d054e3
2017-12-13libchrome: Uprev the library to r456626 from ChromiumHidehiko Abe
Pulled the latest and greatest version of libchrome from Chromium. The merge was done against r456626 which corresponds to git commit 08266b3fca707804065a2cfd60331722ade41969 of Mar 14, 2017 Notable changes are: - FOR_EACH_OBSERVER macro removed (replaced by use of C++ 11 range-base for loop) - base::Values no more FundamentalValue - stl_util moved to base namespace - some scoped pointers removed in crypto/ in favor of BoringSSL UniquePtr. - path() accessor renamed to GetPath() in ScopedTempDir (and other classes) - introduction of base::CallbackOnce Test: All unit-tests should still pass. Change-Id: I1e65efb167fa708e35ed7c6492f1cb66a6a46104 Merged-In: I180f9defc7607f462389fae17701fff553c4a2d0
2017-07-26Revert "libchrome: Uprev the library to r456626 from Chromium"android-o-mr1-preview-2android-o-mr1-preview-1Luis Hector Chavez
am: e5b2c6fa6f Change-Id: I819960740d65600c933289f480ab6a9e53a88c62
2017-07-26Revert "libchrome: Uprev the library to r456626 from Chromium"android-o-iot-preview-5o-iot-preview-5Luis Hector Chavez
This reverts commit 0601274935e7f632eb0d6ce0fd223b744349d20b. Reason for revert: Broke the mac_sdk Exempt-From-Owner-Approval: Fixing mac_sdk Change-Id: I2cab1818261f3b75dcf7dfc3edf6d6b7bab541a8
2017-07-26libchrome: Uprev the library to r456626 from ChromiumJay Civelli
am: 0601274935 Change-Id: I04c76587e9fb0cdc8f189efe7a12161aee303ec0
2017-07-26libchrome: Uprev the library to r456626 from ChromiumJay Civelli
Pulled the latest and greatest version of libchrome from Chromium. The merge was done against r456626 which corresponds to git commit 08266b3fca707804065a2cfd60331722ade41969 of Mar 14, 2017 Notable changes are: - FOR_EACH_OBSERVER macro removed (replaced by use of C++ 11 range-base for loop) - base::Values no more FundamentalValue - stl_util moved to base namespace - some scoped pointers removed in crypto/ in favor of BoringSSL UniquePtr. - path() accessor renamed to GetPath() in ScopedTempDir (and other classes) - introduction of base::CallbackOnce Test: All unit-tests should still pass. Change-Id: I5c2cb41ea4c037fe69fbb425e711b1399d55d591
2017-03-21Fix ignored parameter in TraceAnalyzer am: b6b1eb9428 am: 5ab0a1eff0skiazyk
am: 867af56881 Change-Id: I822a8b827e4aa91e3489cb3a50c55eacafffc9ff
2017-03-20Fix ignored parameter in TraceAnalyzerskiazyk
This appears to be a bug where a parameter is ignored in one of its members. BUG=None Review-Url: https://chromiumcodereview.appspot.com/2414133005 Cr-Commit-Position: refs/heads/master@{#426617} (cherry picked from commit 06bca199aa1931102f3f33c7911a45d46c799654) Change-Id: If5454cd7b87a36673f19be13d73681adecc4ba54
2017-03-08Add some changes to TraceAnalyzer to improve analysis am: 4b1ad93f7b am: ↵skiazyk
bfef0a1364 am: ad9a0aa907 Change-Id: I94d521e0e6f46e2583bf01b76cb1ed28adda8961
2017-03-07Add some changes to TraceAnalyzer to improve analysisandroid-n-mr2-preview-2skiazyk
* Tests which rely on being able to query for the end event in a pair were not possible, partly because end events tend to be missing information, and also because they did not reference their start events * Async event association can optionally be allowed for events which span across process boundaries BUG=None Review-Url: https://codereview.chromium.org/2716023002 Cr-Commit-Position: refs/heads/master@{#455132} (cherry picked from commit 83621ef58f633413145bd7093f16d56eb2c88103)
2017-02-23Keep only AOSP developers in OWNERS file. am: 101b73f77a am: 458973e464Chih-Hung Hsieh
am: f0f2fea881 Change-Id: I3cc7d17dd2b973166f237ff9c254e37c5716c4c2
2017-02-22Keep only AOSP developers in OWNERS file.Chih-Hung Hsieh
Upstream files should be updated and approved upstream. Bug: 33166666 Test: default build targets Change-Id: Id9156f1001f3c28224b42f07fdad43dc48f6c042
2016-12-16Disable experimental allocator shim for AndroidMark Urbanus
Disable the experimental allocator shim on Android builds. At this point we haven't identified a need for it and prevents us from having to update the linker flags for the many projects that have libchrome as a dependency. Bug: 33239390 Test: Validated libchrome dependents (update_engine) can be built properly without adding the -wrap* linker flags Change-Id: I4e7e914883dfbc08b7eab9e0e175c14e59e386eb
2016-10-29Revert "Revert "Fix builds with XCode 8 / OSX SDK 10.12""Dan Willemsen
This reverts commit 244916243b3eb807bad582f8285534469526af71. We now use / require at least the 10.10 SDK to build this branch, so this should be safe now. Change-Id: I2e3a9b127d7e8f287f180015aa57389f26525fa9
2016-10-26Revert "Fix builds with XCode 8 / OSX SDK 10.12"Dan Willemsen
This breaks builds using the 10.9 SDK. This reverts commit fb6424b5515dea0137dd303f0c2f373e2ddb4806. Change-Id: Ic5d98ab013e16a7ba74c37603434635cf4bf12fb
2016-10-26Fix builds with XCode 8 / OSX SDK 10.12Dan Willemsen
Before OSX 10.12, IOBluetooth/IOBluetooth.h imported CoreBluetooth/CoreBluetooth.h, but it no longer does in the new SDK. Since we use CB*, include what we use. Test: m -j checkbuild (on 10.11 w/10.12 SDK) Change-Id: I4c9d2f8faac473ec591754f5a515180e70fb7948
2016-08-03Fix a race condition in persistent memory allocator unit testSteve Fung
The PersistentMemoryAllocatorTest.IteratorParallelismTest unit test gets stuck on a thread's Join() call when run on brilloemulator-arm. This appears to be due to a race condition in the thread setting up its lock and waiting on the condition variable, and the parent thread issuing the Signal() chain that is meant to wake up the children threads. Add in an autolock in the main thread and a conditional bool around the threads' call to Wait() to prevent any threads from calling Wait() after the main thread has already sent the signal. BUG=b:30183753 TEST=`base_unittests --gtest_filter=PersistentMemoryAllocatorTest.*` passes Committed: https://crrev.com/ff268f9b1002cedd94e6f6b9b3c6960aeb3037ca Cr-Commit-Position: refs/heads/master@{#409622} Change-Id: I6c5cf36f77655a5b34bce1b005ceda54101febef
2016-08-03Revert "Fix a race condition in persistent memory allocator unit test"Steve Fung
This reverts commit 0cfccb799ce68cc66d389e6885f8d73f95ee5c4f. When upstreaming the commit, a few slight modifications were made, so revert the local commit and apply the upstream commit to avoid any future merge problems. Bug: 30183753 Test: `libchrome_test` passes on brilloemulator-arm
2016-07-27libchrome: Avoid using CommandLine if it's not initializedLuis Hector Chavez
This was causing crashloops in brillo's nativeperms since it initialized logging without a CommandLine. TEST=brillo_WebservdSanity TEST=suite:brillo-smoke Change-Id: I9aec87bf037d0a00ec362d2afe53242145799e0a
2016-07-27libchrome: Second attempt at fixing Mac buildLuis Hector Chavez
For reasons I have not yet understood, the Android buildbot fails to like the forward declarations. This second attempt at a fix keeps the code in Yosemite+ as-is and conditionally-omits it for previous versions. Change-Id: Ibdb52961f1ce33c24a0bdaf68a058bdb006f9333
2016-07-27libchrome: Fix the Mac buildLuis Hector Chavez
This change was missing from the previous one by accident. BUG: 29104761 TEST: Build in OS X El Capitan Change-Id: I853eb10e22af7c8ef6ddaf10894670978d2cf19f
2016-07-27libchrome: Uprev the library to r405848 from ChromiumLuis Hector Chavez
Pulled the latest and greatest version of libchrome from Chromium. The merge was done against r405848 which corresponds to git commit 909e5d3ecab27bb09cc570c1c215d0221bd6fe53 of Jul 15, 2016 Notable changes are: - base::Bind() now explicitly disallows captures in lambdas (which was never allowed in the style guide). - base::ListValue::iterator now exposes std::unique_ptr<base::Value> instead of raw base::Value*. BUG: 29104761 TEST: All tests in libchrome_test pass on dragonboard-eng build Change-Id: I94b285a3be074efa30c4e71ae93c8f2a99fb0b87
2016-07-20Fix a race condition in persistent memory allocator unit testSteve Fung
The PersistentMemoryAllocatorTest.IteratorParallelismTest unit test gets stuck on a thread's Join() call when run on brilloemulator-arm. This appears to be due to a race condition in the thread setting up its lock and waiting on the condition variable, and the parent thread issuing the Signal() chain that is meant to wake up the children threads. Add in an autolock in the main thread and a conditional bool around the threads' call to Wait() to prevent any threads from calling Wait() after the main thread has already sent the signal. Bug: 30183753 Test: `libchrome_test` passes on brilloemulator-arm Change-Id: Ief955ed8d94c9264e6d3cbbfaad637a1c5fade02
2016-06-02libchrome: Fix the build in OS X > 10.10android-wear-n-preview-2android-wear-7.1.1_r1android-n-preview-5android-n-preview-4android-n-iot-preview-2nougat-mr1-wear-releasen-iot-preview-2Luis Hector Chavez
For some reason, there is a conflict in the forward declaration of NSUserActivity. This allows newer versions of OS X than what the buildbots have to be able to build libchrome. Bug: 28985443 Change-Id: I3ba3af04fcaba086862f3114250324348c0c9cf2 Test: mmma -j external/libchrome # in El Capitan