summaryrefslogtreecommitdiff
path: root/NOTES.TXT
diff options
context:
space:
mode:
authorPetr Hosek <phosek@chromium.org>2018-06-12 03:10:02 +0000
committerPetr Hosek <phosek@chromium.org>2018-06-12 03:10:02 +0000
commitf48515b28b423e5387399524a7aef53c51810f59 (patch)
tree555d5a65790f581a8fbb1b19075fc73fbcf09d27 /NOTES.TXT
parent385a6d473fd77e6d6241bb3ab854ef2ec4bb83ea (diff)
downloadlibcxx-f48515b28b423e5387399524a7aef53c51810f59.tar.gz
Reland "Use custom command and target to install libc++ headers"
Using file(COPY FILE...) has several downsides. Since the file command is only executed at configuration time, any changes to headers made after the initial CMake execution are ignored. This can lead to subtle errors since the just built Clang will be using stale libc++ headers. Furthermore, since the headers are copied prior to executing the build system, this may hide missing dependencies on libc++ from other LLVM components. This changes replaces the use of file(COPY FILE...) command with a custom command and target which addresses all aforementioned issues and matches the implementation already used by other LLVM components that also install headers like Clang builtin headers. Differential Revision: https://reviews.llvm.org/D44773 git-svn-id: https://llvm.org/svn/llvm-project/libcxx/trunk@334468 91177308-0d34-0410-b5e6-96231b3b80d8
Diffstat (limited to 'NOTES.TXT')
-rw-r--r--NOTES.TXT1
1 files changed, 1 insertions, 0 deletions
diff --git a/NOTES.TXT b/NOTES.TXT
index f0597de64..24d245d43 100644
--- a/NOTES.TXT
+++ b/NOTES.TXT
@@ -26,3 +26,4 @@ to libc++.
1. Add a test under `test/libcxx` that the header defines `_LIBCPP_VERSION`.
2. Update `test/libcxx/double_include.sh.cpp` to include the new header.
3. Create a submodule in `include/module.modulemap` for the new header.
+4. Update the include/CMakeLists.txt file to include the new header.