diff options
Diffstat (limited to 'mojo/public/cpp/bindings/lib/validation_context.cc')
-rw-r--r-- | mojo/public/cpp/bindings/lib/validation_context.cc | 66 |
1 files changed, 51 insertions, 15 deletions
diff --git a/mojo/public/cpp/bindings/lib/validation_context.cc b/mojo/public/cpp/bindings/lib/validation_context.cc index ad0a364..a95e07e 100644 --- a/mojo/public/cpp/bindings/lib/validation_context.cc +++ b/mojo/public/cpp/bindings/lib/validation_context.cc @@ -4,7 +4,13 @@ #include "mojo/public/cpp/bindings/lib/validation_context.h" +#include <stddef.h> +#include <stdint.h> + #include "base/logging.h" +#include "mojo/public/cpp/bindings/lib/serialization_util.h" +#include "mojo/public/cpp/bindings/message.h" +#include "mojo/public/cpp/system/handle.h" namespace mojo { namespace internal { @@ -12,39 +18,69 @@ namespace internal { ValidationContext::ValidationContext(const void* data, size_t data_num_bytes, size_t num_handles, - size_t num_associated_endpoint_handles, Message* message, - const base::StringPiece& description, - int stack_depth) + const base::StringPiece& description) : message_(message), description_(description), data_begin_(reinterpret_cast<uintptr_t>(data)), data_end_(data_begin_ + data_num_bytes), handle_begin_(0), - handle_end_(static_cast<uint32_t>(num_handles)), - associated_endpoint_handle_begin_(0), - associated_endpoint_handle_end_( - static_cast<uint32_t>(num_associated_endpoint_handles)), - stack_depth_(stack_depth) { - // Check whether the calculation of |data_end_| or static_cast from size_t to - // uint32_t causes overflow. - // They shouldn't happen but they do, set the corresponding range to empty. + handle_end_(static_cast<uint32_t>(num_handles)) { if (data_end_ < data_begin_) { + // The calculation of |data_end_| overflowed. + // It shouldn't happen but if it does, set the range to empty so + // IsValidRange() and ClaimMemory() always fail. NOTREACHED(); data_end_ = data_begin_; } if (handle_end_ < num_handles) { + // Assigning |num_handles| to |handle_end_| overflowed. + // It shouldn't happen but if it does, set the handle index range to empty. NOTREACHED(); handle_end_ = 0; } - if (associated_endpoint_handle_end_ < num_associated_endpoint_handles) { - NOTREACHED(); - associated_endpoint_handle_end_ = 0; - } } ValidationContext::~ValidationContext() { } +bool ValidationContext::ClaimMemory(const void* position, uint32_t num_bytes) { + uintptr_t begin = reinterpret_cast<uintptr_t>(position); + uintptr_t end = begin + num_bytes; + + if (!InternalIsValidRange(begin, end)) + return false; + + data_begin_ = end; + return true; +} + +bool ValidationContext::ClaimHandle(const Handle_Data& encoded_handle) { + uint32_t index = encoded_handle.value; + if (index == kEncodedInvalidHandleValue) + return true; + + if (index < handle_begin_ || index >= handle_end_) + return false; + + // |index| + 1 shouldn't overflow, because |index| is not the max value of + // uint32_t (it is less than |handle_end_|). + handle_begin_ = index + 1; + return true; +} + +bool ValidationContext::IsValidRange(const void* position, + uint32_t num_bytes) const { + uintptr_t begin = reinterpret_cast<uintptr_t>(position); + uintptr_t end = begin + num_bytes; + + return InternalIsValidRange(begin, end); +} + +bool ValidationContext::InternalIsValidRange(uintptr_t begin, + uintptr_t end) const { + return end > begin && begin >= data_begin_ && end <= data_end_; +} + } // namespace internal } // namespace mojo |