Age | Commit message (Collapse) | Author |
|
To make it clear where to file test failure bugs.
Bug: 288143741
Change-Id: Idbaf4a799b6039a42dabf5cd999d92bcfde116a2
Test: none
|
|
24a7724859 am: fd2b4c1850 am: c79eab13ae
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2548553
Change-Id: I5e0863a1b16fe38b6a5ba8130b301178781cfe5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
24a7724859 am: fd2b4c1850 am: 261f82f82c
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2548553
Change-Id: I781f61eba67573169a9999235790349f5689b036
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
24a7724859 am: fd2b4c1850
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2548553
Change-Id: Iccf02e0acaa3fbbe1919a98a586303c172d439e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
24a7724859 am: fd2b4c1850
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2548553
Change-Id: I46f5289afdc79a7d4dfa84fc33637269317cf4dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2548553
Change-Id: I048027163b5df9bf7f458f0a8f0b894f15f2fa57
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2548553
Change-Id: I59bfb5ded12bc4af4e454d26289bb54ba46125fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2548553
Change-Id: I0becd9bd3d69119968420dd54a3d91189b3c9a2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
this file has transitive dependency on base/logging.h
aosp/2548850 removes a #include logging.h which causes compilation to fail here. If
we want to keep DCHECK in, we should include logging.h in this file
Test: tested compilation
Bug: 277219978
Change-Id: Id96aad34b34d8d2715f9e8bf54fcf24108a41569
|
|
into stage-aosp-master am: 78f29156ab -s ours am: 23d4db07a8 -s ours
am skip reason: Merged-In I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 with SHA-1 9b40752880 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2338121
Change-Id: Ibabb07f17e4d8571bb904de88d5d16766fab6877
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
7815367315 -s ours am: 82e47cdd5c -s ours
am skip reason: Merged-In I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 with SHA-1 9b40752880 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2338121
Change-Id: Ic3e6fc5eea31ba2293a7f7f7cc6d23eccb6097eb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
b077cd7b3d -s ours am: 4a724fae2e -s ours
am skip reason: Merged-In I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 with SHA-1 9b40752880 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2338121
Change-Id: I54692b3a11403660e1706c55cf0c0c47f0dfc8f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
into stage-aosp-master am: 78f29156ab -s ours
am skip reason: Merged-In I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 with SHA-1 9b40752880 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2338121
Change-Id: Iaf172fa52a330895710a15a63447b64e461579fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
7815367315 -s ours
am skip reason: Merged-In I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 with SHA-1 9b40752880 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2338121
Change-Id: I2a1b5e0331411b73f75c809431e5556cb9dbd9da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
b077cd7b3d -s ours
am skip reason: Merged-In I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 with SHA-1 9b40752880 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2338121
Change-Id: I5b584dcb2fcd8da1da42e74aba2f093368a4eef8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
into stage-aosp-master
|
|
am skip reason: Merged-In I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 with SHA-1 9b40752880 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2338121
Change-Id: I72bc56cfe4e672fd0729e6e5c2f1b3129c44e867
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am skip reason: Merged-In I983aa93ce7ae352aca748d4bbab8fd2d1af28df5 with SHA-1 9b40752880 is already in history
Original change: https://android-review.googlesource.com/c/platform/external/libpalmrejection/+/2338121
Change-Id: Ib3dea5478ec36e034a030a927fb2c52aa923b706
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Bug: 261731544
Merged-In: I983aa93ce7ae352aca748d4bbab8fd2d1af28df5
Change-Id: I1a935e0d8210bea0c1476b6050df4dff9ba3d264
|
|
2de2d33b3e -s ours am: 41e1693e02 -s ours
am skip reason: Merged-In Ic44637e1b98e9fd716582dcad9ff1b7e07fb311f with SHA-1 9eb275ef74 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/20135589
Change-Id: Id54ce6f1de65079ce4cc22bbf6be7c85911cbf7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
2de2d33b3e -s ours
am skip reason: Merged-In Ic44637e1b98e9fd716582dcad9ff1b7e07fb311f with SHA-1 9eb275ef74 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/20135589
Change-Id: I87385ed3fde5676bb656330c39c293d62d0693ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Bug: 248070379
Merged-In: Ic44637e1b98e9fd716582dcad9ff1b7e07fb311f
Change-Id: I97f705373c162420c3bd6b9b0ae97a9752a48ab1
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19472519
Change-Id: I8a904af48c7d2a8abd1b9eb924a2ee27b73aa898
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19472519
Change-Id: Ibf84af80fce42453f15c07cc506f06cd34ba4a30
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Currently, we are relying on the number of samples in order to do certain
actions, like checking for hold or for running the rejection model.
Before this CL, the resampling could end up producing several samples at
once. This would cause the actions above to potentially be skipped,
because we performed the check of the number of samples before the
resampling code ran. An exact match for certain number of samples was
performed, so sometimes, palm rejection model would not get executed.
In this CL, we change the approach to rely on the time instead. We check
whether a specific time threshold is crossed with each sample received
from the touchscreen. If it's crossed, then the action is taken.
Additional changes here:
1) All samples are now stored in unmodified manner.
2) It's possible to exceed max_sample_count when resampling is enabled
3) samples_seen() is replaced with Duration()
4) When a resampled value is needed, we get getSampleAt(time). The
resampled value is never stored.
5) Old variables such as last_sample and old function Resample were
deleted
6) We are now storing the first sample's timestamp in first_sample_time.
It's needed to calculate the duration of the stroke, since at some
point, we will drop the first sample
After this change, any references to samples_seen and samples().size()
should consider the resampled and non-resampled cases.
Therefore, the "Filter" function should not directly check the number of
samples anywhere.
Bug: b/240168494
Test: atest libpalmrejection_test inputflinger_tests
Change-Id: I983aa93ce7ae352aca748d4bbab8fd2d1af28df5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857630
Commit-Queue: Xinglong Luan <alanlxl@chromium.org>
Reviewed-by: Rob Schonberger <robsc@chromium.org>
Auto-Submit: Siarhei Vishniakou <svv@google.com>
Reviewed-by: Xinglong Luan <alanlxl@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1049397}
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19914652
Change-Id: Ie1ea08351233e0553dd0369083fa825fc17a7cdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19914651
Change-Id: Id382e1f08a0518c32c904fe587d3a04035670415
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19914650
Change-Id: Idfea1b2c38b675c9e00638d25b69fa4e012b29ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19914652
Change-Id: Id76fdd6dd3c885cbbca3eca9f1914a97d02c327f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19914651
Change-Id: I97f334ea65d18ce59e21cd2d76bed58bd0ae5ea3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19914650
Change-Id: I9fb9a1988eeb94f6a5e684996ec99c1d9c124ab5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
These functions will allow us to handle resampling in the future,
because the logic will be moved out of the main Filter function and into
the small pieces of code that are easy to modify.
Bug: b/240168494
Test: autoninja -C out/Default events_unittests
Change-Id: I639634df001ad30977a2d07e48348af99e11e655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3857624
Auto-Submit: Siarhei Vishniakou <svv@google.com>
Commit-Queue: Siarhei Vishniakou <svv@google.com>
Reviewed-by: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1043971}
|
|
The condition should use the entire stroke, not recent samples. This was
not "really" a bug because it would never get triggered.
In practice today, samples().size() would reach max, and then it would
permanently stay there. But semantically, it makes more sense to
consider the entire stroke's duration.
Bug: b/240168494
Test: autoninja -C out/Default events_unittests
Change-Id: I66e5d0bce46909a329eb7d43448950a5f3503266
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854948
Reviewed-by: Rob Schonberger <robsc@chromium.org>
Commit-Queue: Siarhei Vishniakou <svv@google.com>
Auto-Submit: Siarhei Vishniakou <svv@google.com>
Cr-Commit-Position: refs/heads/main@{#1039338}
|
|
Currently, the condition is complicated. In reality, the requirement is
that the number of samples is exactly equal to max.
Update the code so that it's clear.
Bug: b/240168494
Test: autoninja -C out/Default events_unittests
Change-Id: I8cdcdacc4cf9926779b22a47b7be62899c101702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3854946
Reviewed-by: Rob Schonberger <robsc@chromium.org>
Auto-Submit: Siarhei Vishniakou <svv@google.com>
Commit-Queue: Siarhei Vishniakou <svv@google.com>
Cr-Commit-Position: refs/heads/main@{#1039304}
|
|
am: cfbe649613
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19469373
Change-Id: If8bba99c80417dff4a3ef65d4fe6d7ac8dbde4c4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19469373
Change-Id: Ifdd8c46e38b73425d097d7def66351c7272a839a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
This variable is always zero and is undocumented. Remove it.
Bug: 240168494
Test: autoninja -C out/Default events_unittests
Test: autoninja -C out/Default evdev
Change-Id: I06bb8b437847620dd5b2d00ec790d497e61c65f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3787688
Commit-Queue: Siarhei Vishniakou <svv@google.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Xinglong Luan <alanlxl@chromium.org>
Auto-Submit: Siarhei Vishniakou <svv@google.com>
Cr-Commit-Position: refs/heads/main@{#1029604}
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19471503
Change-Id: I0d414225bbd0601c82fe4090b8d58d2c95e7b1a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19471503
Change-Id: I9971e09146cfab25d4bde6ad8bc68efcc92fa17f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
To fix formatting, add a comma.
Bug: 240168494
Test: None
Change-Id: I47dcb00a2c5c7c6243748b4eb0d666a2dfc912d9
|
|
301ae9d2a6 am: ac8748606b -s ours
am skip reason: Merged-In Ia3f281946ffa82ea48c3f4c32f9563b294e9221a with SHA-1 49b0d6a829 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19349205
Change-Id: Iff930f76011f228d1733b24e4e76fe981bda933f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
58c888f75f am: f1c3741893 -s ours
am skip reason: Merged-In I47d12afc966c7c5c17536329058ab746c12f261e with SHA-1 07d3a5bbdc is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19349204
Change-Id: I883e52746caa0d7fbf41af35bb43424066ba37f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am: 1de6e2f772 -s ours
am skip reason: Merged-In I87e9e057217b98ca51c47625bb0ceceedb64acea with SHA-1 e197334646 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19349202
Change-Id: Ifb871a1b906ff3ca41122e744cd83d04d12c5e9b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
am: af76fa5a19 -s ours
am skip reason: Merged-In I900c80963e1e402d901a1cbbf9878f096577a555 with SHA-1 6ad0003b77 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19349201
Change-Id: Ia9b0daf6e97b3185bb385e0f42ec88ebc414b536
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
b9ed7e09f4 -s ours
am skip reason: Merged-In I0661807f5a383d75822551c4490b2a6808db587b with SHA-1 c4e3da6142 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19349346
Change-Id: Iede91d41f4b1aa157413baa47f57a8cdd4f9bf14
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
651b44f8a5 am: 402fd428f3 -s ours
am skip reason: Merged-In I5c18eb7a62a0182cad2cf0ed0ba083b2d5f94450 with SHA-1 453e9bd76a is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19349200
Change-Id: I443cdd52b5301cacdae2a7d551fa9833e34d38bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
e47ff3bfb5 am: ab3ee79999 -s ours
am skip reason: Merged-In I3364fb7a7c53ad708f815de828806239e2d3d253 with SHA-1 68fb319bbf is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19348644
Change-Id: I0f2957f16bdc235a040a1b130734751a19675970
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
fingers. am: 723c89b4bd am: 6aff9ae7df -s ours
am skip reason: Merged-In I1d81df59d1ab0c75a6d6456e21b45ed8113722b4 with SHA-1 1848752185 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19348643
Change-Id: I0a1a72b7299c2945d19fe11fd55927121a56a2e8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
362f08ac70 am: e54e921c28 -s ours
am skip reason: Merged-In I7bda4a3bd05160eaad8702d1173d15fb1f3fdb1c with SHA-1 849a097c52 is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19348642
Change-Id: If342eabc829166a2c6ad1229519f2c52a9e17934
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
scenarios on kohaku am: 6c8e39e63a am: 0c3e7d3977 -s ours
am skip reason: Merged-In Ibc521a2b343cf56940df16ad8e213e3a0d888435 with SHA-1 9b7296bd7f is already in history
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/libpalmrejection/+/19348777
Change-Id: I20796dee90442c3265d808695f187314d006fb65
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|