diff options
author | Shaopeng Jia <shaopengjia@google.com> | 2011-10-14 20:33:37 +0200 |
---|---|---|
committer | Shaopeng Jia <shaopengjia@google.com> | 2011-10-14 23:45:43 +0200 |
commit | 507cdd3f40be5346cfd0681239b5dc81abc57d9b (patch) | |
tree | 59d543f2abf051ad6ac128523b0569d5a07a0244 | |
parent | 1940212be2ff2ac5bf7d91eabbdb34e10d9b8e2e (diff) | |
download | libphonenumber-507cdd3f40be5346cfd0681239b5dc81abc57d9b.tar.gz |
Close an InputStream.
Bug: 5451951
Change-Id: Iaca9645468ff71d650cb77b102a02c9e0f389858
-rw-r--r-- | java/src/com/android/i18n/phonenumbers/PhoneNumberUtil.java | 14 | ||||
-rw-r--r-- | java/src/com/android/i18n/phonenumbers/geocoding/PhoneNumberOfflineGeocoder.java | 18 |
2 files changed, 29 insertions, 3 deletions
diff --git a/java/src/com/android/i18n/phonenumbers/PhoneNumberUtil.java b/java/src/com/android/i18n/phonenumbers/PhoneNumberUtil.java index 230b8bf6..3f03ee57 100644 --- a/java/src/com/android/i18n/phonenumbers/PhoneNumberUtil.java +++ b/java/src/com/android/i18n/phonenumbers/PhoneNumberUtil.java @@ -607,7 +607,7 @@ public class PhoneNumberUtil { private void loadMetadataForRegionFromFile(String filePrefix, String regionCode) { InputStream source = PhoneNumberUtil.class.getResourceAsStream(filePrefix + "_" + regionCode); - ObjectInputStream in; + ObjectInputStream in = null; try { in = new ObjectInputStream(source); PhoneMetadataCollection metadataCollection = new PhoneMetadataCollection(); @@ -617,6 +617,18 @@ public class PhoneNumberUtil { } } catch (IOException e) { LOGGER.log(Level.WARNING, e.toString()); + } finally { + close(in); + } + } + + private void close(InputStream in) { + if (in != null) { + try { + in.close(); + } catch (IOException e) { + LOGGER.log(Level.WARNING, e.toString()); + } } } diff --git a/java/src/com/android/i18n/phonenumbers/geocoding/PhoneNumberOfflineGeocoder.java b/java/src/com/android/i18n/phonenumbers/geocoding/PhoneNumberOfflineGeocoder.java index 1d0af1bb..a577e105 100644 --- a/java/src/com/android/i18n/phonenumbers/geocoding/PhoneNumberOfflineGeocoder.java +++ b/java/src/com/android/i18n/phonenumbers/geocoding/PhoneNumberOfflineGeocoder.java @@ -59,12 +59,14 @@ public class PhoneNumberOfflineGeocoder { private void loadMappingFileProvider() { InputStream source = PhoneNumberOfflineGeocoder.class.getResourceAsStream(phonePrefixDataDirectory + "config"); - ObjectInputStream in; + ObjectInputStream in = null; try { in = new ObjectInputStream(source); mappingFileProvider.readExternal(in); } catch (IOException e) { LOGGER.log(Level.WARNING, e.toString()); + } finally { + close(in); } } @@ -83,7 +85,7 @@ public class PhoneNumberOfflineGeocoder { private void loadAreaCodeMapFromFile(String fileName) { InputStream source = PhoneNumberOfflineGeocoder.class.getResourceAsStream(phonePrefixDataDirectory + fileName); - ObjectInputStream in; + ObjectInputStream in = null; try { in = new ObjectInputStream(source); AreaCodeMap map = new AreaCodeMap(); @@ -91,6 +93,18 @@ public class PhoneNumberOfflineGeocoder { availablePhonePrefixMaps.put(fileName, map); } catch (IOException e) { LOGGER.log(Level.WARNING, e.toString()); + } finally { + close(in); + } + } + + private void close(InputStream in) { + if (in != null) { + try { + in.close(); + } catch (IOException e) { + LOGGER.log(Level.WARNING, e.toString()); + } } } |