diff options
| author | Paul Duffin <paulduffin@google.com> | 2017-12-05 18:36:55 +0000 |
|---|---|---|
| committer | Paul Duffin <paulduffin@google.com> | 2017-12-05 18:36:55 +0000 |
| commit | 7448faf3e2d1da95e71ad6b1633f9fdcab3598cf (patch) | |
| tree | 2a971a5ac0c48087aece7145e43fcc7ce2ba306e | |
| parent | 8c8a41bed399af8dbf3bfc263dfa8a75c595d725 (diff) | |
| download | libphonenumber-7448faf3e2d1da95e71ad6b1633f9fdcab3598cf.tar.gz | |
Flatten dependency hierarchy of legacy-android-test
Previous changes statically included legacy-android-test in preparation
for removing android.test.* and junit.* classes from the android.jar.
Unfortunately, that lead to duplicate classes between APKs and the
bootclasspath which caused build problems (Proguard) and also runtime
problems (when targeting and running on older releases).
Switching from statically including the classes to using the runtime
libraries cannot be done in one step because legacy-android-test is
statically included in libraries which are used in many APKs and so
removing it from those libraries requires that all APKs be updated at
once. Doing that atomically across dozens of projects is not practical.
This change modifies APKS that statically include the
legacy-android-test library indirectly.
* If the APK manifest uses the android.test.runner library then the APK
is modified to stop statically including legacy-android-test and
instead build against android.test.base/mock/runner libraries instead.
* Otherwise, the APK statically includes legacy-android-test.
Also, any libraries that statically include are modified to stop
statically including it and if it has source dependencies on the classes
is changed to build against the android.test.base/mock/runner libraries.
The following change descriptions were generated automatically and so
may be a little repetitive. They are provided to give the reviewer
enough information to check the comments match what has actually been
changed and check the reasoning behind the changes.
* Android.mk
Removed legacy-android-test from LOCAL_STATIC_JAVA_LIBRARIES
because libphonenumber-test is not a package so does not need to
statically include the classes
Bug: 30188076
Test: make checkbuild
Change-Id: Id944950f9004ee06906230c3f7449aad0b67967f
| -rw-r--r-- | Android.mk | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -37,6 +37,6 @@ LOCAL_SRC_FILES := $(libphonenumber_test_files) LOCAL_JAVA_RESOURCE_DIRS := $(libphonenumber_test_resource_dirs) LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/Android.mk LOCAL_SDK_VERSION := current -LOCAL_STATIC_JAVA_LIBRARIES := libphonenumber legacy-android-test junit +LOCAL_STATIC_JAVA_LIBRARIES := libphonenumber junit LOCAL_JAVA_LANGUAGE_VERSION := 1.7 include $(BUILD_STATIC_JAVA_LIBRARY) |