aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVitaly Buka <vitalybuka@google.com>2020-01-29 00:43:23 -0800
committerVitaly Buka <vitalybuka@gmail.com>2020-02-04 13:44:06 -0800
commit74afb61aaec72700edebd0a37ec09a85f0ffcafe (patch)
tree933cb5add372c8c4f6a502dd0eda7875d8f051a7
parent439d4de8577bf98ce2629f9651385e159d3300c4 (diff)
downloadlibprotobuf-mutator-74afb61aaec72700edebd0a37ec09a85f0ffcafe.tar.gz
Improve field test by preventing copying of top level messages
-rw-r--r--src/mutator_test.cc25
1 files changed, 12 insertions, 13 deletions
diff --git a/src/mutator_test.cc b/src/mutator_test.cc
index 2629183..ae0f04d 100644
--- a/src/mutator_test.cc
+++ b/src/mutator_test.cc
@@ -547,19 +547,18 @@ void MutatorFieldTest::TestCopyField() {
LoadWithChangedLine(m1_.get(), 7);
LoadWithChangedLine(m2_.get(), 0);
- Msg from;
- from.add_repeated_msg()->CopyFrom(*m1_);
- from.add_repeated_msg()->CopyFrom(*m2_);
-
- Msg to;
- to.add_repeated_msg()->CopyFrom(*m1_);
- to.add_repeated_msg()->CopyFrom(*m1_);
- EXPECT_TRUE(Mutate(from, to));
-
- to.Clear();
- to.add_repeated_msg()->CopyFrom(*m2_);
- to.add_repeated_msg()->CopyFrom(*m2_);
- EXPECT_TRUE(Mutate(from, to));
+ for (int i = 0; i < 2; ++i, m1_.swap(m2_)) {
+ Msg from;
+ from.add_repeated_msg()->CopyFrom(*m1_);
+ from.add_repeated_msg()->CopyFrom(*m2_);
+ from.mutable_repeated_msg(1)->add_repeated_string("repeated_string");
+
+ Msg to;
+ to.add_repeated_msg()->CopyFrom(*m1_);
+ to.add_repeated_msg()->CopyFrom(*m1_);
+ to.mutable_repeated_msg(1)->add_repeated_string("repeated_string");
+ EXPECT_TRUE(Mutate(from, to));
+ }
}
TEST_P(MutatorFieldTest, CopyField) {