diff options
| author | Guillem Jover <guillem@hadrons.org> | 2021-05-24 00:27:22 +0200 |
|---|---|---|
| committer | Guillem Jover <guillem@hadrons.org> | 2021-09-13 13:19:25 +0200 |
| commit | b7c779a90a987f7e65405c7985c52212fcf3cb53 (patch) | |
| tree | 5a5b7e86664b15f3121a0d4f625ec3f20d0f03ad /.github | |
| parent | 9c1401be8b07a93d88a243c57946f84a58890c3d (diff) | |
| download | liburing-b7c779a90a987f7e65405c7985c52212fcf3cb53.tar.gz | |
build: Fix build flags support
The usual convention is that the various *FLAGS are user controllable,
and can be overridden, so anything that is essential for the build
should be passed respecting that. The other usual convention is that
CPPFLAGS only contain pre-processor options, CFLAGS and CXXFLAGS only
contain compilation options and LDFLAGS only contain linker flags,
where all of these are honored in all build rules.
Switch to set optional flags conditionally into the *FLAGS variables if
they are not set, and then unconditionally append any required flags.
And pass the various *FLAGS to the rules as expected.
Signed-off-by: Guillem Jover <guillem@hadrons.org>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/build_with_clang.yml | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/.github/workflows/build_with_clang.yml b/.github/workflows/build_with_clang.yml index 3aca007..ce6707e 100644 --- a/.github/workflows/build_with_clang.yml +++ b/.github/workflows/build_with_clang.yml @@ -27,9 +27,9 @@ jobs: - name: Build run: | make -j$(nproc) V=1 \ - CFLAGS="-Werror -Wno-unused-command-line-argument" \ - CPPFLAGS="-Werror -Wno-unused-command-line-argument" \ - CXXFLAGS="-Werror -Wno-unused-command-line-argument" \ + CFLAGS="-Werror" \ + CPPFLAGS="-Werror" \ + CXXFLAGS="-Werror" \ CC=clang \ CXX=clang++; |