| Age | Commit message (Collapse) | Author |
|---|
|
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
|
|
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
|
|
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
|
|
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
|
|
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
|
|
By default, when we install clang from the default `Ubuntu apt` on the
GitHub bot, we get clang-11, which is kinda old.
clang-15 has better static analysis than the previous versions, for
example, the fix in these commits were only found by clang-15:
7e3f7d6030fb6ce0872b876147d29fe230e7b2ba ("test/35fa71a030ca: Fix -Wunused-but-set-variable warning from clang-15")
045b8c5b183859fbc481ec7ab6b818442cc57ab0 ("test/submit-reuse: Fix -Wunused-but-set-variable warning from clang-15")
Let's install the latest clang version to get better issue coverage.
By default, the Ubuntu apt doesn't provide it. We have to pull from
the LLVM repo. The detail is available at: https://apt.llvm.org
Link: https://github.com/axboe/liburing/pull/567
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
|
|
Since commit:
b7d8dd8bbf5b ("arch/x86/syscall: Add x86 32-bit native syscall support")
liburing supports nolibc build for x86 32-bit. Run the nolibc build for
this arch on the GitHub bot too.
Currently, liburing nolibc is only available for:
- x86-64.
- x86 (32-bit).
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
|
|
This adds multiarch build for GitHub bot. Currently, only GCC that
supports multiarch build. I couldn't find the clang cross compiler
package from the Ubuntu apt, so let's skip it at the moment.
New arch supports:
- aarch64
- arm (32-bit)
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
|
|
I don't care about what happens on github, the git tree is what is
important in terms of commit messages.
Add a section on splitting changes up. Each change should do just one
thing. If it does more than one thing, most likely it should be in
a separate commit.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
|
|
GitHub throws away the relevant information like having even a valid
email address for the person asking to pull.
Another common problem on GitHub, people don't do any of the simplest
things that the kernel people expect from a commit message, like:
- No "short one-line description in the first line".
- No sane word-wrap of the long description. GitHub commit messages
tend to be (if they have any description at all) one long
unreadable line.
- No sign-off and other tags that we require for commit message.
Let's fix this by creating a pull request template that contains pull
request guidelines for GitHub Pull Request.
Link: https://github.com/axboe/liburing/pull/464#issuecomment-950950688
Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
|
|
Fixes: https://github.com/axboe/liburing/issues/443
Signed-off-by: Ammar Faizi <ammar.faizi@students.amikom.ac.id>
|
|
Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
|
|
As these flags are marked as optional now they get reset when we pass
explicit flags.
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
- Use a single definition for both gcc and clang tests, by using a matrix.
- Remove redundant installation for packages present in the CI system.
- Remove version printing for uninteresting programs.
- Trigger for all branches, so that MRs can see results on non-master.
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
The usual convention is that the various *FLAGS are user controllable,
and can be overridden, so anything that is essential for the build
should be passed respecting that. The other usual convention is that
CPPFLAGS only contain pre-processor options, CFLAGS and CXXFLAGS only
contain compilation options and LDFLAGS only contain linker flags,
where all of these are honored in all build rules.
Switch to set optional flags conditionally into the *FLAGS variables if
they are not set, and then unconditionally append any required flags.
And pass the various *FLAGS to the rules as expected.
Signed-off-by: Guillem Jover <guillem@hadrons.org>
|
|
Using `apt` gives the following warning:
```
WARNING: apt does not have a stable CLI interface. Use with caution in scripts.
```
Fix this by using `apt-get` instead of `apt`.
On Dec 30 '17 at 15:15, dessert wrote:
> apt is for the terminal and gives beautiful output while apt-get and
> apt-cache are for scripts and give stable, parsable output.
>
Link: https://askubuntu.com/a/990838/1038828
Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
|
|
Buildling with Clang -Werror error:
make[1]: Entering directory '/home/runner/work/liburing/liburing/test'
clang -Werror -D_GNU_SOURCE -D__SANE_USERSPACE_TYPES__ -I../src/include/ -include ../config-host.h -Werror -D_GNU_SOURCE -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -L../src/ -o helpers.o -c helpers.c -luring
clang: error: -luring: 'linker' input unused [-Werror,-Wunused-command-line-argument]
make[1]: *** [Makefile:159: helpers.o] Error 1
make[1]: Leaving directory '/home/runner/work/liburing/liburing/test'
make: *** [Makefile:13: all] Error 2
##[error]Process completed with exit code 2.
Fix this by adding `-Wno-unused-command-line-argument` for Clang build.
Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
|
|
Add GitHub Actions build with Clang.
Link: https://github.com/axboe/liburing/pull/425#issuecomment-914540396
Cc: Guillem Jover <guillem@hadrons.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
|
|
Add GitHub Actions build with GCC.
Link: https://github.com/axboe/liburing/pull/425#issuecomment-914540396
Cc: Guillem Jover <guillem@hadrons.org>
Signed-off-by: Ammar Faizi <ammarfaizi2@gmail.com>
|
