aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndroid Build Merger (Role) <noreply-android-build-merger@google.com>2018-10-03 16:39:15 +0000
committerAndroid Build Merger (Role) <noreply-android-build-merger@google.com>2018-10-03 16:39:15 +0000
commit76f6b3b052f6e7a8469103c2241b3368863cf20b (patch)
treea007eea9667761ec8fe1711a1431e65247d8908e
parent4b6a4f5fe91b78031ac5d7947f0dbff2c06561b5 (diff)
parent6cf161e9246dfe74ae341119c7537ac3def0365d (diff)
downloadlibvpx-76f6b3b052f6e7a8469103c2241b3368863cf20b.tar.gz
[automerger] libwebm: Cherrypick 5a41830 from upstream am: 0f99871368 am: 6b040ab5b6 am: 9a316baf5e am: 6cf161e924
Change-Id: I0c42d47df8fdc34ae7fc10f44e1da262a541f1ad
-rw-r--r--libwebm/mkvparser/mkvparser.cc22
1 files changed, 10 insertions, 12 deletions
diff --git a/libwebm/mkvparser/mkvparser.cc b/libwebm/mkvparser/mkvparser.cc
index ff1332726..70c1f043f 100644
--- a/libwebm/mkvparser/mkvparser.cc
+++ b/libwebm/mkvparser/mkvparser.cc
@@ -4983,29 +4983,27 @@ bool PrimaryChromaticity::Parse(IMkvReader* reader, long long read_pos,
if (!reader)
return false;
- std::auto_ptr<PrimaryChromaticity> chromaticity_ptr;
+ if (!*chromaticity)
+ *chromaticity = new PrimaryChromaticity();
- if (!*chromaticity) {
- chromaticity_ptr.reset(new PrimaryChromaticity());
- } else {
- chromaticity_ptr.reset(*chromaticity);
- }
-
- if (!chromaticity_ptr.get())
+ if (!*chromaticity)
return false;
- float* value = is_x ? &chromaticity_ptr->x : &chromaticity_ptr->y;
+ PrimaryChromaticity* pc = *chromaticity;
+ float* value = is_x ? &pc->x : &pc->y;
double parser_value = 0;
- const long long value_parse_status =
+ const long long parse_status =
UnserializeFloat(reader, read_pos, value_size, parser_value);
+ if (parse_status < 0 || parser_value < FLT_MIN || parser_value > FLT_MAX)
+ return false;
+
*value = static_cast<float>(parser_value);
- if (value_parse_status < 0 || *value < 0.0 || *value > 1.0)
+ if (*value < 0.0 || *value > 1.0)
return false;
- *chromaticity = chromaticity_ptr.release();
return true;
}