aboutsummaryrefslogtreecommitdiff
path: root/vp8
diff options
context:
space:
mode:
authorJohann <johannkoenig@google.com>2019-11-04 15:58:07 -0600
committerJohann <johannkoenig@google.com>2022-03-31 10:59:50 +0900
commite6ede58a5a6cd34b82321c1b2c36ec14984e6ecd (patch)
tree29ceb73c03d10dee2f40c44f4763c2324e7fde89 /vp8
parent6d1844e54d132c6c2078f529b511ab443bc910ac (diff)
downloadlibvpx-e6ede58a5a6cd34b82321c1b2c36ec14984e6ecd.tar.gz
remove unused vp8_encode_intra parameter
Follow it up and also remove it from other functions. BUG=webm:1612 Change-Id: I9d3cb785ab0d68c6fcae185043c896d8a135e284
Diffstat (limited to 'vp8')
-rw-r--r--vp8/encoder/encodeframe.c20
-rw-r--r--vp8/encoder/encodeintra.c3
-rw-r--r--vp8/encoder/encodeintra.h2
-rw-r--r--vp8/encoder/firstpass.c2
4 files changed, 9 insertions, 18 deletions
diff --git a/vp8/encoder/encodeframe.c b/vp8/encoder/encodeframe.c
index 4df35f6ed..620107500 100644
--- a/vp8/encoder/encodeframe.c
+++ b/vp8/encoder/encodeframe.c
@@ -69,10 +69,9 @@ static const unsigned char VP8_VAR_OFFS[16] = { 128, 128, 128, 128, 128, 128,
128, 128, 128, 128 };
/* Original activity measure from Tim T's code. */
-static unsigned int tt_activity_measure(VP8_COMP *cpi, MACROBLOCK *x) {
+static unsigned int tt_activity_measure(MACROBLOCK *x) {
unsigned int act;
unsigned int sse;
- (void)cpi;
/* TODO: This could also be done over smaller areas (8x8), but that would
* require extensive changes elsewhere, as lambda is assumed to be fixed
* over an entire MB in most of the code.
@@ -90,28 +89,21 @@ static unsigned int tt_activity_measure(VP8_COMP *cpi, MACROBLOCK *x) {
return act;
}
-/* Stub for alternative experimental activity measures. */
-static unsigned int alt_activity_measure(VP8_COMP *cpi, MACROBLOCK *x,
- int use_dc_pred) {
- return vp8_encode_intra(cpi, x, use_dc_pred);
-}
-
/* Measure the activity of the current macroblock
* What we measure here is TBD so abstracted to this function
*/
#define ALT_ACT_MEASURE 1
-static unsigned int mb_activity_measure(VP8_COMP *cpi, MACROBLOCK *x,
- int mb_row, int mb_col) {
+static unsigned int mb_activity_measure(MACROBLOCK *x, int mb_row, int mb_col) {
unsigned int mb_activity;
if (ALT_ACT_MEASURE) {
int use_dc_pred = (mb_col || mb_row) && (!mb_col || !mb_row);
- /* Or use and alternative. */
- mb_activity = alt_activity_measure(cpi, x, use_dc_pred);
+ /* Or use an alternative. */
+ mb_activity = vp8_encode_intra(x, use_dc_pred);
} else {
/* Original activity measure from Tim T's code. */
- mb_activity = tt_activity_measure(cpi, x);
+ mb_activity = tt_activity_measure(x);
}
if (mb_activity < VP8_ACTIVITY_AVG_MIN) mb_activity = VP8_ACTIVITY_AVG_MIN;
@@ -264,7 +256,7 @@ static void build_activity_map(VP8_COMP *cpi) {
vp8_copy_mem16x16(x->src.y_buffer, x->src.y_stride, x->thismb, 16);
/* measure activity */
- mb_activity = mb_activity_measure(cpi, x, mb_row, mb_col);
+ mb_activity = mb_activity_measure(x, mb_row, mb_col);
/* Keep frame sum */
activity_sum += mb_activity;
diff --git a/vp8/encoder/encodeintra.c b/vp8/encoder/encodeintra.c
index f89e7cb1f..7d448c0ea 100644
--- a/vp8/encoder/encodeintra.c
+++ b/vp8/encoder/encodeintra.c
@@ -18,10 +18,9 @@
#include "vp8/common/invtrans.h"
#include "encodeintra.h"
-int vp8_encode_intra(VP8_COMP *cpi, MACROBLOCK *x, int use_dc_pred) {
+int vp8_encode_intra(MACROBLOCK *x, int use_dc_pred) {
int i;
int intra_pred_var = 0;
- (void)cpi;
if (use_dc_pred) {
x->e_mbd.mode_info_context->mbmi.mode = DC_PRED;
diff --git a/vp8/encoder/encodeintra.h b/vp8/encoder/encodeintra.h
index 021dc5ed7..9a378abf4 100644
--- a/vp8/encoder/encodeintra.h
+++ b/vp8/encoder/encodeintra.h
@@ -16,7 +16,7 @@
extern "C" {
#endif
-int vp8_encode_intra(VP8_COMP *cpi, MACROBLOCK *x, int use_dc_pred);
+int vp8_encode_intra(MACROBLOCK *x, int use_dc_pred);
void vp8_encode_intra16x16mby(MACROBLOCK *x);
void vp8_encode_intra16x16mbuv(MACROBLOCK *x);
void vp8_encode_intra4x4mby(MACROBLOCK *mb);
diff --git a/vp8/encoder/firstpass.c b/vp8/encoder/firstpass.c
index 981c0fde3..14164ebc5 100644
--- a/vp8/encoder/firstpass.c
+++ b/vp8/encoder/firstpass.c
@@ -567,7 +567,7 @@ void vp8_first_pass(VP8_COMP *cpi) {
vp8_copy_mem16x16(x->src.y_buffer, x->src.y_stride, x->thismb, 16);
/* do intra 16x16 prediction */
- this_error = vp8_encode_intra(cpi, x, use_dc_pred);
+ this_error = vp8_encode_intra(x, use_dc_pred);
/* "intrapenalty" below deals with situations where the intra
* and inter error scores are very low (eg a plain black frame)