aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMike Colagrosso <mcolagrosso@google.com>2016-04-11 16:13:35 -0600
committerMike Colagrosso <mcolagrosso@google.com>2016-04-13 18:12:35 +0000
commite90f36f712514d9aacd4fa6a0381ad325ab68331 (patch)
tree1b6767bf5988d6d6e37df27d3f78f1235a048779
parentbf7d6630202b63a2fbd036efb7e5894386bcbb19 (diff)
downloadlibweave-e90f36f712514d9aacd4fa6a0381ad325ab68331.tar.gz
libweave: Update comment on handling new commands
The old comment in DeviceRegistrationInfo::OnCommandCreated() was left over from when the code would use the command received via the notification channel. Now the code always fetches commands from the command queue when it receives a notification that there is a new command. The code ignores the actual command in the notification payload. Change-Id: I1b7f7eedc337280035a5a6ec45f5935f780cac7f Reviewed-on: https://weave-review.googlesource.com/3190 Reviewed-by: John Mccullough <jmccullough@google.com>
-rw-r--r--src/device_registration_info.cc4
1 files changed, 1 insertions, 3 deletions
diff --git a/src/device_registration_info.cc b/src/device_registration_info.cc
index b7ff589..6353e12 100644
--- a/src/device_registration_info.cc
+++ b/src/device_registration_info.cc
@@ -1330,9 +1330,7 @@ void DeviceRegistrationInfo::OnCommandCreated(
VLOG(1) << "Command notification received: " << command;
- // If the command was too big to be delivered over a notification channel,
- // or OnCommandCreated() was initiated from the Pull notification,
- // perform a manual command fetch from the server here.
+ // Manually fetch the command queue whenever a new command is received.
FetchAndPublishCommands(fetch_reason::kNewCommand);
}